Bug 152625 - Table / column / row selection cursors are invisible on black background
Summary: Table / column / row selection cursors are invisible on black background
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
6.3.6.2 release
Hardware: All All
: medium normal
Assignee: Caolán McNamara
URL:
Whiteboard: target:7.6.0 target:7.5.4
Keywords: accessibility, bibisected, bisected, regression
Depends on:
Blocks: UI-Theming Writer-Tables-Select Mouse-Cursor
  Show dependency treegraph
 
Reported: 2022-12-20 23:04 UTC by Stéphane Guillou (stragu)
Modified: 2023-10-19 15:22 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Stéphane Guillou (stragu) 2022-12-20 23:04:42 UTC
Vertical, horizontal and diagonal arrow cursors used for table selection don't have a white outline like other cursors. This means they become invisible if the page background is black, it is displayed as black in high contrast mode, or the LibreOffice Dark application colour scheme is used.

Steps:
1. Open Writer
2. Use Format > Page style > Area to make the background black
3. Insert a table inside the black area
4. Hover next to columns or rows or the top-left table corner

Result:
Arrow cursors invisible.

Version: 6.3.6.2
Build ID: 2196df99b074d8a661f4036fca8fa0cbfa33a497
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3; 
Locale: en-AU (en_AU.UTF-8); UI-Language: en-US
Calc: threaded

Regression, as not reproducible with:

Version: 6.2.0.0.beta1
Build ID: d1b41307be3f8c19fe6f1938cf056e7ff1eb1d18
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3; 
Locale: en-AU (en_AU.UTF-8); UI-Language: en-US
Calc: threaded
Comment 1 V Stuart Foote 2022-12-21 01:54:56 UTC
confirmed

Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 98f0dd5e15733ac7f1d929d06ab230b5f04121d5
CPU threads: 8; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: threaded

The pointer cursors for the table remain black and do not toggle. Seems fg/bg should toggle in response to UI display values to render pointers with contract to bg.
Comment 2 raal 2023-04-18 17:11:16 UTC
This seems to have begun at the below commit in bibisect repository/OS bibisect-linux-64-6.3.
Adding Cc: to Noel Grandin & Caolán McNamara; Could you possibly take a look at this one?
Thanks
 226a563bc37c76a9cc7a73b12ebac4018d51c017 is the first bad commit
commit 226a563bc37c76a9cc7a73b12ebac4018d51c017
Author: Jenkins Build User <tdf@pollux.tdf>
Date:   Tue Mar 5 08:23:17 2019 +0100

    source 25d176ada67ada550bd4d0d08177c232cf7eeb37

68695: tdf#123796 Wrong cursor when inserting shape | https://gerrit.libreoffice.org/c/core/+/68695


and related 83112: Resolves: tdf#108452 invisible all-black drawing cursors on black bg | https://gerrit.libreoffice.org/c/core/+/83112
Comment 3 Caolán McNamara 2023-04-20 09:22:29 UTC
I think these are the:

vcl/res/tab_select_e
vcl/res/tab_select_s
vcl/res/tab_select_se
vcl/res/tab_select_sw
vcl/res/tab_select_w

icons
Comment 4 Commit Notification 2023-04-20 16:03:27 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/d9eea89a53248744e6560958b6353176850a5d2a

Resolves: tdf#152625 add a border around the tab_select_* icons

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 5 Caolán McNamara 2023-04-20 16:04:04 UTC
that seems to be ok for me in trunk now, backport to 7-5 in gerrit
Comment 6 Commit Notification 2023-04-23 09:02:45 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-7-5":

https://git.libreoffice.org/core/commit/c2fc9a2548b723407802d320502b881a8dff5ac3

Resolves: tdf#152625 add a border around the tab_select_* icons

It will be available in 7.5.4.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 7 Commit Notification 2023-04-23 22:18:03 UTC
Rizal Muttaqin committed a patch related to this issue.
It has been pushed to "libreoffice-7-5":

https://git.libreoffice.org/core/commit/29760e24cbebd64137caa90a0ea1c34a9ae19846

tdf#152625 Revise Colibre's tab_select* icons

It will be available in 7.5.4.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 8 Commit Notification 2023-04-23 22:18:06 UTC
Rizal Muttaqin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/14a23ef47c8ceaa1fc6dc4a7a942fb8360ea4bfd

tdf#152625 Revise Colibre's tab_select* icons

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 9 Stéphane Guillou (stragu) 2023-10-19 15:22:16 UTC
Verified in:

Version: 7.6.2.1 (X86_64) / LibreOffice Community
Build ID: 56f7684011345957bbf33a7ee678afaf4d2ba333
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

Thank you!