Bug 152671 - ui, accessibility: auto filter drop down menu is not spoken by the screen reader
Summary: ui, accessibility: auto filter drop down menu is not spoken by the screen reader
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
7.4.3.2 release
Hardware: All Windows (All)
: medium normal
Assignee: Michael Weghorn
URL:
Whiteboard: target:7.6.0 target:7.5.3 target:24.2.0
Keywords: accessibility
Depends on:
Blocks: a11y-Windows
  Show dependency treegraph
 
Reported: 2022-12-25 09:51 UTC by ilya paschuk
Modified: 2023-08-18 05:10 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description ilya paschuk 2022-12-25 09:51:37 UTC
steps to reproduce:
1. open any document in the calc
2. select filtering range
3. press ctrl+shift+l to enable the auto filter
4. select heading of filtered column
5. press alt+down to open the dropdown list

actual behavior:
nothing is spoken by the screen reader software, movements in the list by the arrow keys are not spoken.

expected:
this list should be spoken by the screen reader


suggested solution:
add a setting to replace the current dropdown implementation with the something more simple (for example, the modal popup dialog with the combobox control).
it will be less visually attractive, but it will be accessible.
possibly automaticly enable this simplified variant if the screen reader is detected.


screen reader used in testing: NVDA 2022.2
Comment 1 Stéphane Guillou (stragu) 2022-12-27 12:16:43 UTC
Thanks, Ilya. I tested on Linux:

Using Orca 3.36.2 on Ubuntu 20.04, items like "Sort ascending" can be read properly in the dropdown, but once it gets to the value list, it crashes Orca.
It is a bit inconsistent, as in my tests I have managed to hear it speak a couple of value before it stopped reading anything entirely.
Running Orca from the command line, I get a Python stack overflow.

However, on Fedora 36 with Orca 42.0, it works well for all dropdown items, so seems the issue has been fixed in Orca.

Ilya, is it only the list of values that is problematic with NVDA? Or are the menu items like "Sort ascending" also ignored?

Versions used:

Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 29c2bba1f3ef216d226c97197185066880fc1ab5
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

Version: 7.4.3.2 / LibreOffice Community
Build ID: 1048a8393ae2eeec98dff31b5c133c5f1d08b890
(rest same as above)

Version: 7.4.3.2 / LibreOffice Community
Build ID: 1048a8393ae2eeec98dff31b5c133c5f1d08b890
CPU threads: 4; OS: Linux 6.0; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded
Comment 2 ilya paschuk 2023-01-07 11:02:35 UTC
thank you for your fast reaction.
please give precise step sequence (how to reach the problematic sorting menu items)?
of corse, using only the keyboard.
Comment 3 Michael Weghorn 2023-03-14 14:20:22 UTC
I can reproduce the issue on Windows with the current development version (git master) as of commit 982b550541cc68670cad222e921fd62a4c1f232c. Interestingly, NVDA starts announcing the items once the mouse has been hovered over the control.

This may have the same root cause as described in bug 140762 comment 1.

It works fine with Orca on Linux with the gtk3 VCL plugin.
Comment 4 Michael Weghorn 2023-03-15 16:11:53 UTC
Pending Gerrit change: https://gerrit.libreoffice.org/c/core/+/148933
Comment 5 Commit Notification 2023-03-16 06:44:12 UTC
Michael Weghorn committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/c379f1b978c3ad4578c130675c1e0a82c70823c0

tdf#140762 tdf#152671 Make dock win visible before showing popup

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 6 Michael Weghorn 2023-03-16 06:55:12 UTC
Items in the existing dropdown implementation are announced by NVDA now as well in the current development version of LO with the commit from comment 5 in place.
Comment 7 Commit Notification 2023-03-22 13:14:10 UTC
Michael Weghorn committed a patch related to this issue.
It has been pushed to "libreoffice-7-5":

https://git.libreoffice.org/core/commit/dc0706cabfe39ddb6ea23d60ccfb756f2b9e6efb

tdf#140762 tdf#152671 Make dock win visible before showing popup

It will be available in 7.5.3.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 8 Commit Notification 2023-08-18 04:06:24 UTC
Michael Weghorn committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/230789766b364bf995e6659dd589cdf902c69f2c

tdf#156561 tdf#141101 Revert "tdf#140762 tdf#152671 Make dock win ..." et al

It will be available in 24.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 9 Michael Weghorn 2023-08-18 05:10:35 UTC
(In reply to Commit Notification from comment #8)
> Michael Weghorn committed a patch related to this issue.
> It has been pushed to "master":
> 
> https://git.libreoffice.org/core/commit/
> 230789766b364bf995e6659dd589cdf902c69f2c
> 
> tdf#156561 tdf#141101 Revert "tdf#140762 tdf#152671 Make dock win ..." et al

For clarification: This was reverted because it's no longer needed and the auto filter is announced properly with NVDA without it now, see the full commit message for more details.