Description: Open a new Writer document. Format - Character In the dbg build of LibreOffice I get in terminal this warnings: warn:svtools.misc:86308:86308:svtools/source/misc/langtab.cxx:244: Language: 0x7e0 with unknown name, so returning lang-tag of: Spanish (Equatorial Guinea) {es-GQ} warn:svtools.misc:86308:86308:svtools/source/misc/langtab.cxx:244: Language: 0x7e1 with unknown name, so returning lang-tag of: Spanish (Philippines) {es-PH} warn:svtools.misc:86308:86308:svtools/source/misc/langtab.cxx:244: Language: 0x540a with unknown name, so returning lang-tag of: Spanish (United States) {es-US} warn:svtools.misc:86308:86308:svtools/source/misc/langtab.cxx:244: Language: 0xe40a with unknown name, so returning lang-tag of: Spanish {es} warn:svtools.misc:86308:86308:svtools/source/misc/langtab.cxx:244: Language: 0x540a with unknown name, so returning lang-tag of: Spanish (United States) {es-US} warn:svtools.misc:86308:86308:svtools/source/misc/langtab.cxx:244: Language: 0xe40a with unknown name, so returning lang-tag of: Spanish {es} warn:svtools.misc:86308:86308:svtools/source/misc/langtab.cxx:244: Language: 0x540a with unknown name, so returning lang-tag of: Spanish (United States) {es-US} warn:svtools.misc:86308:86308:svtools/source/misc/langtab.cxx:244: Language: 0xe40a with unknown name, so returning lang-tag of: Spanish {es} warn:svl.items:86308:86308:svl/source/items/itempool.cxx:442: old secondary pool: EditEngineItemPool of pool: XOutdevItemPool must be empty. warn:svl.items:86308:86308:svl/source/items/itempool.cxx:442: old secondary pool: EditEngineItemPool of pool: XOutdevItemPool must be empty. warn:svl.items:86308:86308:svl/source/items/itempool.cxx:442: old secondary pool: EditEngineItemPool of pool: XOutdevItemPool must be empty. warn:svl.items:86308:86308:svl/source/items/itempool.cxx:442: old secondary pool: EditEngineItemPool of pool: XOutdevItemPool must be empty. Steps to Reproduce: see description Actual Results: warnings Expected Results: no warnings Reproducible: Always User Profile Reset: Yes Additional Info: Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: b9e3e20bfd102880d12384892eaeca094c38a519 CPU threads: 16; OS: Linux 5.15; UI render: default; VCL: gtk3 Locale: ro-RO (ro_RO.UTF-8); UI: en-US Calc: threaded
Partial of this warning when Format - Paragraph: warn:svl.items:86308:86308:svl/source/items/itempool.cxx:442: old secondary pool: EditEngineItemPool of pool: XOutdevItemPool must be empty. warn:svl.items:86308:86308:svl/source/items/itempool.cxx:442: old secondary pool: EditEngineItemPool of pool: XOutdevItemPool must be empty. warn:svl.items:86308:86308:svl/source/items/itempool.cxx:442: old secondary pool: EditEngineItemPool of pool: XOutdevItemPool must be empty. warn:svl.items:86308:86308:svl/source/items/itempool.cxx:442: old secondary pool: EditEngineItemPool of pool: XOutdevItemPool must be empty.
Regarding the svtools/source/misc/langtab.cxx:244: Language warnings, that's a good source of information what on-the-fly language tags are added to the predefined list. Nothing to worry about. To be investigated though is whether attempting to obtain some more than once could be avoided. svl/source/items/itempool.cxx:442: old secondary pool should be looked at.
The same warnings are generated after we have some comments in a document and we want to format them (Format - Comments), so the Character window is opening with the same result I mentioned in description.
(In reply to Eike Rathke from comment #2) > Regarding the > svtools/source/misc/langtab.cxx:244: Language > warnings, that's a good source of information what on-the-fly language tags > are added to the predefined list. Nothing to worry about. > To be investigated though is whether attempting to obtain some more than > once could be avoided. > > svl/source/items/itempool.cxx:442: old secondary pool > should be looked at. In my list of languages from Character window I see that some languages are checked, from example, French (Monaco). But in the list from description is just Spanish. So, I supose something is not well detected about Spanish language. ("Language: 0x7e0 with unknown name").
(In reply to BogdanB from comment #4) > (In reply to Eike Rathke from comment #2) > > Regarding the > > svtools/source/misc/langtab.cxx:244: Language > > warnings, that's a good source of information what on-the-fly language tags > > are added to the predefined list. Nothing to worry about. > > To be investigated though is whether attempting to obtain some more than > > once could be avoided. > > > > svl/source/items/itempool.cxx:442: old secondary pool > > should be looked at. > > In my list of languages from Character window I see that some languages are > checked, from example, French (Monaco). But in the list from description is > just Spanish. So, I supose something is not well detected about Spanish > language. ("Language: 0x7e0 with unknown name"). I searched in svtools/source/misc/langtab.cxx:244 and the number is formed by 0x plus the number for language. ----- warn:svtools.misc:86308:86308:svtools/source/misc/langtab.cxx:244: Language: 0x540a with unknown name, so returning lang-tag of: Spanish (United States) {es-US} ---- For this warning for example in lang.h line 400 we have ---- #define LANGUAGE_SPANISH_UNITED_STATES LanguageType(0x540A) ---- Could be upper case the reason for error?
In /core/writerfilter/source/dmapper/ThemeHandler.cxx we have: case 0x540a: // lidSpanishUS in fromLCIDToScriptTag()
(In reply to BogdanB from comment #5) > Could be upper case the reason for error? No. First, it's not an error, just an informational warning. Second, it's simply that for the es-US language/locale we don't have a predefined entry in the UI language list svtools/inc/langtab.hrc and the entry gets generated as "Spanish (United States) {es-US}" when encountered. There is no harm. (In reply to BogdanB from comment #4) > in the list from description is > just Spanish. So, I supose something is not well detected about Spanish > language. ("Language: 0x7e0 with unknown name"). It's almost perfectly fine. Again, the reason is we don't have a predefined UI language list entry. The Spanish 'es' entry probably gets generated because you have <LibreOffice-instdir>/share/extensions/dict-es/es.{aff,dic} files on your system. Similar the "Spanish (United States) {es-US}" for <LibreOffice-instdir>/share/extensions/dict-es/es_US.{aff,dic} and "Spanish (Equatorial Guinea) {es-GQ}" for <LibreOffice-instdir>/share/extensions/dict-es/es_GQ.{aff,dic} and "Spanish (Philippines) {es-PH}" for <LibreOffice-instdir>/share/extensions/dict-es/es_PH.{aff,dic} Though for es-GQ 0x7e0 and es-PH 0x7e1 we should probably have a better mapping involving the 0x00a primary language ID for Spanish instead of the on-the-fly IDs.
Eike Rathke committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/8343376c10eef50a022f600e0bd03f1384e9a288 Related: tdf#152781 s/lang-tag of/generated/ in SAL_WARN It will be available in 7.6.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Eike Rathke committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/cb4c33ef88a0ef252383e7a12678f28c4432347e Related: tdf#152781 Add also non-on-the-fly IDs to language list It will be available in 7.6.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
> > The Spanish 'es' entry probably gets generated because you have > <LibreOffice-instdir>/share/extensions/dict-es/es.{aff,dic} files on your > system. Similar the "Spanish (United States) {es-US}" for > <LibreOffice-instdir>/share/extensions/dict-es/es_US.{aff,dic} and "Spanish > (Equatorial Guinea) {es-GQ}" for > <LibreOffice-instdir>/share/extensions/dict-es/es_GQ.{aff,dic} and "Spanish > (Philippines) {es-PH}" for > <LibreOffice-instdir>/share/extensions/dict-es/es_PH.{aff,dic} > > Though for es-GQ 0x7e0 and es-PH 0x7e1 we should probably have a better > mapping involving the 0x00a primary language ID for Spanish instead of the > on-the-fly IDs. I reset to Factory Settings, so no user profile. Also on my system I don't use and I don't have Spanish. If someone else can confirm this languages appears no matter we are using Spanish or not, this mean this languages should be added in langtab, and they don't need to be shown if they are not used by user. I have seen your recently commits, but I can't test them until next week.
(In reply to BogdanB from comment #10) > I reset to Factory Settings, so no user profile. Note I wrote <LibreOffice-instdir>/share/, that is not the user profile but the installation. > Also on my system I don't use and I don't have Spanish. You have Spanish dictionaries _somewhere_, otherwise those language list entries would not be generated. If it's not in the LibreOffice installation then maybe from myspell/hunspell system dictionaries. But with es-GQ, es-PH and es-US it's much likely our own bundled dictionary extension. > If someone else can confirm this languages appears no matter we are using > Spanish or not, this mean this languages should be added in langtab, and > they don't need to be shown if they are not used by user. All predefined languages present in langtab are shown in the character language listbox. Fwiw, the 0xe40a for 'es' is wrong, it should be 0xa instead and then it would also not be shown in the list (as it's only the primary ID without sublanguage ID). Follow-up fix coming. es-GQ, es-PH and es-US are correctly generated, though as said we should have a fixed defined mapping for es-GQ and es-PH as we offer those dictionaries.
I retested the bug after first 2 commits (I know the bug is not completed) This is how is looking now: duplicated line eliminated and "generated" instead of "lang-tag". Nice. warn:svtools.misc:83679:83679:svtools/source/misc/langtab.cxx:244: Language: 0x7e0 with unknown name, so returning generated: Spanish (Equatorial Guinea) {es-GQ} warn:svtools.misc:83679:83679:svtools/source/misc/langtab.cxx:244: Language: 0x7e1 with unknown name, so returning generated: Spanish (Philippines) {es-PH} warn:svtools.misc:83679:83679:svtools/source/misc/langtab.cxx:244: Language: 0x540a with unknown name, so returning generated: Spanish (United States) {es-US} warn:svtools.misc:83679:83679:svtools/source/misc/langtab.cxx:244: Language: 0xe40a with unknown name, so returning generated: Spanish {es} warn:svl.items:83679:83679:svl/source/items/itempool.cxx:442: old secondary pool: EditEngineItemPool of pool: XOutdevItemPool must be empty. warn:svl.items:83679:83679:svl/source/items/itempool.cxx:442: old secondary pool: EditEngineItemPool of pool: XOutdevItemPool must be empty. warn:svl.items:83679:83679:svl/source/items/itempool.cxx:442: old secondary pool: EditEngineItemPool of pool: XOutdevItemPool must be empty. warn:svl.items:83679:83679:svl/source/items/itempool.cxx:442: old secondary pool: EditEngineItemPool of pool: XOutdevItemPool must be empty. Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: cb4c33ef88a0ef252383e7a12678f28c4432347e CPU threads: 4; OS: Linux 5.19; UI render: default; VCL: gtk3 Locale: ro-RO (ro_RO.UTF-8); UI: en-US Calc: threaded
I listed the hunspell for Spanish and Romanian bogdan@bogdan-H110M-S2H:~$ apt list hunspell-es hunspell-es/kinetic,kinetic 1:7.4.1-1 all bogdan@bogdan-H110M-S2H:~$ apt list hunspell-ro hunspell-ro/kinetic,kinetic,now 1:7.4.1-1 all [installed] It's different for Romanian and Spanish. If this helps.
Also myspell for Romanian and Spanish. bogdan@bogdan-H110M-S2H:~$ apt list myspell-ro bogdan@bogdan-H110M-S2H:~$ apt list myspell-es myspell-es/kinetic,kinetic 1.11-19 all
Eike Rathke committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/375630ae76f46c096421dfadee8d37b406bc10c5 Related: tdf#152781 Stab the 0xE40A {es} vs Latin America quirk It will be available in 7.6.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Eike Rathke committed a patch related to this issue. It has been pushed to "libreoffice-7-5": https://git.libreoffice.org/core/commit/3aa8e02ce9de14225fe8aa1c31618abe1baa4f5e Related: tdf#152781 Add also non-on-the-fly IDs to language list It will be available in 7.5.0.2. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Eike Rathke committed a patch related to this issue. It has been pushed to "libreoffice-7-5": https://git.libreoffice.org/core/commit/b959a2290f218dcae081d30e9da11c5a602ba5a5 Related: tdf#152781 Stab the 0xE40A {es} vs Latin America quirk It will be available in 7.5.0.2. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Eike Rathke committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/54d25b36c0bf3dcc715f2098ad658bb113e868ec Related: tdf#152781 Pin some known on-the-fly langtags to user-defined LCIDs It will be available in 7.6.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Eike Rathke committed a patch related to this issue. It has been pushed to "libreoffice-7-5": https://git.libreoffice.org/core/commit/aa445da4c0cfc1491ceac80126ec6503677c672b Related: tdf#152781 Pin some known on-the-fly langtags to user-defined LCIDs It will be available in 7.5.0.2. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
This is my latest test on dbg version, after all the changes warn:svtools.misc:198943:198943:svtools/source/misc/langtab.cxx:244: Language: 0x540a with unknown name, so returning generated: Spanish (United States) {es-US} warn:svtools.misc:198943:198943:svtools/source/misc/langtab.cxx:244: Language: 0x840a with unknown name, so returning generated: Spanish (Equatorial Guinea) {es-GQ} warn:svtools.misc:198943:198943:svtools/source/misc/langtab.cxx:244: Language: 0x880a with unknown name, so returning generated: Spanish (Philippines) {es-PH} warn:svl.items:198943:198943:svl/source/items/itempool.cxx:442: old secondary pool: EditEngineItemPool of pool: XOutdevItemPool must be empty. warn:svl.items:198943:198943:svl/source/items/itempool.cxx:442: old secondary pool: EditEngineItemPool of pool: XOutdevItemPool must be empty. warn:svl.items:198943:198943:svl/source/items/itempool.cxx:442: old secondary pool: EditEngineItemPool of pool: XOutdevItemPool must be empty. warn:svl.items:198943:198943:svl/source/items/itempool.cxx:442: old secondary pool: EditEngineItemPool of pool: XOutdevItemPool must be empty. Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: d07b1cc8148140bd3a78103da668d002b9d266ab CPU threads: 16; OS: Linux 5.15; UI render: default; VCL: gtk3 Locale: ro-RO (ro_RO.UTF-8); UI: en-US Calc: threaded
A new retesting warn:svtools.misc:86197:86197:svtools/source/misc/langtab.cxx:248: Language: 0x540a with unknown name, so returning generated: Spanish (United States) {es-US} warn:svtools.misc:86197:86197:svtools/source/misc/langtab.cxx:248: Language: 0x840a with unknown name, so returning generated: Spanish (Equatorial Guinea) {es-GQ} warn:svtools.misc:86197:86197:svtools/source/misc/langtab.cxx:248: Language: 0x880a with unknown name, so returning generated: Spanish (Philippines) {es-PH} warn:svl.items:86197:86197:svl/source/items/itempool.cxx:442: old secondary pool: EditEngineItemPool of pool: XOutdevItemPool must be empty. warn:svl.items:86197:86197:svl/source/items/itempool.cxx:442: old secondary pool: EditEngineItemPool of pool: XOutdevItemPool must be empty. warn:svl.items:86197:86197:svl/source/items/itempool.cxx:442: old secondary pool: EditEngineItemPool of pool: XOutdevItemPool must be empty. warn:svl.items:86197:86197:svl/source/items/itempool.cxx:442: old secondary pool: EditEngineItemPool of pool: XOutdevItemPool must be empty. warn:legacy.osl:86197:86197:comphelper/source/misc/accessiblecomponenthelper.cxx:195: OCommonAccessibleComponent::getAccessibleIndexInParent: invalid creator! warn:legacy.osl:86197:86197:comphelper/source/misc/accessiblecomponenthelper.cxx:195: OCommonAccessibleComponent::getAccessibleIndexInParent: invalid creator! warn:legacy.osl:86197:86197:comphelper/source/misc/accessiblecomponenthelper.cxx:195: OCommonAccessibleComponent::getAccessibleIndexInParent: invalid creator! warn:legacy.osl:86197:86197:comphelper/source/misc/accessiblecomponenthelper.cxx:195: OCommonAccessibleComponent::getAccessibleIndexInParent: invalid creator! warn:legacy.osl:86197:86197:comphelper/source/misc/accessiblecomponenthelper.cxx:195: OCommonAccessibleComponent::getAccessibleIndexInParent: invalid creator! warn:legacy.osl:86197:86197:comphelper/source/misc/accessiblecomponenthelper.cxx:195: OCommonAccessibleComponent::getAccessibleIndexInParent: invalid creator! warn:legacy.osl:86197:86197:comphelper/source/misc/accessiblecomponenthelper.cxx:195: OCommonAccessibleComponent::getAccessibleIndexInParent: invalid creator! warn:legacy.osl:86197:86197:comphelper/source/misc/accessiblecomponenthelper.cxx:195: OCommonAccessibleComponent::getAccessibleIndexInParent: invalid creator! bogdan@bogdan-H110M-S2H:~$ apt list hunspell-es Listing... Finished hunspell-es/lunar,lunar 1:7.5.0-1 all bogdan@bogdan-H110M-S2H:~$ apt list hunspell-ro Listing... Finished hunspell-ro/lunar,lunar,now 1:7.5.0-1 all [installed] bogdan@bogdan-H110M-S2H:~$ apt list myspell-ro Listing... Finished bogdan@bogdan-H110M-S2H:~$ apt list myspell-es Listing... Finished myspell-es/lunar,lunar 1.11-20 all
Retested: warn:svtools.misc:315365:315365:svtools/source/misc/langtab.cxx:248: Language: 0x540a with unknown name, so returning generated: Spanish (United States) {es-US} warn:svtools.misc:315365:315365:svtools/source/misc/langtab.cxx:248: Language: 0x840a with unknown name, so returning generated: Spanish (Equatorial Guinea) {es-GQ} warn:svtools.misc:315365:315365:svtools/source/misc/langtab.cxx:248: Language: 0x880a with unknown name, so returning generated: Spanish (Philippines) {es-PH} warn:svl.items:315365:315365:svl/source/items/itempool.cxx:442: old secondary pool: EditEngineItemPool of pool: XOutdevItemPool must be empty. warn:svl.items:315365:315365:svl/source/items/itempool.cxx:442: old secondary pool: EditEngineItemPool of pool: XOutdevItemPool must be empty. warn:svl.items:315365:315365:svl/source/items/itempool.cxx:442: old secondary pool: EditEngineItemPool of pool: XOutdevItemPool must be empty. warn:svl.items:315365:315365:svl/source/items/itempool.cxx:442: old secondary pool: EditEngineItemPool of pool: XOutdevItemPool must be empty. Version: 7.6.0.0.alpha1+ (X86_64) / LibreOffice Community Build ID: f3aab159f1c1e00c25e6b4ca1e50813bc343f4f3 CPU threads: 16; OS: Linux 5.19; UI render: default; VCL: gtk3 Locale: ro-RO (ro_RO.UTF-8); UI: en-US Calc: threaded
Retested with Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 0e17d8ddccdee7d4f46b256153853e1cab87c99e CPU threads: 16; OS: Linux 5.19; UI render: default; VCL: gtk3 Locale: ro-RO (ro_RO.UTF-8); UI: en-US Calc: threaded warn:svtools.misc:1053907:1053907:svtools/source/misc/langtab.cxx:248: Language: 0x540a with unknown name, so returning generated: Spanish (United States) {es-US} warn:svtools.misc:1053907:1053907:svtools/source/misc/langtab.cxx:248: Language: 0x840a with unknown name, so returning generated: Spanish (Equatorial Guinea) {es-GQ} warn:svtools.misc:1053907:1053907:svtools/source/misc/langtab.cxx:248: Language: 0x880a with unknown name, so returning generated: Spanish (Philippines) {es-PH} warn:svl.items:1053907:1053907:svl/source/items/itempool.cxx:442: old secondary pool: EditEngineItemPool of pool: XOutdevItemPool must be empty. warn:svl.items:1053907:1053907:svl/source/items/itempool.cxx:442: old secondary pool: EditEngineItemPool of pool: XOutdevItemPool must be empty. warn:svl.items:1053907:1053907:svl/source/items/itempool.cxx:442: old secondary pool: EditEngineItemPool of pool: XOutdevItemPool must be empty. warn:svl.items:1053907:1053907:svl/source/items/itempool.cxx:442: old secondary pool: EditEngineItemPool of pool: XOutdevItemPool must be empty.