Following the fix for bug 85952, we have the label "[placeholder for message]" for the message area of the Find toolbar. Steps: 1. Open Writer or Calc 2. Ctrl + F to open the Find toolbar 3. Search for a term that is not in the document 4. Hover over the message Result: Label is "[placeholder for message]". It makes it look like we forgot to fill in a placeholder for a proper label. Expected result: We need a better label to describe what this area does. Extra info: This toolbar area can hold messages like: * "Reached the [end|beginning] of the document" * "Search key not found" * "Search key found x times" (in Writer, when using Find All) The same label is used in the Customise dialog and in the toolbar's context menu. I suggest something generic like "Information" or "Message" but interested in other suggestions that are more specific to what .uno:SearchLabel does. Code pointer: https://opengrok.libreoffice.org/xref/core/officecfg/registry/data/org/openoffice/Office/UI/GenericCommands.xcu?r=be3d34b5&mo=67314&fi=1708#1708 Versions tested: Version: 7.5.0.1 (X86_64) / LibreOffice Community Build ID: 77cd3d7ad4445740a0c6cf977992dafd8ebad8df CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win Locale: en-GB (en_GB); UI: en-GB Calc: threaded Version: 6.2.0.0.beta1 Build ID: d1b41307be3f8c19fe6f1938cf056e7ff1eb1d18 CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3; Locale: en-AU (en_AU.UTF-8); UI-Language: en-US Calc: threaded
Yes, the tooltip on empty search results is awkward. Yet we need the label for the customization dialog. Maybe adding an empty tooltip to the command attributes solves the problem. Challenge for l10n though. Andras, what do you think? Alternatively I could imagine something more descriptive like "Search results" or "Search information". Code pointer: <node oor:name=".uno:SearchLabel" oor:op="replace"> in officecfg/registry/data/org/openoffice/Office/UI/GenericCommands.xcu
We can simply add a new "TooltipLabel" property to the command. Since it only has a "Label" property, the label is being used as the tooltip. The fix would look like this: <node oor:name=".uno:SearchLabel" oor:op="replace"> <prop oor:name="Label" oor:type="xs:string"> <value xml:lang="en-US">[placeholder for message]</value> </prop> <prop oor:name="TooltipLabel" oor:type="xs:string"> <value xml:lang="en-US">Search results</value> </prop> </node> Not that the "[placeholder for message]" is replaced as the string content of the command and the newly added "TooltipLabel" is then used as tooltip.
Rafael Lima committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/25d5e2041fb13aee61acb6ced579e884ce9a21b5 tdf#152860 Fix tooltip for .uno:SearchLabel command It will be available in 7.6.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Verified fix in: Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: af8fdba1194e657237f9abc460381a1c4bc49982 CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3 Locale: en-AU (en_AU.UTF-8); UI: en-US Calc: threaded Thanks Heiko and Rafael!
*** Bug 156845 has been marked as a duplicate of this bug. ***