Bug 152905 - "Modify..." in Styles sidebar should be "Edit Style..." to match rest of UI
Summary: "Modify..." in Styles sidebar should be "Edit Style..." to match rest of UI
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
Inherited From OOo
Hardware: All All
: lowest trivial
Assignee: Rafael Lima
URL:
Whiteboard: target:7.6.0 target:24.2.0
Keywords: difficultyBeginner, easyHack, skillDesign, topicUI
Depends on:
Blocks: Sidebar-Styles
  Show dependency treegraph
 
Reported: 2023-01-06 18:15 UTC by Stéphane Guillou (stragu)
Modified: 2023-09-06 09:52 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Stéphane Guillou (stragu) 2023-01-06 18:15:28 UTC
The context menu for any style in the Styles sidebar has the "Modify..." option, but it does not match the Styles menu item or the Paragraph Styles toolbar dropdown (both "Edit Style...") or the Style dialog ("Edit Style" button next in the Organizer tab).

The UNO command is .uno:EditStyle and has the label "Edit Style (Alt+P)".

Steps:
1. Open Writer or Calc
2. Open Styles sidebar (F11)
3. Right-click on any style

Result:
Item is "Modify...".

Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: ec2f1d73936c9d8cee83c0887170e9ecb8f044ba
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

Inherited:

OpenOffice.org 3.3.0
OOO330m20 (Build:9567)
Comment 1 Rafael Lima 2023-01-09 18:08:08 UTC
I had never noticed this... but IMO this request makes sense.

Let's CC the UX team.

The fix would be very simple. Code pointer:

https://opengrok.libreoffice.org/xref/core/sfx2/uiconfig/ui/stylecontextmenu.ui
Comment 2 Heiko Tietze 2023-01-10 08:08:48 UTC
The command .uno:EditStyle changes the currently active style while this function works on what is selected in the Stylist. Change the label in sfx2/uiconfig/ui/stylecontextmenu.ui, ("Edit Style...", without (Alt+P)!).
Comment 3 Commit Notification 2023-01-11 10:08:02 UTC
Rafael Lima committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/0bd3600d9415c10891ea1d90dd598d827d1a9c48

tdf#152905 Use "Edit Style" instead of "Modify" for consistency

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 4 Stéphane Guillou (stragu) 2023-01-12 10:52:23 UTC
Fix verified in:

Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 92deea6301a02f5530f17263f58402344f82013c
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

Thanks Rafael!
Comment 5 Commit Notification 2023-09-06 09:52:39 UTC
Seth Chaiklin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/help/commit/1059596b74bcecea902bb6f31b012f059e1cf63d

(related) tdf#152905   Modify -> Edit Style