Description: On pc Debian x86-64 with master sources updated today, I have a crash when lauching LO. Steps to Reproduce: 1. Launch terminal/console 2. export SAL_USE_VCLPLUGIN=gen 3. soffice Actual Results: Crash Expected Results: No crash Reproducible: Always User Profile Reset: Yes Additional Info: Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 5c4fa7ddb0b12d30304bbc6119a0aa1d3d65b55d CPU threads: 12; OS: Linux 6.0; UI render: default; VCL: gtk3 Locale: fr-FR (fr_FR.UTF-8); UI: fr-FR Calc: threaded
Created attachment 184528 [details] bt with debug symbols
Noel: thought you might be interested in this one since it seems to be a regression from: 89b1d41e0d2cd use std::optional for SALCOLOR_NONE instead of re-using an actual real color value, because it will totally not work when I convert vcl to use alpha instead of transparency
of course, we can use this patch: diff --git a/vcl/unx/generic/gdi/gdiimpl.cxx b/vcl/unx/generic/gdi/gdiimpl.cxx index 4b3b128b7442..522162fe1b11 100644 --- a/vcl/unx/generic/gdi/gdiimpl.cxx +++ b/vcl/unx/generic/gdi/gdiimpl.cxx @@ -152,7 +152,8 @@ X11SalGraphicsImpl::~X11SalGraphicsImpl() void X11SalGraphicsImpl::Init() { - mnPenPixel = mrParent.GetPixel( *moPenColor ); + if (moPenColor.has_value()) + mnPenPixel = mrParent.GetPixel( *moPenColor ); mnBrushPixel = mrParent.GetPixel( *moBrushColor ); } but would prefer having some feedback because it might just a bandaid.
Patch from Caolán here: https://gerrit.libreoffice.org/c/core/+/145180
Can't reproduce on Ubuntu 20.04 with a build that doesn't include the patch: Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 8ae84bb5566e12df64236a116b9d1889d6f5f052 CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: x11 Locale: en-AU (en_AU.UTF-8); UI: en-US Calc: threaded Am I missing something?
(In reply to Stéphane Guillou (stragu) from comment #5) > Can't reproduce on Ubuntu 20.04 with a build that doesn't include the patch: > > > Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community > Build ID: 8ae84bb5566e12df64236a116b9d1889d6f5f052 > CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: x11 > Locale: en-AU (en_AU.UTF-8); UI: en-US > Calc: threaded > > Am I missing something? Since it’s an assertion, you must have a debug build, is it your case?
Caolán McNamara committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/72a08a55791a1c17c0ec15b2ab5c7294c23e2831 tdf#152931 deref of moPenColor std::optional on launching writer It will be available in 7.6.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
I confirm it works, thank you Caolán!