Bug 152994 - Daily Screenshot Build failure
Summary: Daily Screenshot Build failure
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: graphics stack (show other bugs)
Version:
(earliest affected)
7.5.0.0 alpha1+
Hardware: All All
: medium normal
Assignee: Caolán McNamara
URL:
Whiteboard: target:7.6.0 target:7.5.1
Keywords: bibisected, bisected, regression
Depends on:
Blocks:
 
Reported: 2023-01-12 15:59 UTC by Xisco Faulí
Modified: 2023-01-16 08:41 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Xisco Faulí 2023-01-12 15:59:41 UTC
https://ci.libreoffice.org/job/lo_tb_master_win_screenshot/ is failing since August
Comment 1 Xisco Faulí 2023-01-12 16:00:30 UTC
Regression introduced by:

author	Caolán McNamara <caolanm@redhat.com>	2022-08-16 19:30:10 +0100
committer	Caolán McNamara <caolanm@redhat.com>	2022-08-17 12:40:02 +0200
commit db4c4676b70bb5f9a1c169735e8fbe92b097a57b (patch)
tree 81698c3bc910b2c4bd6d49dff5c76ba595feb2c3
parent ee3ebda2be3965584d12b52c007fb047d624b64c (diff)
Related: tdf#118320 don't require experimental to be set anymore

Adding Cc: to Caolán McNamara
Comment 2 Caolán McNamara 2023-01-12 16:17:25 UTC
Locally on my windows box make CppunitTest_chart2_dialogs_test works fine, so:

I think the failing machine is a 32bit windows build from the log, maybe that's relevant to the problem. What's the exact windows version from "System Information"? and is it possible to run the sample debugging suggestion of

make CppunitTest_chart2_dialogs_test CPPUNITTRACE="'C:/Program Files
(x86)/Microsoft Visual Studio/2019/Community/Common7/IDE/devenv.exe'
/debugexe"

and get some backtrace information
Comment 3 Xisco Faulí 2023-01-12 16:53:57 UTC
This is the command used by jenkins to execute the build: ${LODE_HOME}/bin/tb_slave_wrapper --branch=MASTER --os=Windows --screenshots --clean --distro-config=screenshot_win --config=--with-privacy-policy-url=dummy-for-ci

and screenshot_win.conf uses

--host=i686-pc-cygwin
--with-lang=ALL
--enable-odk
Comment 4 Commit Notification 2023-01-12 20:06:26 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/8ab24f26626a65e1ce9e1ff8c4eb75a20e4b7629

tdf#152994 only query dark mode in Windows >= 10.0.18362

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 5 Commit Notification 2023-01-13 10:32:41 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/65596d7062ac4edadeef84cc335a585ffa942fe0

tdf#152994 actually return in this case

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 6 Caolán McNamara 2023-01-13 20:16:35 UTC
reported works, done in trunk, backport to 7-5 in gerrit
Comment 7 Commit Notification 2023-01-16 08:41:33 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-7-5":

https://git.libreoffice.org/core/commit/1ee2e012a41af4b507f533859ef5ce7d68eb5e89

tdf#152994 only query dark mode in Windows >= 10.0.18362

It will be available in 7.5.1.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.