Bug 153052 - Image insert results in two undo actions added to undo stack
Summary: Image insert results in two undo actions added to undo stack
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
unspecified
Hardware: All All
: medium normal
Assignee: Jim Raykowski
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: Undo-Redo
  Show dependency treegraph
 
Reported: 2023-01-16 22:02 UTC by Jim Raykowski
Modified: 2023-05-05 15:13 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jim Raykowski 2023-01-16 22:02:23 UTC
Came across this while hacking on enhancement Bug 149073

Steps to repro:
1) Open Calc
2) Insert an image (Menu->Insert->Image...)

Results: Two undo actions are added, "Insert image with transparency 'Image 1'"
and "Change object name of Image with transparency to 'Image 1'"

To see this click on the Undo control drop down in the Standard tool bar or wherever you may have it.

Expected results: One undo action added, "Insert image with transparency 'Image 1'"
Comment 1 Telesto 2023-01-17 13:38:57 UTC
Confirm
Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 37e3455a13ab5741104bf41d05a80e60a4612682
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: nl-NL (nl_NL); UI: en-US
Calc: CL threaded
Comment 2 Jim Raykowski 2023-01-17 18:53:01 UTC
Proposed patch:
https://gerrit.libreoffice.org/c/core/+/145530
Comment 3 Jim Raykowski 2023-01-20 06:31:52 UTC
I mistakenly pasted the wrong link. Here is the correct link:
https://gerrit.libreoffice.org/c/core/+/145647