Bug 153260 - FILESAVE DOCX VML write trim=t for Fontwork shapes
Summary: FILESAVE DOCX VML write trim=t for Fontwork shapes
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
7.6.0.0 alpha0+
Hardware: x86-64 (AMD64) Windows (All)
: medium normal
Assignee: Regina Henschel
URL:
Whiteboard: target:7.6.0 target:7.5.1
Keywords:
Depends on:
Blocks: FontWork-WordArt 128568 VML-Shapes
  Show dependency treegraph
 
Reported: 2023-01-28 16:16 UTC by Regina Henschel
Modified: 2023-02-01 13:48 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:


Attachments
Example to see inadequate VML export (19.19 KB, application/vnd.oasis.opendocument.text)
2023-01-28 16:16 UTC, Regina Henschel
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Regina Henschel 2023-01-28 16:16:53 UTC
Created attachment 184979 [details]
Example to see inadequate VML export

LibreOffice is not able to render the trim="f" attribute of <v:textpath> of VML. LibreOffice always renders it as if trim="t" is used. The default value for the 'trim' attribute is 'false'. So to reflect LO way of rendering in file markup, the attribute trim="t" has always to be written out.

Open attached file and save it to docx format. Open the saved file in Word or reopen it in LO. Notice, that the height of the characters in the Fontwork shape is smaller than in the original odt-document.

[BTW, the Fontwork type "TextSlantUp" was chosen, because it is forced to VML already in current released LibreOffice. A daily build will show the problem too for other types, if the shape has bitmap fill.]
Comment 1 Commit Notification 2023-01-30 20:21:49 UTC
Regina Henschel committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/fc5ab71bd2b4af535c2bdd2c9ea48be378b66a19

tdf#153260 VML export write trim value true in any case

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 2 Xisco Faulí 2023-02-01 11:21:35 UTC
Verified in

Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: b052ec2f2fbe0f3044ba824c064a280a5ee9cd7f
CPU threads: 8; OS: Linux 5.10; UI render: default; VCL: gtk3
Locale: de-DE (es_ES.UTF-8); UI: en-US
Calc: threaded

@Regina, thanks for fixing this issue!!
Comment 3 Commit Notification 2023-02-01 13:48:54 UTC
Regina Henschel committed a patch related to this issue.
It has been pushed to "libreoffice-7-5":

https://git.libreoffice.org/core/commit/2af012449890a59b1eee444f4d8f18e2620d87ce

tdf#153260 VML export write trim value true in any case

It will be available in 7.5.1.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.