Bug 153352 - Promote/Demote level list should be in the Tabbed interface
Summary: Promote/Demote level list should be in the Tabbed interface
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Impress (show other bugs)
Version:
(earliest affected)
5.4.0.3 release
Hardware: All All
: medium enhancement
Assignee: Rafael Lima
URL:
Whiteboard: target:7.6.0
Keywords: difficultyMedium, easyHack, skillDesign, topicDesign
Depends on:
Blocks: Notebookbar
  Show dependency treegraph
 
Reported: 2023-02-03 14:35 UTC by Rafael Lima
Modified: 2023-02-21 19:29 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
Screenshot showing the Tabbed UI and the sidebar (158.11 KB, image/png)
2023-02-03 14:35 UTC, Rafael Lima
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Rafael Lima 2023-02-03 14:35:11 UTC
Created attachment 185084 [details]
Screenshot showing the Tabbed UI and the sidebar

In Impress, a very common task when preparing slides is to Promote/Demote a list level, so that we can add items and sub-items in a list.

These commands are accessible only via the sidebar (see attached screenshot).

The main problem is that the Tabbed UI has a very similar command named "Increse/Decrease indent", which has a very different result than Promote/Demote list level. This is confusing, because these commands in the Tabbed UI are to the right of the List toggle command, which gives the impression that these commands will promote/demote the list level, but instead they only change the indentation value.

I would like to suggest replacing the "Increse/Decrease indent" commands by the "Promote/Demote list level" commands in the Tabbed UI.

Also, this would make the Tabbed UI more similar to the Ribbon interface of MS PowerPoint, which provides Promote/Demote commands instead of simply changing the indentation value.
Comment 1 V Stuart Foote 2023-02-03 18:33:26 UTC
+1, for lists in a textbox we do a layout adjustment rather than an outline adjustment now.

So, would replace the Tabbed NB use of

.uno:DecrementIndent
.uno:IncrementIndent

to instead use

.uno:OutlineLeft
.uno:OutlineRight

to match usage in the SB Properties "Lists" panel.

But do we still need the layout adjustment (e.g. for graphical bullets)?
Comment 2 Heiko Tietze 2023-02-06 11:58:43 UTC
The notebookbars are in 

sw/uiconfig/swriter/ui/

notebookbar_single.ui
notebookbar_groupedbar_full.ui
notebookbar_groupedbar_compact.ui
notebookbar.ui (this one is the tabbed version) 
notebookbar_compact.ui

Adding/removing commands does not need Glade but can be done with any XML/text editor.
Comment 3 Rafael Lima 2023-02-10 01:38:09 UTC
Proposed patch here:

https://gerrit.libreoffice.org/c/core/+/146705

Note that I only changed Impress/Draw. I did not make any changes in Writer since all is working as expected there.

Apparently in Writer, when editing lists the commands "Increase Indent" and "Promote Outline Level" do the same thing. The item is actually promoted instead of simply changing the indentation value.
Comment 4 Commit Notification 2023-02-21 19:17:35 UTC
Rafael Lima committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/53bcb6c42fcb6f9ca6bf568a965c99d6c2b5ffb5

tdf#153352 Use Promote/Demote in Tabbed UI instead of Increase/Decrease indent

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.