Bug 153361 - Theme color set has unsuitable lighten for background colors
Summary: Theme color set has unsuitable lighten for background colors
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: LibreOffice (show other bugs)
Version:
(earliest affected)
7.4.0.3 release
Hardware: x86-64 (AMD64) All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:7.6.0
Keywords:
Depends on:
Blocks: Color-Palettes Document-Themes
  Show dependency treegraph
 
Reported: 2023-02-03 19:05 UTC by Regina Henschel
Modified: 2023-06-07 09:10 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Regina Henschel 2023-02-03 19:05:28 UTC
Open attachment 185094 [details] from bug 153359.

The slide shows a screenshot of the theme color set in PowerPoint. The left shape uses the first from left theme color, a text color; the right shape uses the third from left theme color, a background color.

Look at the light/darken values for the theme color of the right shape.
PowerPoint provides the light/darken values
darken 10%
darken 25%
darken 50%
darken 75%
darken 90%

LibreOffice provides the light/darken values
lighten 80%
lighten 60%
lighten 40%
darken 25%
darken 50%

Problems:
A) The theme color background colors in MS Office are light and therefore it makes no sense to lighten them even more.

B) If LibreOffice uses different value than MS Office, the chosen color is not contained in the set shown to the user.

[There is no problem with the colors themselves, because lighten and darken is not part of the theme but described by separate attributes. Besides ±1 off sometimes the colors are correct.]
Comment 1 Stéphane Guillou (stragu) 2023-02-17 22:28:47 UTC
Reproduced. Had to go to context menu > Area > Area tab > Color > Palette > Theme colors.

Version: 7.4.5.1 / LibreOffice Community
Build ID: 9c0871452b3918c1019dde9bfac75448afc4b57f
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

Support for document themes was introduced in LO 7.4: https://vmiklos.hu/blog/sd-theme-shape-fill.html

Miklos, what do you think?
Comment 2 Miklos Vajna 2023-02-20 07:37:04 UTC
CC Tomaz as he works on themes these days.

Anyhow, IIRC I saw the current LO behavior for some colors in powerpoint, probably I didn't notice that the set of 5 transforms depends on how light/dark the color is.

It certainly makes sense to have this more smart set of transforms on our side as well.

The current static defaults are defined here:

https://github.com/libreoffice/core/blob/49dd32a88d90097a1c50dc64dc42dc35645780b8/svx/source/tbxctrls/PaletteManager.cxx#L49-L55
Comment 3 Commit Notification 2023-06-01 16:26:23 UTC
Tomaž Vajngerl committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/e6215c7233c0fb437a81b51c8a8a30bb53eef65f

tdf#153361 improve theme color generation in color picker

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.