Bug 153517 - CALC - wrong time value when using the autofill function and minutes are entered (not for 00 min)
Summary: CALC - wrong time value when using the autofill function and minutes are ente...
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
7.4.3.2 release
Hardware: All All
: high normal
Assignee: Eike Rathke
URL:
Whiteboard: target:24.2.0 target:7.6.0.0.beta2 ta...
Keywords: bibisected, bisected, regression
: 155366 (view as bug list)
Depends on:
Blocks: AutoFill
  Show dependency treegraph
 
Reported: 2023-02-10 10:29 UTC by kabilo
Modified: 2023-07-12 17:04 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments
video (457.50 KB, video/avi)
2023-02-10 10:31 UTC, kabilo
Details
testfile (10.60 KB, application/vnd.oasis.opendocument.spreadsheet)
2023-02-10 10:34 UTC, kabilo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description kabilo 2023-02-10 10:29:42 UTC
Description:
wrong time value when using the autofill function if minutes are to be filled (video attached). Autofill also works differently if a different time display format is used.

Steps to Reproduce:
1. enter the values of the time (interval) you want to fill the time series in two cells
2.select both cells and apply the autofill function to the following cells
3.check values

Actual Results:
the completed time is 1 second less than expected

Expected Results:
 


Reproducible: Always


User Profile Reset: No

Additional Info:
Comment 1 kabilo 2023-02-10 10:31:16 UTC
Created attachment 185279 [details]
video
Comment 2 kabilo 2023-02-10 10:34:58 UTC
Created attachment 185280 [details]
testfile
Comment 3 Xisco Faulí 2023-02-10 10:45:58 UTC
Regression introduced by:

author	Eike Rathke <erack@redhat.com>	2022-10-11 12:33:22 +0200
committer	Eike Rathke <erack@redhat.com>	2022-10-11 14:13:58 +0200
commit abd42a63f65f810c821085149c095682247e0d0d (patch)
tree 985f7c18792ad2d951e9031b2e9ec2c8283ff441
parent e35decf9b854c29ca02b2a73dac10340ab687b44 (diff)
Resolves: tdf#151460 Scale and round time diff fiddling with floating point

Bisected with: bibisect-linux64-7.5

Adding Cc: to Eike Rathke
Comment 4 Xisco Faulí 2023-02-17 09:53:58 UTC
bumping importance a bit
Comment 5 Eike Rathke 2023-05-17 08:52:29 UTC
*** Bug 155366 has been marked as a duplicate of this bug. ***
Comment 6 Commit Notification 2023-06-17 13:16:58 UTC
Eike Rathke committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/eac63ab120a181a1dff6317ee3d223327080e992

Related: tdf#153517 Introduce class tools::Duration

It will be available in 24.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 7 Commit Notification 2023-06-17 14:11:08 UTC
Eike Rathke committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/30c48379c7b791edc615e7691691e344baa455a3

Resolves: tdf#153517 Use tools::Duration for FillSeries with (date+)time

It will be available in 24.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 9 Commit Notification 2023-06-17 16:05:19 UTC
Eike Rathke committed a patch related to this issue.
It has been pushed to "libreoffice-7-6":

https://git.libreoffice.org/core/commit/69f757a4bb32a844f7754f6fc6b9970557297528

Related: tdf#153517 Introduce class tools::Duration

It will be available in 7.6.0.0.beta2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 10 Commit Notification 2023-06-17 16:05:22 UTC
Eike Rathke committed a patch related to this issue.
It has been pushed to "libreoffice-7-6":

https://git.libreoffice.org/core/commit/0770c99928fa0c4af23b06cbf694ee77ee78b836

Resolves: tdf#153517 Use tools::Duration for FillSeries with (date+)time

It will be available in 7.6.0.0.beta2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 11 Eike Rathke 2023-06-17 18:36:51 UTC
Pending review for 7-5
https://gerrit.libreoffice.org/c/core/+/153209
Comment 12 Commit Notification 2023-07-06 19:13:55 UTC
Xisco Fauli committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/faadaa111d0c4025af5cffb8c8dbd084040f7217

tdf#153517: sc_ucalc: Add unittest

It will be available in 24.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 13 Commit Notification 2023-07-12 07:15:16 UTC
Eike Rathke committed a patch related to this issue.
It has been pushed to "libreoffice-7-5":

https://git.libreoffice.org/core/commit/3732522cb499fa13a7ec905be0628376b7c024e3

Resolves: tdf#153517 Use tools::Duration for FillSeries with (date+)time

It will be available in 7.5.6.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 14 Stéphane Guillou (stragu) 2023-07-12 08:33:56 UTC
Fix verified in:

Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 663db89378aa1f0425e795ef5d471f134e658dc4
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

Thanks kabilo and Eike!
Comment 15 Zio3D 2023-07-12 09:01:26 UTC
Fix verified in:

Version: 7.6.0.1.0+ (X86_64) / LibreOffice Community
Build ID: f59804171e2ecb92d9ea554812f847000c17bceb
CPU threads: 8; OS: Windows 10.0 Build 19045; UI render: Skia/Vulkan; VCL: win
Locale: it-IT (it_IT); UI: it-IT
Calc: CL threaded

Thanks kabilo and Eike!
Comment 16 Commit Notification 2023-07-12 17:04:36 UTC
Eike Rathke committed a patch related to this issue.
It has been pushed to "libreoffice-7-5-5":

https://git.libreoffice.org/core/commit/4cd26ad13f11b69cca01274a4ed90194618bc003

Resolves: tdf#153517 Use tools::Duration for FillSeries with (date+)time

It will be available in 7.5.5.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.