Bug 153572 - Basic IDE also needs .uno:ZoomPlus and .uno:ZoomMinus commands
Summary: Basic IDE also needs .uno:ZoomPlus and .uno:ZoomMinus commands
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: BASIC (show other bugs)
Version:
(earliest affected)
7.5.0.3 release
Hardware: All All
: medium normal
Assignee: Rafael Lima
URL:
Whiteboard: target:7.6.0
Keywords:
Depends on:
Blocks: Zoom
  Show dependency treegraph
 
Reported: 2023-02-12 20:14 UTC by Rafael Lima
Modified: 2023-02-22 13:38 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Rafael Lima 2023-02-12 20:14:43 UTC
Calc, Writer and Impress/Draw implement the .uno:ZoomPlus (SID_ZOOM_IN) and .uno:ZoomMinus (SID_ZOOM_OUT) commands, which can be associated with keyboard shortcuts such as Ctrl + for zooming in/out of a document.

After working on bug 45705 I noticed that this command is not implemented in the Basic IDE. It would be very useful to have these commands in the Basic IDE so we can zoom in and out of the code editor with a keyboard shortcut.
Comment 1 Rafael Lima 2023-02-12 20:34:40 UTC
This patch implements the commands in the Basic IDE

https://gerrit.libreoffice.org/c/core/+/146841
Comment 2 V Stuart Foote 2023-02-13 03:31:46 UTC
Thanks Rafael!
Comment 3 Heiko Tietze 2023-02-13 08:43:31 UTC
Writer has assigned ctrl+alt+pgup/pgdown to zoom in/out (which is not working here with 7.5.0.3, VCL: kf5, see bug 145298). Not a common shortcut, IMO.

Browsers zoom per ctrl + num+/-, which fails for TKL keyboards. And I doubt we can distinguish between num plus and plus.

VS Code has no shortcut assigned to zoom. And I think such an operation being needed only once (in contrast to visually more varying browsers or graphical oriented tools like bug 45705) should not occupy a precious shortcut.

But since we aim for consistency across modules we should implement what is going to be done on bug 45705.
Comment 4 V Stuart Foote 2023-02-13 12:36:05 UTC
(In reply to Heiko Tietze from comment #3)
> Writer has assigned ctrl+alt+pgup/pgdown to zoom in/out (which is not
> working here with 7.5.0.3, VCL: kf5, see bug 145298). Not a common shortcut,
> IMO.
> 

Really? I'm not seeing any shortcut assignment to .uno:ZoomPlus/.uno:ZoomMinus--that was where Jim had left it. Certainly nothing from the <Ctrl><Alt> segment for the TDF Windows builds. Build specific?

> Browsers zoom per ctrl + num+/-, which fails for TKL keyboards. And I doubt
> we can distinguish between num plus and plus.
> 
> VS Code has no shortcut assigned to zoom. And I think such an operation
> being needed only once (in contrast to visually more varying browsers or
> graphical oriented tools like bug 45705) should not occupy a precious
> shortcut.
> 

For Base we have fixed zoom steps available to assign as keyboard shortcuts: 50%, 75%, 100%, 150% and 200% (for Design View Form and Table design), right?  But no Zoom bar (not really needed) and not on menu. But adding the zoomtools based stepped resize would make the BASE UI a bit more comfortable. Think working on HiDPI with larger Form and Table.

> But since we aim for consistency across modules we should implement what is
> going to be done on bug 45705.

If it integrates well, we should.
Comment 5 Heiko Tietze 2023-02-13 12:58:17 UTC
(In reply to V Stuart Foote from comment #4)
> (In reply to Heiko Tietze from comment #3)
> > Writer has assigned ctrl+alt+pgup/pgdown to zoom in/out...
> I'm not seeing any shortcut assignment to .uno:ZoomPlus
True, was an oddment from previous testing.
Comment 6 Commit Notification 2023-02-22 13:36:53 UTC
Rafael Lima committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/943b8b45d80e295b1333fdc28bc8cf7ca8f95902

tdf#153572 Implement .uno:ZoomPlus and .uno:ZoomMinus in the Basic IDE

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.