Bug 153578 - duplicate menu hotkey
Summary: duplicate menu hotkey
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
7.5.0.3 release
Hardware: All Linux (All)
: medium normal
Assignee: Heiko Tietze
URL:
Whiteboard: target:7.6.0
Keywords:
Depends on:
Blocks:
 
Reported: 2023-02-13 05:10 UTC by lvm
Modified: 2023-02-25 05:44 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:


Attachments
screenshot (28.78 KB, image/png)
2023-02-13 05:10 UTC, lvm
Details

Note You need to log in before you can comment on or make changes to this bug.
Description lvm 2023-02-13 05:10:11 UTC
Description:
In Data menu "XML source" and "Text to columns" both have X as the hotkey, first one (XML source) wins and "Text to columns" - a rather frequently used option, is inaccessible.

Steps to Reproduce:
1. open data menu


Actual Results:
all items should've had unique hotkeys

Expected Results:
"XML source" and "Text to columns" has the same hotkey - x


Reproducible: Always


User Profile Reset: No

Additional Info:
Version: 7.5.0.3 (X86_64) / LibreOffice Community
Build ID: c21113d003cd3efa8c53188764377a8272d9d6de
CPU threads: 4; OS: Linux 5.4; UI render: default; VCL: kf5 (cairo+xcb)
Locale: en-GB (en_GB.UTF-8); UI: en-GB
Calc: threaded

English UK language pack is installed.
Comment 1 lvm 2023-02-13 05:10:42 UTC
Created attachment 185340 [details]
screenshot
Comment 2 ady 2023-02-13 10:15:20 UTC
If the cell in focus has no relevant data for the "Text to Columns" feature, then only the "XML source" will be available, while "Text to Columns" will be grayed out. In this case, Pressing ALT,D,X will trigger the "XML source".

If you have a (range of) cell(s) that can be used as source for the "Text to Columns" feature, then both possibilities are available. In this case, pressing ALT,D,X will not trigger the "XML source" immediately, but rather will only focus on the row within the Data menu. At this point, pressing X again will focus on the "Text to Columns" row, and you are able to press ENTER.

Please post in the report, whether this is the kind of answer you were looking for. If it isn't, please clarify your issue/request.
Comment 3 lvm 2023-02-13 10:34:31 UTC
No, for me this is not acceptable. As I said in the original issue, all items in a menu should have *unique* hotkeys. I expect hotkey always trigger menu item immediately, not maybe immediately but maybe after two, or even more additional keys. It negates the whole idea of hotkeys - speed.

> If the cell in focus has no relevant data for the "Text to Columns" feature,
> then only the "XML source" will be available, while "Text to Columns" will
> be grayed out. In this case, Pressing ALT,D,X will trigger the "XML source".
> 
Actually, no. Even if text to columns is greyed out, X doesn't trigger "XML source". First press positions selection bar on "XML source" without triggering it, second press makes selection bar disappear completely. Confusing, if you ask me, but that's beside the point.
Comment 4 ady 2023-02-13 11:38:07 UTC
(In reply to lvm from comment #3)
> No, for me this is not acceptable. As I said in the original issue, all
> items in a menu should have *unique* hotkeys. I expect hotkey always trigger
> menu item immediately, not maybe immediately but maybe after two, or even
> more additional keys. It negates the whole idea of hotkeys - speed.

For me, as of LO 7.4.5, it is ALT,D,X,X,ENTER. Perhaps you want to request changing the assigned key to one of these menus, independently of whichever other problem might be here (please read below).


> 
> > If the cell in focus has no relevant data for the "Text to Columns" feature,
> > then only the "XML source" will be available, while "Text to Columns" will
> > be grayed out. In this case, Pressing ALT,D,X will trigger the "XML source".
> > 
> Actually, no. Even if text to columns is greyed out, X doesn't trigger "XML
> source". First press positions selection bar on "XML source" without
> triggering it, second press makes selection bar disappear completely.
> Confusing, if you ask me, but that's beside the point.

Here we have a different experience:
1. Open Calc (new, empty document, so "Text to Column" is not available ATM)
2. ALT, D, X
3. See the XML source dialog immediately displayed/opened/triggered.

But, the above steps work on Windows. Since you are on Linux, maybe here is part of the problem/different behavior? This is not your original interest in this bug report, but maybe solving this quirk would help you speed up your procedure, independently of changing the keyboard shortcut for one of these menu entries.
Comment 5 Heiko Tietze 2023-02-23 09:28:08 UTC
Hotkeys are automatically assigned, if not hard-coded. Removed this and now you will see X and U underlined.
Comment 6 Commit Notification 2023-02-25 05:44:27 UTC
Heiko Tietze committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/895527e3a5af6b57ff8d4ef2a0198d9dd6707746

Resolves tdf#153578 - Duplicate mnemonics

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.