Bug 153580 - Calc Sort dialog too small, UI not resizable
Summary: Calc Sort dialog too small, UI not resizable
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
7.5.0.3 release
Hardware: x86-64 (AMD64) Windows (All)
: medium normal
Assignee: Heiko Tietze
URL:
Whiteboard: target:7.6.0
Keywords:
Depends on:
Blocks: Sorting
  Show dependency treegraph
 
Reported: 2023-02-13 06:21 UTC by Loren Amelang
Modified: 2023-04-06 16:25 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments
Calc Sort dialog too short, scrolls to bottom on every open (51.71 KB, image/png)
2023-02-13 06:23 UTC, Loren Amelang
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Loren Amelang 2023-02-13 06:21:15 UTC
Description:
Just spent a day doing various sorts on a calc sheet. The dialog only has room for 2 1/2 sort Keys without scrolling. And it ignores the mouse scroll wheel and PgUp/Dn. And every time you open it it scrolls to the bottom to show the next "undefined" key. So you have to mouse over to the scroll thumb and drag the Keys you need back into view. 

Could it _please_ be resizable? Or at least respond to a flip of the mouse scroll wheel? 

(There's a chance it is interacting with my Windows screen scaling, which sometimes shrinks window bounds, but the width matches the content perfectly. Just needs more height!) 

Steps to Reproduce:
1.open calc
2.open a sort dialog
3.

Actual Results:
Dialog too short, hard to scroll...

Expected Results:
Resizable dialog


Reproducible: Always


User Profile Reset: No

Additional Info:
Version: 7.5.0.3 (X86_64) / LibreOffice Community
Build ID: c21113d003cd3efa8c53188764377a8272d9d6de
CPU threads: 4; OS: Windows 10.0 Build 19044; UI render: default; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: threaded
Comment 1 Loren Amelang 2023-02-13 06:23:13 UTC
Created attachment 185341 [details]
Calc Sort dialog too short, scrolls to bottom on every open
Comment 2 Heiko Tietze 2023-02-23 09:50:41 UTC
We do not allow resizing by design unless the dialog contains free text fields.

The sort dialog is indeed a bit too large. I rearranged the controls so the size is now determined by the longest string.
Comment 3 ady 2023-02-23 12:45:03 UTC
(In reply to Heiko Tietze from comment #2)
> The sort dialog is indeed a bit too large. I rearranged the controls so the
> size is now determined by the longest string.

Maybe I am misunderstanding, but...

I think that the request is to allow the PgUp/Dn keys and/or the mouse's wheel to interact with the dialog, in order to scroll through the sorting keys, since it always opens at the last one. I might add that, in addition to allow PgUp/Dn, other keys might be helpful too, such as Home/End perhaps?

Of course, someone else might request that the keyboard should have a different interaction. I am only mentioning this because of OP's request.
Comment 4 Loren Amelang 2023-02-23 20:49:38 UTC
@ady -  Yes! I agree with Heiko there is excess width in my screenshot, but that just requires moving my eyes a bit. The real issue is the the height of the dialog! What determines that? 

Could the scrolling section be tall enough to show four or five keys? 

And in any case, somebody will need to see more...  Being able to use all the keyboard movement keys and mouse scroll to move up and down the list would be so much easier! 

Maybe that works on other platforms? I only do this kind of detail work on Windows.
Comment 5 Heiko Tietze 2023-02-24 07:24:34 UTC
(In reply to Loren Amelang from comment #4)
> The real issue is the the height of the dialog! What determines that? 
The controls on this tab require this height; if the options tab would have more content resp. be taller, it adds to the total size of the dialog.

> Could the scrolling section be tall enough to show four or five keys? 
Meaning to make the dialog even larger? Maybe we should allow resizing on this dialog.
Comment 6 ady 2023-02-24 10:01:02 UTC
(In reply to Heiko Tietze from comment #5)
> > Could the scrolling section be tall enough to show four or five keys? 
> Meaning to make the dialog even larger? Maybe we should allow resizing on
> this dialog.

Please forgive my ignorance. One thing is to be able to "navigate" with ease (mouse scrolling available, PgDn/PgUp and/or other keys available) within the dialog and between the sorting levels / conditions, and the other is the size of the dialog window. Perhaps these two items are somehow related, but from the POV of the common user, I would think they are not the same.
Comment 7 Loren Amelang 2023-02-25 00:13:56 UTC
(In reply to Heiko Tietze from comment #5)
> (In reply to Loren Amelang from comment #4)
> > The real issue is the the height of the dialog! What determines that? 
> The controls on this tab require this height; if the options tab would have
> more content resp. be taller, it adds to the total size of the dialog.

So you are saying that in order to make more space in the Criteria tab, the Options tab would have to have unnecessary empty space? I'd be happy with that, but I suppose people who only do single criteria sorts might not be. 

> > Could the scrolling section be tall enough to show four or five keys? 
> Meaning to make the dialog even larger? Maybe we should allow resizing on
> this dialog.

I'd love that - if it was remembered between sorts, even just during multiple edits on a single file, but hopefully across app restarts. 

If I have to mouse drag the dialog bigger every time I want to change my sort criteria, that's definitely not worth doing. In that case please focus on being able to scroll the current criteria list via keyboard and mouse!
Comment 8 Commit Notification 2023-02-27 11:39:00 UTC
Heiko Tietze committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/084fae866b108938e58e1d2d279ac17263c8794b

Resolves tdf#153580 - Calc's sort dialog too large

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 9 Heiko Tietze 2023-02-27 11:41:57 UTC
(In reply to Loren Amelang from comment #7)
> > Maybe we should allow resizing on this dialog.
> 
> I'd love that - if it was remembered between sorts, even just during
> multiple edits on a single file, but hopefully across app restarts. 

Let's continue with this on bug 153852.