Bug 153653 - Remove (or change functionality and label) of "Default" button in Styles tab of Insert Index dialog (see c1,c6,c7)
Summary: Remove (or change functionality and label) of "Default" button in Styles tab ...
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Documentation (show other bugs)
Version:
(earliest affected)
3.3.0 release
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:7.6.0
Keywords:
Depends on:
Blocks: Help-Changes-Features TableofContents-Indexes-Dialog
  Show dependency treegraph
 
Reported: 2023-02-16 00:05 UTC by sdc.blanco
Modified: 2023-06-08 07:15 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description sdc.blanco 2023-02-16 00:05:58 UTC
Help page for Styles:

https://help.libreoffice.org/7.6/en-US/text/swriter/01/04120201.html

1. The "icon" for the Assign button is not correct.

2. Formatting and grammatical problems should be corrected.

3. Some entries can be improved.

 

Missing tooltip in Styles dialog.

1. Insert - Table of Contents and Index - Table of Contents, Index, or Bibliography

2. Select "Styles" tab.

3. Hover mouse over "<" icon in middle of dialog.

Actual:  Nothing
Expected (or better):  "Assign" should appear as "tooltip"

The extended tip needs correction.
Comment 1 sdc.blanco 2023-02-16 00:18:06 UTC
Will ask UXEval as part of this ticket for now.

In the Styles tab (of TOC dialog), there is a "Default" button.
Select a level, press "Default"

Actual:   The assigned style is deleted.
Expected: Style is "reset" to default (factory) setting.

Documentation explains that default paragraph style is used.  (have not tested).


Questions to UXEval.

1.  Wouldn't it be better if Default actually reset to factory setting?

2.  Alternatively, if the functionality is not changed, then:

    a.  wouldn't it be better if "Default Paragraph Style" was displayed in the Levels window, rather than <null>, and

    b. maybe a better label should be found for the button (e.g., Delete)
Comment 2 sdc.blanco 2023-02-16 00:39:08 UTC
Proposal for help page update:
https://gerrit.libreoffice.org/c/help/+/147115

Proposal for tooltip addition (and some extended tip improvement):
https://gerrit.libreoffice.org/c/core/+/147116
Comment 3 Heiko Tietze 2023-02-16 10:30:30 UTC
Default reverts any association between the selected Level and the paragraph style. The default is "Content X" (although it's not added to the level like "Level 1 [Contents 1]"). 

We use Reset on the whole dialog. "Factory Setting" is correct but I see no advantage over "Default", which is short and easy to read. The tooltip "Reverts the associated paragraph style to the default setting" is fine.

(In reply to sdc.blanco from comment #1)
> 2.  Alternatively, if the functionality is not changed, then...

Typically for these dual-list pattern are buttons between the lists. We have the "move right" aka make association button and could turn "Default" into an icon-only trash bin button next to it. Doubt it contributes to clarification; and below the PS list we have an Edit button anyway.
Comment 4 sdc.blanco 2023-02-16 11:56:31 UTC
(In reply to Heiko Tietze from comment #3)

Main motivation for OP is to make it easier (in help and tooltip) to explain the operation of the "button".

Not expecting a "self-contained" solution (i.e., completely transparent /  understandable w/o explanation), but still believe that improvements can be made to facilitate comprehension.

> Default reverts any association between the selected Level and the paragraph
> style. The default is "Content X" (although it's not added to the level like
> "Level 1 [Contents 1]"). 
For TOC, it is Contents.  For other indices, other PS are used (e.g., for User-defined:  "User Index N" ; for Alphabetical:  "Index N" ; ...)

> We use Reset on the whole dialog. "Factory Setting" is correct but I see no
> advantage over "Default", which is short and easy to read. The tooltip
> "Reverts the associated paragraph style to the default setting" is fine.
But if "default" ( = factory setting) as you say, then "default" gives an affordance (for TOC) for "Content X", not "default PS".  From that perspective, the tooltip is misleading, because the current action of the button does not revert to "default setting" -- but to "default paragraph style"!

Another (acceptable for me) solution is to remove the "Default" button.

Reasons:

1.  Default Paragraph Style is always shown as an option for assignment for all indices -- so if a user wanted this PS, it could be assigned, with the advantage that this assignment is shown explicitly in the UI, not simply blank.

2. No additional functionality or advantage is achieved (at present) with the "Default" button. (plus it creates an ambiguity when the left column is blank).

3. Simplifies the UI.

Still think the best (most user-friendly) would be for Default to reset to "factory setting", otherwise "no button" seems better than current implementation (no matter what the button is called or how it appears).

"User-friendly": because it is a one-step operation to reset a customised PS on the left side --  versus the current situation where it is necessary to first find and select the right PS on the right side (e.g., among 10 "Contents N" and make sure it matches the correct level on the left), and then a second action of clicking the "<" assign button.


And while we are looking at this dialog --  maybe the "Assign" button should be moved down to the middle between the Levels and PS columns?  No consequences for documentation, so I could file another ticket if this seems appropriate.
Comment 5 Commit Notification 2023-02-16 23:53:37 UTC
Seth Chaiklin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/620bad283446c635febcdf0b4b1c60f17c2abdf8

tdf#153653 add tooltip and correct extended tip for Assign icon

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 6 Heiko Tietze 2023-02-22 10:34:22 UTC
a) Default -> Factory Setting: sounds overstated since you just reset one option
b) Default -> Reset: clashes with Reset for the whole dialog
c) Default -> Clear: okay
d) remove Default: alienates the Edit button, which could be removed too
e) move Default into an icon-only button between the lists, eg. with a trash-bin symbol: same drawback as removing it
f) move Default and Edit into context menus: acceptable for me

No strong preference for any option; the Default aka Clear function is a bit ridiculous anyway.
Comment 7 sdc.blanco 2023-02-22 11:11:23 UTC
(In reply to Heiko Tietze from comment #6)
> a) Default -> Factory Setting: sounds overstated since you just reset one
> option
Does not reset to Factory Setting at present.  That would be the best action, and then "Default" would be meaningful.

> b) Default -> Reset: clashes with Reset for the whole dialog
Agree.

> c) Default -> Clear: okay
Better than "Default" -- if the button remains.

> d) remove Default: alienates the Edit button, which could be removed too
??? Don't follow that logic. There are other dialogs with "single" buttons.
Would not remove "Edit" button. It is quite useful -- especially for changing indent.

> f) move Default and Edit into context menus: acceptable for me
Hmmm....or "add" this for power users -- given that it is necessary to select an item before clicking the Edit/Default button. 
 
> No strong preference for any option; the Default aka Clear function is a bit
> ridiculous anyway.
iiuc, you agree that current function is not so meaningful.

In sum:

1. Ideal:  "Default" button and label remains, but its function is changed to be a genuine reset to factory default (and not the current removal of PS).

2. Quick-and-dirty:  "Default" -> "Clear"

3. Why not?:  remove "Default" button completely (do not see/understand the "alienate"). No real loss.

4. Useful enhancement: add context menu to (at least) PS window with "Edit" command.
Comment 8 sdc.blanco 2023-02-28 23:15:35 UTC
Update to help page for Styles tab -- 
https://gerrit.libreoffice.org/c/help/+/147115
-- but waiting for "conclusion" for the "Default" button in relation to points 1-3 in comment 7.  Should I use "NeedsUXEval" again?
Comment 9 sdc.blanco 2023-02-28 23:54:22 UTC
(In reply to sdc.blanco from comment #4)
> maybe the "Assign" button should be moved down to the middle between 
> the Levels and PS columns?  
https://gerrit.libreoffice.org/c/core/+/147981

Should I file a separate ticket for that?
Comment 10 Heiko Tietze 2023-03-01 07:59:31 UTC
(In reply to sdc.blanco from comment #8)
> Should I use "NeedsUXEval" again?

I can put it on the agenda in two weeks (another drawback from the test to announce a week in advance). So let's ask Cor for his opinion about comment 6 ff.
Comment 11 Commit Notification 2023-03-06 09:05:09 UTC
Seth Chaiklin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/help/commit/c76109de27348a1b751ac398b978ebfa3a8825dc

tdf#153653 general update of Styles  correct icon for Assign command
Comment 12 Heiko Tietze 2023-05-04 10:08:38 UTC
(In reply to Heiko Tietze from comment #10)
> Let's ask Cor for his opinion about comment 6 ff.

Cor?
Comment 13 Commit Notification 2023-05-05 11:08:22 UTC
Seth Chaiklin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/abe1b3ff2e0f2fc0e9ccf8ac3f22fa34babc7155

tdf#153653  vertical centering of "Assign" button

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 14 sdc.blanco 2023-05-24 14:21:55 UTC
OP is resolved, but have changed bug summary to highlight the new/remaining issue for the Styles tab.
Comment 15 Heiko Tietze 2023-06-08 07:15:52 UTC
We discussed the topic in the design meeting.

Moving the commands into a context menu makes most sense (option f) in c6). And additionally we may provide a reset functionality per icon-only button in the middle to help users to figure out the opportunity.