Bug 153782 - Line width name "Double hairline" is duplicated for two different format commands
Summary: Line width name "Double hairline" is duplicated for two different format comm...
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
7.5.0.3 release
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: Cell-Border
  Show dependency treegraph
 
Reported: 2023-02-22 13:57 UTC by Rafael Lima
Modified: 2025-02-23 03:11 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments
Screenshot showing the problem (83.39 KB, image/png)
2023-02-22 13:57 UTC, Rafael Lima
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Rafael Lima 2023-02-22 13:57:39 UTC
Created attachment 185529 [details]
Screenshot showing the problem

In the Properties sidebar "Cell Appearance" section, the line width selector has 2 repeated entries "Double Hairline". However, since they have a totally different effect, I believe they should have different names.

Based on the code, I suggest they are called:
- Double Thin Line
- Double Thick Line

Notice in the code that none of them are actually drawn as hairlines after SvxBorderLineWidth::Medium / Thick is set.

https://opengrok.libreoffice.org/xref/core/sc/source/ui/sidebar/CellLineStyleControl.cxx?r=cd116a1b#130

See attached image for more information. Notice the difference between the actual hairline with the output of the two commands previously mentioned.
Comment 1 Julien Nabet 2023-02-22 15:16:17 UTC
It makes sense to me but let's ask UI experts.
Comment 2 Heiko Tietze 2023-02-22 16:17:29 UTC
CellLineStylePopup::Initialize() uses STR_BORDER_DOUBLE_1 twice [1]. Any reason, Samuel?

You added this for bug 48622 with https://gerrit.libreoffice.org/c/core/+/124680

[1] https://opengrok.libreoffice.org/xref/core/sc/source/ui/sidebar/CellLineStyleControl.cxx?r=cd116a1b#70
Comment 3 Samuel Mehrbrodt (allotropia) 2023-02-23 07:30:47 UTC
(In reply to Heiko Tietze from comment #2)
> CellLineStylePopup::Initialize() uses STR_BORDER_DOUBLE_1 twice [1]. Any
> reason, Samuel?
> 
> You added this for bug 48622 with
> https://gerrit.libreoffice.org/c/core/+/124680
> 
> [1]
> https://opengrok.libreoffice.org/xref/core/sc/source/ui/sidebar/
> CellLineStyleControl.cxx?r=cd116a1b#70

I think this was a mistake. Probably one of them can go.
Maybe check which makes more sense (also in terms of interoperability) and remove the other one.
Comment 4 Heiko Tietze 2023-02-23 07:37:35 UTC
Rafael, up to you. Either remove the tick one (my take) or keep both and rename as suggested.
Comment 5 QA Administrators 2025-02-23 03:11:18 UTC
Dear Rafael Lima,

To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information from Help - About LibreOffice.
 
If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug