Bug 153847 - Change label for .uno:InsertIndexesEntry and label and tooltip for .uno:IndexEntryDialog
Summary: Change label for .uno:InsertIndexesEntry and label and tooltip for .uno:Index...
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
7.6.0.0 alpha0+
Hardware: All All
: medium normal
Assignee: sdc.blanco
URL:
Whiteboard: target:7.6.0
Keywords:
Depends on:
Blocks: UNO-Command-Label
  Show dependency treegraph
 
Reported: 2023-02-26 23:17 UTC by sdc.blanco
Modified: 2024-08-27 13:38 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description sdc.blanco 2023-02-26 23:17:34 UTC
Tools > Customize > Menus tab
Search: Index Entry

Actual: two "Index Entry" are shown. 

Suggestion/proposal:

1. For .uno:InsertIndexesEntry

Label: Insert Entry Dialog

2. For .uno:IndexEntryDialog

Label:  Edit Index Entry
Tooltip: Edit Index Entry
Comment 1 sdc.blanco 2023-02-26 23:34:08 UTC
Probably .uno:InsertIndexesEntry also needs:

ContextLabel: Insert Entry
Comment 2 Rafael Lima 2023-02-27 12:42:19 UTC
I agree with the idea of having unique labels / tooltips for each Uno command. It makes it much easier to the user when choosing commands in the Customize dialog.

However, there's a large number of different commands that have the same label (see bug 138725). But not all of them have tooltips.

The main problem here is that command labels are also used in the UI, so sometimes it might be necessary to have different commands with the same label, but with different tooltips to better explain what they actually do.

Basically, what I mean is that we should focus on providing tooltips for all commands, specially for those whose labels are identical.
Comment 3 Heiko Tietze 2023-03-28 12:02:42 UTC
(In reply to sdc.blanco from comment #0)
> Label: Insert Entry Dialog
> Label:  Edit Index Entry
You insert a dialog and edit an entry... I'd just use the dialog title and go with "Edit/Insert Index Entry".

(In reply to Rafael Lima from comment #2)
> we should focus on providing tooltips for all commands, specially for those whose labels are identical.
+1
Comment 4 sdc.blanco 2023-04-03 11:26:04 UTC
https://gerrit.libreoffice.org/c/core/+/149881
Comment 5 Commit Notification 2023-04-04 19:43:32 UTC
Seth Chaiklin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/1ca2edf4efaea9824613aaf02e854da6a2241f07

tdf#153847  update labels to disambiguate insert/edit index entry

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 6 Commit Notification 2023-04-05 14:04:09 UTC
Seth Chaiklin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/0a703b615b8fec592304d9060aab9c77d0ced02c

tdf#153847 add tooltip for Insert Index Entry

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 7 Commit Notification 2023-04-07 09:10:43 UTC
Seth Chaiklin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/help/commit/42455110e4a9b0777a8a42a676d75aa6f74a12ce

tdf#153847  "Index Entry" is now "Edit Index Entry" in context menu
Comment 8 sdc.blanco 2023-04-07 09:13:13 UTC
Ok Rafael, on your list of duplicate .uno labels you can now mark "Index Entry" as FIXED by bug 153847. Everything looks like it should, including menus, context menus and toolbars, and no duplicate in the Customize dialog.  As a bonus, "Index Entry" is now shown as "Edit Index Entry" in the context menu, and the relevant changes are updated in the help pages.