Bug 153867 - UI checkboxes are invisible with custom dark windows theme enabled.
Summary: UI checkboxes are invisible with custom dark windows theme enabled.
Status: RESOLVED NOTOURBUG
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
7.5.0.3 release
Hardware: x86-64 (AMD64) Windows (All)
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: Windows-Dark-Mode
  Show dependency treegraph
 
Reported: 2023-02-27 17:52 UTC by checkbox
Modified: 2023-03-16 20:55 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments
LibreOffice 7.4 with custom dark theme enabled (checkboxes are visible) (67.57 KB, image/png)
2023-03-16 20:30 UTC, checkbox
Details
LibreOffice 7.4 with experimental features and custom dark theme enabled (67.04 KB, image/png)
2023-03-16 20:31 UTC, checkbox
Details
LibreOffice 7.5 with custom dark theme enabled (67.72 KB, image/png)
2023-03-16 20:31 UTC, checkbox
Details
LO 7512 light mode on Win10 in os/DE dark color theme (76.25 KB, image/png)
2023-03-16 20:44 UTC, V Stuart Foote
Details
LO 7512 system mode on Win10 os/DE dark color theme (71.15 KB, image/png)
2023-03-16 20:47 UTC, V Stuart Foote
Details

Note You need to log in before you can comment on or make changes to this bug.
Description checkbox 2023-02-27 17:52:19 UTC
Problem description:
UI checkboxes are invisible when custom dark windows theme enabled.

Steps to reproduce:
1. Install custom dark windows theme.
2. Check Options

Current behavior: UI checkboxes are invisible

Expected behavior: UI checkboxes must be visible

Screenshots: https://imgur.com/a/gFnNmSM

Note:
I used Penumbra theme ( https://www.deviantart.com/scope10/art/Penumbra-10-Windows-10-visual-style-568740374 )
Which is unofficial custom dark theme and must be installed with third party tool called  SecureUxTheme ( https://github.com/namazso/SecureUxTheme )
I understand that this is a rare case and an unofficial hack, but it would be nice if it worked even in this case. In addition, in 7.4 without experimental features, checkboxes are visible, but with experimental features enabled, checkboxes are invisible.
Comment 1 V Stuart Foote 2023-02-27 18:55:51 UTC
The Penumbra Windows theme overwrites MS defaults.

Use the UltraUXThemePatcher to remove the "Penumbra 10" os/DE theme, reverting to MS color theme style(s) and retest.

Otherwise, pretty clearly => NOB
Comment 2 checkbox 2023-02-27 20:20:38 UTC
(In reply to V Stuart Foote from comment #1)
> The Penumbra Windows theme overwrites MS defaults.
> 
> Use the UltraUXThemePatcher to remove the "Penumbra 10" os/DE theme,
> reverting to MS color theme style(s) and retest.
> 
> Otherwise, pretty clearly => NOB

So you're saying that LibreOffice should only work correctly with the MS defaults, otherwise => NOB? Sounds weird.

As I said, I understand that this custom theme is a dirty hack, and the correctness of everything in any combinations cannot be guaranteed, but still in LibreOffice 7.4 this issue didn't exist. So it would be really nice to avoid it in the new version as well.
Comment 3 V Stuart Foote 2023-02-27 20:50:21 UTC
We are obliged to handle color theme defaults from the os/DE, and we do that with a fg/bg toggle. Your "hacked" Penumbra 10 color theme is over writing MS default color theme values with custom values such that our automated detection of os/DE Light color or Dark color themes misapply color within the checkbox.

Not saying it is correct, just saying we are not obliged to fix it.  Same holds for the HighContrast modes (Win10 or the new slate for Win11) we parse the WDM delivered HC color theme to some reasonable values for LibreOffice UI use.  Where for example the "GreyEve" theme, also available from deviantart.com, will lock in LibreOffice UI HC handling.

At 7.5 we've implemented enhanced support for detection of os/DE color theme and will toggle broadly to Light or to Dark depending on detection for "System", or for an LO "Light" or "Dark" manual toggle of the color theme.

You can try to Tools -> Options -> View  "Appearance" and set the "System|Light|Dark' mode to see if it behaves. 

Probably not, but then it is not our problem--we now respond to the os/DE color personalization from "Choose your color" deriving fg/bg color from the "default app mode" "Light|Dark" selection. But beyond fg/bg we don't handle UWP XAML for App color theming. So working with os/DE defaults for Light or Dark is about as far as we can go for Windows builds absent *major refactoring* to support UWP XAML

@Caolán, am I correct with that assessment?
Comment 4 checkbox 2023-02-27 22:19:10 UTC
Are you sure LibreOffice 7.5 with this "enhanced support for detection of os/DE color" handling all os/DE colors correctly and applies the right fg/bg values for the checkboxes?
In LibreOffice 7.5, checkboxes are the only UI element that has this issue with Penumbra theme. All other UI elements look correct with this theme.
LibreOffice 7.4 handled the default os/DE colors too, and the checkboxes looked correct with Penumbra theme there (light checkmark, on a dark background, as you can see in my screenshots)
I do not see such issue with Penumbra theme in other software that respond to the os/DE colors.
Comment 5 Stéphane Guillou (stragu) 2023-03-13 22:57:14 UTC
Checkbox, please attach the screenshot to this bug report instead of linking to them. Thank you!
Comment 6 checkbox 2023-03-16 20:30:51 UTC
Created attachment 186013 [details]
LibreOffice 7.4 with custom dark theme enabled (checkboxes are visible)
Comment 7 checkbox 2023-03-16 20:31:20 UTC
Created attachment 186014 [details]
LibreOffice 7.4 with experimental features and custom dark theme enabled
Comment 8 checkbox 2023-03-16 20:31:49 UTC
Created attachment 186015 [details]
LibreOffice 7.5 with custom dark theme enabled
Comment 9 V Stuart Foote 2023-03-16 20:44:10 UTC
Created attachment 186016 [details]
LO 7512 light mode on Win10 in os/DE dark color theme
Comment 10 V Stuart Foote 2023-03-16 20:47:03 UTC
Created attachment 186017 [details]
LO 7512 system mode on Win10 os/DE dark color theme

Pretty clearly an issue with the hacked Windows theme in use.

LO handling of Light and System/Dark with os/DE defaults for App color theme.

=> NOB
Comment 11 V Stuart Foote 2023-03-16 20:55:35 UTC
We can't (nor shouldn't) do anything with residual off brand win32 UI theme hacks. Better to spend effort to implement full UWP support. Meanwhile LO System/Light/Dark Appearance is functional for an effective Dark mode delivery for default MS dark/light App color theming.