Bug 153925 - Add Decorative property to graphic styles
Summary: Add Decorative property to graphic styles
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
Inherited From OOo
Hardware: All All
: medium enhancement
Assignee: Michael Stahl (allotropia)
URL:
Whiteboard: target:7.6.0 target:7.5.2
Keywords:
Depends on:
Blocks:
 
Reported: 2023-03-02 15:14 UTC by Gabor Kelemen (allotropia)
Modified: 2023-04-13 00:10 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:


Attachments
Graphics styles dialog is missing the Decorative flag (122.94 KB, image/png)
2023-03-02 15:14 UTC, Gabor Kelemen (allotropia)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Gabor Kelemen (allotropia) 2023-03-02 15:14:22 UTC
Created attachment 185701 [details]
Graphics styles dialog is missing the Decorative flag

This is a followup to bug 143311

The frame property Decorative was added there for single frame objects.

This is a feature request to add this property to frame styles.

1. Open attachment 173503 [details]
2. Right click the butterfly image, open Properties
3. On the Options tab there is the Decorative checkbox.
4. Go to the sidebar, Styles - Frame styles
5. Right click in the list, select New...
6. On the Options tab, the Decorative box is still missing.

This is not something Word supports, so this feature is needed to be added to odt files only.

Docx export can be handled by individually setting the flag om frames having the style  with enabled Decorative flag.

Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 2da16ff9f018fae68c53a801e5a234dafc2ebcec
CPU threads: 8; OS: Linux 5.4; UI render: default; VCL: gtk3
Locale: hu-HU (hu_HU.UTF-8); UI: en-US
Calc: default
Comment 1 Gabor Kelemen (allotropia) 2023-03-02 15:14:38 UTC
Self-confirming enhancement req.
Comment 2 Commit Notification 2023-03-03 12:42:50 UTC
Michael Stahl committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/2721520ca37654056c3d509657c50ee42e3dcae4

tdf#153925 xmloff,sw: decorative flag on frame styles

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 3 Commit Notification 2023-03-04 20:50:56 UTC
Michael Stahl committed a patch related to this issue.
It has been pushed to "libreoffice-7-5":

https://git.libreoffice.org/core/commit/198b138bc14bff7d334ecf5b1d1d5b5c8bba82fa

tdf#153925 xmloff,sw: decorative flag on frame styles

It will be available in 7.5.2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 4 Michael Stahl (allotropia) 2023-03-06 11:41:34 UTC
fixed - UI change requires no new translations so backported to 7.5 too
Comment 5 Michael Stahl (allotropia) 2023-03-06 17:23:59 UTC
see also https://issues.oasis-open.org/browse/OFFICE-4142
Comment 6 Gabor Kelemen (allotropia) 2023-04-13 00:10:32 UTC
Verified in 

Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: fc6806c4be8585ce0d35a6b581bf8b3dbf858500
CPU threads: 14; OS: Windows 10.0 Build 19045; UI render: default; VCL: win
Locale: hu-HU (hu_HU); UI: hu-HU
Calc: threaded

Now the attribute is visible in the frame style dialog.