Description: A UI string in LO contains the following sentence: "Rename dialog to keep current dialog or replace existing dialog." It's part of a dialog where the options are "Rename" and "Replace", but the meaning is still quite unclear: which dialog exactly is going to be kept in each case? Steps to Reproduce: Weblate: https://translations.documentfoundation.org/translate/libo_ui-master/basctlmessages/en/?checksum=ed02a0b2283ed846 Actual Results: The sentence is confusing. Expected Results: The string does a better job of explaining which dialogs are going to be kept and which discarded in each case. Reproducible: Always User Profile Reset: No Additional Info: n/a
Not being a native English speaker, all I can say is that the wording could be misinterpreted. Unfortunately the corresponding Help page is not available via the F1 key - "Could not find Help page (404)". The user should be directed to the "Import Dialog" topic [1] which states i.a.: If the imported dialog has a name that already exists in the library, you see a message box where you can decide to rename the imported dialog. In this case the dialog will be renamed to the next free "automatic" name like when creating a new dialog. Or you can replace the existing dialog by the imported dialog. If you click Cancel the dialog is not imported. Perhaps the wording "Rename imported dialog or replace existing dialog with it" would help to understand the choice? The "Version (earliest affected)" field reads: 7.6.0.0 alpha0+ Master The string in question is present already in version 3.3.0 ------------------------ [1] LibreOffice 7.5 Help, Basic, topic "Import Dialog" https://help.libreoffice.org/latest/en-US/text/sbasic/shared/02/11180000.html?&DbPAR=BASIC
Created attachment 185830 [details] relevant screenshots (UI, Help)
What about these 2 variants? Click Rename to keep the current dialog, or choose Replace to change the existing dialog OR Click Rename to keep the current dialog, or click Replace to change the existing dialog
(In reply to BogdanB from comment #3) > What about these 2 variants? > > Click Rename to keep the current dialog, or choose Replace to change the > existing dialog > > OR > > Click Rename to keep the current dialog, or click Replace to change the > existing dialog Either of these would be an improvement! However, it's still not clear to me (at least without context) what is the difference between "current" and "existing". In many cases those two words would be considered synonymous. Could we come up with a bit more descriptive word choices?
After 30 minutes of research I found that if we export a dialog, then we want to import it, it is already in the system, so it's a conflict between the old one, and the imported one, both with the same name. In the case we press Rename, the old one is kept, and the new one is automatically renamed otherwise. In the case we press Replace, the old one is gone, and the new imported dialog has the same name as the old one. Now I am waiting for suggestion in order to change the text for this window.
I have some proposal version 1 Click Rename to import the dialog with a new automatic name, or click Replace to change the existing dialog with a new one version 2 To import the dialog with a new automatic name, click on the Rename option, or if you wish to replace the existing dialog with a new one, click on the Replace option. version 3 Choose Rename to give the imported dialog a new automatic name, or choose Replace to change the existing dialog completely.
(In reply to BogdanB from comment #6) > I have some proposal > > version 1 > Click Rename to import the dialog with a new automatic name, or click > Replace to change the existing dialog with a new one > > version 2 > To import the dialog with a new automatic name, click on the Rename option, > or if you wish to replace the existing dialog with a new one, click on the > Replace option. > > version 3 > Choose Rename to give the imported dialog a new automatic name, or choose > Replace to change the existing dialog completely. Thanks, these are all much more descriptive. "Change with" is not correct English, though (should be "change to"). Also, "a new one" suggests the meaning "any new one" while in this case it should be "the new one" (that is currently being imported) or "the imported one". And I wouldn't use "change" as a synonym for "replace" ("overwrite" might be a better synonym if you don't want to repeat the word "replace". Come to think of it, the strings on the buttons could be changed, too. "Rename" could become "Rename Automatically" and "Replace" could become "Replace Existing", to make the meaning even clearer.
I will go with: Choose Rename to give the imported dialog a new automatic name, or Replace to overwrite the existing dialog completely. If there are suggestions, I will receive them in the gerrit.
Bogdan B committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/000c7fd6b8edf57b3ced14012994cb521901c360 tdf#154014 Improve Import Dialog sentence in Basic It will be available in 7.6.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.