Bug 154018 - UI string: points vs. corners of polyline
Summary: UI string: points vs. corners of polyline
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
Inherited From OOo
Hardware: All All
: medium minor
Assignee: TH Huang
URL:
Whiteboard: target:25.2.0
Keywords: difficultyBeginner, easyHack, skillCpp
Depends on:
Blocks: Shape-Points
  Show dependency treegraph
 
Reported: 2023-03-06 16:36 UTC by Tuomas Hietala
Modified: 2024-08-19 14:01 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Tuomas Hietala 2023-03-06 16:36:04 UTC
Description:
In LO there's a UI string "Polyline with %2 corners":
https://translations.documentfoundation.org/translate/libo_ui-master/svxmessages/en/?checksum=c702c865ac02d8b3

However, the context string is "STR_ObjNameSingulPLIN_PointCount". So which one is it, corner count or point count? There's a difference: a polyline with only two points will have zero corners, for example.


Steps to Reproduce:
See above

Actual Results:
It's unclear whether the string refers to points or corners.

Expected Results:
Both the user-visible string and the context string reflect what LO actually does in this case.


Reproducible: Always


User Profile Reset: No

Additional Info:
n/a
Comment 1 Stéphane Guillou (stragu) 2023-03-22 07:17:32 UTC
This string can be seen for example in Draw:
1. Open Draw
2. Insert a line
3. Click "Insert point" and click somewhere on the line

I agree "Corner" should be changed to a different word. "Node" is an option, but "Point" is the term used throughout the UI.

Tested in 7.5.1.2, but was also like this in OOo 3.3.

Code pointer: https://opengrok.libreoffice.org/xref/core/include/svx/strings.hrc?r=a16c64ad#69

Hossein, another easyHack I suppose.
Comment 2 Commit Notification 2024-08-18 17:24:48 UTC
TH Huang committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/5af8a83351622e069331cb69eb9e36d34af61a4c

tdf#154018: Change corners to points for polyline and polygon context strings

It will be available in 25.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.