Bug 154019 - UI string "Scale" is misleading
Summary: UI string "Scale" is misleading
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
7.4.5.1 release
Hardware: All All
: medium minor
Assignee: Heiko Tietze
URL:
Whiteboard: target:24.2.0
Keywords: difficultyBeginner, easyHack, skillDesign, topicUI
Depends on:
Blocks: Area-Fill-Tab-Image
  Show dependency treegraph
 
Reported: 2023-03-06 17:07 UTC by Tuomas Hietala
Modified: 2023-09-27 16:34 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Tuomas Hietala 2023-03-06 17:07:00 UTC
Description:
The following UI string, "Scale", is misleading
https://translations.documentfoundation.org/translate/libo_ui-master/cuimessages/en/?checksum=c6d485358d8d8fb9

Checking the "Scale" checkbox will change the size settings to percentages, which suggests that the meaning is "Scale the image by these percentages". However, the actual meaning is "Set the size of the image as percentage of total width and height of the page".

A better phrasing would be e.g. "As percentage of page size"


Steps to Reproduce:
In Writer, go to Format -> Page Style -> Area -> Image

Actual Results:
The string is misleading.

Expected Results:
The string is more descriptive.


Reproducible: Always


User Profile Reset: No

Additional Info:
n/a
Comment 1 Stéphane Guillou (stragu) 2023-03-06 17:27:38 UTC
I think that the issue is that it was not implemented properly.
The documentation[1] currently says:

> "Scale: Mark to turn the height and width settings relative to original size."

... which matches your (and my) expectation.

See bug 116902, which if fixed would make the feature match the expectation and the documentation. Would you agree to mark your report as a duplicate of that one?

[1] https://help.libreoffice.org/7.6/en-US/text/shared/01/05210500.html
Comment 2 Tuomas Hietala 2023-03-08 16:23:42 UTC
Well, changing the strings would be easier than changing the implementation I guess. But if the implementation should be changed anyway, I guess this counts as duplicate.
Comment 3 QA Administrators 2023-03-09 03:26:50 UTC Comment hidden (obsolete)
Comment 4 Stéphane Guillou (stragu) 2023-03-09 14:17:50 UTC
UX team, please see attachment 185721 [details] from related bug 116902, for a compilation of examples.

The name "Scale" does not fit the current behaviour, nor the documentation.
See https://bugs.documentfoundation.org/show_bug.cgi?id=116902#c5

Which one should we do:
- rename the feature (and change the documentation) to something like "Relative to container"; or
- fix the feature so it matches expectations and documentation.

I would go with the second option, as I don't see much use in the current functionality of stretching the image so it fits a fraction (or multiple) of the container's dimensions.
I see more of a use in scaling down the size of the original bitmap, keeping the aspect ratio (e.g. 50% × 50%), to then tile with more density.

Thoughts?
Comment 5 Heiko Tietze 2023-03-14 12:47:30 UTC
We should do both, first rename this label and update the documentation and later finish this dialog.

Code pointer: cui/uiconfig/ui/imagetabpage.ui

The original proposal is here https://design.blog.documentfoundation.org/2015/12/22/area-fill-options-made-consistent/ but couldn't be implemented for the image part as it is over-simplified and does not cover all options from the past resp. specified in the open document format.
Comment 6 Buovjaga 2023-09-24 11:13:16 UTC
Remember to also update help (if needed)
Comment 7 Commit Notification 2023-09-26 05:57:17 UTC
Heiko Tietze committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/3575abbab1994aa1e0ccd8774a7d7fafb22d79e0

Resolves tdf#154019 - Better label in Area dialog more informative

It will be available in 24.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 8 Stéphane Guillou (stragu) 2023-09-27 16:31:58 UTC
Verified the UI fix in:

Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 2902ab24ecc5ffbf4907ea83b2028508b9de6364
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

(In reply to Buovjaga from comment #6)
> Remember to also update help (if needed)

Change in gerrit: https://gerrit.libreoffice.org/c/help/+/157314
Comment 9 Commit Notification 2023-09-27 16:34:28 UTC
Stéphane Guillou committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/help/commit/d1aa4440126530425550bf6e37930861413b99cd

tdf#154019: change string and description in help too