Bug 154029 - Table height minimization ignores height-increasing combining characters when fallback font is used
Summary: Table height minimization ignores height-increasing combining characters when...
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: LibreOffice (show other bugs)
Version:
(earliest affected)
3.5.0 release
Hardware: All Linux (All)
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: RTL-CTL ImpressDraw-Tables Writer-Tables RTL-Arabic-and-Farsi
  Show dependency treegraph
 
Reported: 2023-03-06 21:32 UTC by Eyal Rozenberg
Modified: 2023-06-01 18:31 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments
Presentation with 𐴇𐴥 in a table row with wrong height (316.73 KB, application/vnd.oasis.opendocument.presentation)
2023-03-06 21:32 UTC, Eyal Rozenberg
Details
Writer document with 𐴇𐴥 in a table row with wrong height (11.96 KB, application/vnd.oasis.opendocument.text)
2023-03-06 21:44 UTC, Eyal Rozenberg
Details
Screenshot of attachment 185805 on my system (17.09 KB, image/png)
2023-03-06 21:45 UTC, Eyal Rozenberg
Details
Writer document with اً in a table row with wrong height (12.27 KB, application/vnd.oasis.opendocument.text)
2023-03-09 21:27 UTC, Eyal Rozenberg
Details
Screenshot of attachment 185873 on my system (35.37 KB, image/png)
2023-03-09 21:29 UTC, Eyal Rozenberg
Details
Screenshot of the presentation in 185803 on my system (74.11 KB, image/png)
2023-04-03 10:44 UTC, Eyal Rozenberg
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Eyal Rozenberg 2023-03-06 21:32:56 UTC
Created attachment 185803 [details]
Presentation
 with 𐴇𐴥 in a table row with wrong height

In the Rohingya Hanifi script, there's a modifying character named Tahala: U+10D25 . Here's a Ha letter with a Tahala: 𐴇𐴥 

Now, if I put that in a table cell, its size should be made large enough to accommodate the Tahala. And - sometimes this happens. But
if I use a font which doesn't have Rohingya, specifically, Nachlieli CLM, for the RTL language group - then somehow the size is not increased to contain the Ha + Tahala. 

See attached document - and note that, on my system, the fallback font is Noto Sans, so the two table rows should exhibit the same actual font.

Note: I'm not sure if this happens only with Rohingya, it might be an issue more generally with stated vs actual/fallback font metrics.
Comment 1 Eyal Rozenberg 2023-03-06 21:41:22 UTC
I'm also seeing this with tables in Writer.
Comment 2 Eyal Rozenberg 2023-03-06 21:44:45 UTC
Created attachment 185805 [details]
Writer document with 𐴇𐴥 in a table row with wrong height

Writer document with two table rows, one with David CLM font (and fallback to Noto Sans on my system) and the other with Noto Sans explicitly for RTL-CTL.
Comment 3 Eyal Rozenberg 2023-03-06 21:45:08 UTC
Created attachment 185806 [details]
Screenshot of attachment 185805 [details] on my system
Comment 4 Eyal Rozenberg 2023-03-09 21:27:11 UTC
I've found this also happens with Arabic. Attachment coming soon.
Comment 5 Eyal Rozenberg 2023-03-09 21:27:52 UTC
Created attachment 185873 [details]
Writer document with اً in a table row with wrong height
Comment 6 Eyal Rozenberg 2023-03-09 21:29:03 UTC
Created attachment 185874 [details]
Screenshot of attachment 185873 [details] on my system
Comment 7 Buovjaga 2023-04-03 09:20:06 UTC
I see no issue with the Impress presentation attachment 185803 [details], but I confirm the modifying character goes outside the table row with the Writer ones (only for the top row).

Already seen in 5.2 and 3.5.

Arch Linux 64-bit, X11
Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 56ae7d01505fdae421109cfc78449230ba589d79
CPU threads: 8; OS: Linux 6.2; UI render: default; VCL: kf5 (cairo+xcb)
Locale: fi-FI (fi_FI.UTF-8); UI: en-US
Calc: threaded
Built on 3 April 2023
Comment 8 Eyal Rozenberg 2023-04-03 10:29:59 UTC
(In reply to Buovjaga from comment #7)
> I see no issue with the Impress presentation attachment 185803 [details]

With respect, Ilmari - as a speaker and reader of Arabic I insist that it's a significant issue. Imagine Impress cutting the bottom part of a 'g' or a 'j' out of the table row... that's preposterous :-( 

I'm not saying it's a grave issue, but it's not minor, it's of regular severity.
Comment 9 Buovjaga 2023-04-03 10:40:29 UTC
(In reply to Eyal Rozenberg from comment #8)
> (In reply to Buovjaga from comment #7)
> > I see no issue with the Impress presentation attachment 185803 [details]
> 
> With respect, Ilmari - as a speaker and reader of Arabic I insist that it's
> a significant issue. Imagine Impress cutting the bottom part of a 'g' or a
> 'j' out of the table row... that's preposterous :-( 
> 
> I'm not saying it's a grave issue, but it's not minor, it's of regular
> severity.

Ok, but I'm saying I don't see the problem (and you did not provide a screenshot for how it looks like in the Impress doc for you).
Comment 10 Eyal Rozenberg 2023-04-03 10:44:23 UTC
Created attachment 186435 [details]
Screenshot of the presentation in 185803 on my system

(In reply to Buovjaga from comment #9)
> Ok, but I'm saying I don't see the problem (and you did not provide a
> screenshot for how it looks like in the Impress doc for you).

Adding that as well. It rather similar to the Writer situation.