Bug 154052 - Make "Level" spinbox into a dropdown menu in the Document tab of "Insert - Field"
Summary: Make "Level" spinbox into a dropdown menu in the Document tab of "Insert - Fi...
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
Inherited From OOo
Hardware: All All
: low enhancement
Assignee: Baole Fang
URL:
Whiteboard: target:24.2.0
Keywords: difficultyBeginner, easyHack, skillCpp, topicUI
Depends on:
Blocks: Fields-Dialog
  Show dependency treegraph
 
Reported: 2023-03-07 23:09 UTC by sdc.blanco
Modified: 2024-02-11 16:00 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description sdc.blanco 2023-03-07 23:09:56 UTC
1. Insert - Field - More Fields (Ctrl+F2) - Document tab
2. Select type "Chapter"

Actual: "Level" appears with a spinbox
Proposed: spinbox should be a combobox, with values 1-10.

Reasons: - Faster/easier to select desired value.
         - Indicates quickly the entire space of possible choices.
Comment 1 sdc.blanco 2023-03-08 17:45:12 UTC
Probably an EasyHack
Comment 2 Stéphane Guillou (stragu) 2023-03-22 07:27:10 UTC
I agree that it would be an improvement, but copying UX team in to double-check.

If done, other parts of the UI should follow, for example Insert > Table of Contents or Index > Table of Contents, Index or Bibliography > Type.

Was already a spinbox in OOo 3.3.

(Note that in LO 7.6, "Chapter" was renamed to "Heading".)
Comment 3 Heiko Tietze 2023-03-22 08:25:59 UTC
The spinedit is a very efficient control to change numerical values within a defined range. You can edit the value directly, what is not possible on dropdown controls. And the range of 1..10 is not a surprise for experienced users (nor you see all items with an expanded dropdown showing 8 items by default).

Don't see much benefit in changing it. But also no big issue. Other opinions?
Comment 4 Eyal Rozenberg 2023-05-31 20:51:09 UTC
(In reply to sdc.blanco from comment #0)
> 1. Insert - Field - More Fields (Ctrl+F2) - Document tab
> 2. Select type "Chapter"

There is no such type in the Document Tab of the Fields dialog. Do you mean "Heading" ?

I'm using:
Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 5cd9de202765e243e41416802f3e4486b8a96f16
CPU threads: 4; OS: Linux 6.1; UI render: default; VCL: gtk3
Locale: he-IL (en_IL); UI: en-US

Anyway, the spin box lets you type a value; if that is maintained, then ok. If it's not, then I'm not sure it's a sound enough tradeoff, but I don't mind that much either way.
Comment 5 Heiko Tietze 2023-06-02 07:50:41 UTC
We discussed the topic in the design meeting. Since the level is a fix list with always the exact same (low) number of entries the proposed dropdown indeed fits better.

Code pointer: sw/uiconfig/swriter/ui/flddocumentpage.ui and sw/source/ui/fldui/flddok.cxx

(see also sw/uiconfig/swriter/ui/fldvarpage.ui resp. Variables > Number Range in the dialog where the same information is realized per dropdown)
Comment 6 Baole Fang 2023-10-20 04:21:23 UTC
start working on this
Comment 7 Commit Notification 2023-10-24 07:11:02 UTC
Baole Fang committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/27fde46937ecb71e7ce738cba430119a79cea77f

tdf#154052: Change "Level" spinbox to combobox

It will be available in 24.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.