Bug 154063 - The dialog box Tools>Language>Autocorrect>Autocorrect Options can be made wider, but it cannot be made narrower again while in that dialogue
Summary: The dialog box Tools>Language>Autocorrect>Autocorrect Options can be made wid...
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
6.3 all versions
Hardware: All Linux (All)
: medium normal
Assignee: Caolán McNamara
URL:
Whiteboard: target:24.2.0
Keywords: bibisected, bisected, regression
Depends on:
Blocks: AutoCorrect-Complete
  Show dependency treegraph
 
Reported: 2023-03-08 10:24 UTC by Adalbert Hanßen
Modified: 2023-09-19 04:45 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments
LO Writer document showing the steps with screenshots (185.30 KB, application/vnd.oasis.opendocument.text)
2023-03-08 10:24 UTC, Adalbert Hanßen
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Adalbert Hanßen 2023-03-08 10:24:46 UTC
Created attachment 185838 [details]
LO Writer document showing the steps with screenshots

Open a new text document.
2. Select Tools>Language>Autocorrect>Autocorrect Options
3. Grab the dialog window by the right border and make the dialog window wider (it does not matter which tab is selected)
4. Make the dialog box wider
5. Without leaving the dialogue: Try to make the window narrower again. It won’t work when grabbed at either edge
6. But it works, when grabbed at the corner

Expected result:
In step 5: being able to make the dialog box narrower when grabbed at the right or at the left corner.


By the way: The minimum height of the dialog window could be reduced without further ado. Then instructions and error reports would need less space.
Comment 1 Xisco Faulí 2023-03-08 11:08:39 UTC
Regression introduced by:

author	Caolán McNamara <caolanm@redhat.com>	2019-05-20 12:34:52 +0100
committer	Caolán McNamara <caolanm@redhat.com>	2019-05-21 17:21:02 +0200
commit 86618248683fa4048192d15356c7e6b430e8dbb9 (patch)
tree 56e8bfbb202fc09539af38e2f273d56b24baecd5
parent a703b4d8842261f55f489c28352df1f53a9b070a (diff)
tdf#109158 short-circuit text width measuring with fixed width columns

Bisected with: bibisect-linux64-6.3

Adding Cc: to Caolán McNamara
Comment 2 V Stuart Foote 2023-04-10 16:32:52 UTC
Can not confirm on Windows builds. Able to grab the sides as well as the corners to resize the Tools -> Autocorrect -> Autocorrect Options... dialog frame--wider and narrower.

Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 1e9f4de320f67d1218c710bcee1969a2324c6888
CPU threads: 8; OS: Windows 10.0 Build 19044; UI render: Skia/Vulkan; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: CL threaded

likwise for the 7.5.1 release build.
Comment 3 BogdanB 2023-04-10 17:06:39 UTC
Seems to be specific to Linux
Comment 4 Caolán McNamara 2023-09-07 15:57:53 UTC
I have a plausible solution for this
Comment 5 Commit Notification 2023-09-12 07:31:53 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/af11de36dc30df8f3f66cee7be836b6250bae4f5

tdf#154063 allow autocorrect GtkTreeView to shrink

It will be available in 24.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 6 Adalbert Hanßen 2023-09-18 21:09:00 UTC
(In reply to Commit Notification from comment #5)
> Caolán McNamara committed a patch related to this issue.
> It has been pushed to "master":
> 
> https://git.libreoffice.org/core/commit/
> af11de36dc30df8f3f66cee7be836b6250bae4f5
> 
> tdf#154063 allow autocorrect GtkTreeView to shrink
> 
> It will be available in 24.2.0.
> 
> The patch should be included in the daily builds available at
> https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
> information about daily builds can be found at:
> https://wiki.documentfoundation.org/Testing_Daily_Builds
> 
> Affected users are encouraged to test the fix and report feedback.

I tried it in Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: b3fdd999f87312447d03915585812b3a5cd48141
CPU threads: 4; OS: Linux 5.4; UI render: default; VCL: gtk3
Locale: de-DE (de_DE.UTF-8); UI: en-US
Calc: threaded

I tried my old bug example and the behavior was as expected now.
Comment 7 BogdanB 2023-09-19 04:45:04 UTC
Marked as verified, based on comment 6. 
Adalbert, thanks for reporting and testing. Caolan, thanks for fixing.