Bug 154077 - Drop Common/InternalMSExport/UseOldExport config key completely
Summary: Drop Common/InternalMSExport/UseOldExport config key completely
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: filters and storage (show other bugs)
(earliest affected)
Inherited From OOo
Hardware: All All
: low trivial
Assignee: Not Assigned
Whiteboard: target:24.2.0
Keywords: difficultyBeginner, easyHack, skillCpp, topicCleanup
Depends on:
Reported: 2023-03-08 18:01 UTC by Gabor Kelemen (allotropia)
Modified: 2023-10-05 12:41 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Note You need to log in before you can comment on or make changes to this bug.
Description Gabor Kelemen (allotropia) 2023-03-08 18:01:26 UTC
The config key in the title was added in commit 

along with some new OLE export format support, to keep the old format support as a configurable option as well.

Then later in commit

the else branch belonging to this keys use was emptied to only contain a debug message, meaning since this commit (from 2004!) the key has no practical use the way it was intended. 
Thus, it can be removed from the code base.

Tasks to achieve this:
- from filter/source/msfilter/msoleexp.cxx remove the function that retrieves the UseOldExport key
- from officecfg/ remove both mentions of the InternalMSExport config group
- prefix the commit with [API CHANGE] since config keys are part of the published UNO API
- list the change in the API changes section on the wiki page https://wiki.documentfoundation.org/ReleaseNotes/7.6 (or the appropriate later if this gets fixed after the 7.6 feature freeze)
Comment 1 Commit Notification 2023-10-05 12:40:35 UTC
Gabor Kelemen committed a patch related to this issue.
It has been pushed to "master":


[API CHANGE] tdf#154077 Drop InternalMSExport config group

It will be available in 24.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:

Affected users are encouraged to test the fix and report feedback.
Comment 2 Samuel Mehrbrodt (allotropia) 2023-10-05 12:40:53 UTC
Please add this to the release notes.