Bug 154115 - A useless Text Field shows up when typing with Option menu open. prevents Options menu from closing the
Summary: A useless Text Field shows up when typing with Option menu open. prevents Opt...
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
6.4.0.3 release
Hardware: x86-64 (AMD64) Linux (All)
: medium normal
Assignee: Caolán McNamara
URL:
Whiteboard: target:7.6.0 target:7.5.3
Keywords:
Depends on:
Blocks: Options-Dialog GTK3
  Show dependency treegraph
 
Reported: 2023-03-10 13:01 UTC by Abdallah Elhdad
Modified: 2023-03-30 12:21 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments
Bug show (77.89 KB, image/png)
2023-03-10 13:03 UTC, Abdallah Elhdad
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Abdallah Elhdad 2023-03-10 13:01:01 UTC
Description:
Opening the Options menu from, Tools > Options..., start tying on the keyboard, and a Text Field shows at the bottom left corner, try closing the Options menu, it will not close until you delete the typed Text. 

Steps to Reproduce:
1. Tools > Options...
2. start typing on the keyboard, and a Text Field shows at the bottom left corner. 


Actual Results:
a non-closable Option menu and a useless Text Field 

Expected Results:
no Text Field


Reproducible: Always


User Profile Reset: Yes

Additional Info:
Version: 7.5.1.2 (X86_64) / LibreOffice Community
Build ID: fcbaee479e84c6cd81291587d2ee68cba099e129
CPU threads: 12; OS: Linux 6.1; UI render: default; VCL: gtk3
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded
Comment 1 Abdallah Elhdad 2023-03-10 13:03:59 UTC
Created attachment 185885 [details]
Bug show
Comment 2 Stéphane Guillou (stragu) 2023-03-27 22:12:48 UTC
This is supposed to be the feature in which typing something allows jumping to a matching section in the dialog.

It used to work in:

Version: 6.3.6.2
Build ID: 2196df99b074d8a661f4036fca8fa0cbfa33a497
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3; 
Locale: en-AU (en_AU.UTF-8); UI-Language: en-US
Calc: threaded

and stopped working in 6.4.

Not reproduced with kf5 (cairo+xcb), qt5 (qfont+xcb) or gen VCLs.

Bibisected with linux-64-6.4 bibisect repo to first bad commit bc99cd5ceaa8016dec89a82a09d5839c7fe2feb0 which points to core commit:

commit 94d6fa11d086187b82adf9aa596e0f334827e095
author	Caolán McNamara <caolanm@redhat.com>	Tue Sep 17 12:50:05 2019 +0100
committer	Caolán McNamara <caolanm@redhat.com>	Fri Sep 20 21:20:51 2019 +0200
weld OfaTreeOptionsDialog
Reviewed-on: https://gerrit.libreoffice.org/79070

Caolán, can you please have a look?
Comment 3 Caolán McNamara 2023-03-27 22:32:12 UTC
The "useless Text field" is built into GtkTreeViews (always available with ctrl+f) and defaults on for use with interactive search with "Enable Search" when viewed in glade with cui/uiconfig/ui/optionsdialog.ui and the "pages" widget. In this case it looks like it is set to use the wrong column from the model. I find that when active one click anywhere is enough to dismiss the search box, and then the next click will cancel as usual if over X or Cancel, and don't see a requirement to delete the typed text.
Comment 4 Commit Notification 2023-03-29 08:06:53 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/1d2ad8e8823a8633534580d589270945f01f1ca1

tdf#154115 use correct column for search

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 5 Caolán McNamara 2023-03-29 08:50:18 UTC
done in trunk to use the correct model in the column for search, backport to 7-5 in gerrit
Comment 6 Commit Notification 2023-03-29 10:13:06 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-7-5":

https://git.libreoffice.org/core/commit/0b1ac88478197218ac9ec164014dfdc30ca7a496

tdf#154115 use correct column for search

It will be available in 7.5.3.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 7 Stéphane Guillou (stragu) 2023-03-30 12:21:57 UTC
Thank you Caolán, verified fixed in:

Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 9c7d3ce813c761b116232bc291e2737c59d383da
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded