Bug 154129 - FILEOPEN DOCX: framePr anchored to text, not page when unspecified
Summary: FILEOPEN DOCX: framePr anchored to text, not page when unspecified
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
Inherited From OOo
Hardware: All All
: medium normal
Assignee: Justin L
URL:
Whiteboard: target:7.6.0 target:24.2.0 target:7.6.3
Keywords: bibisected, bisected
Depends on:
Blocks: DOCX-Frames
  Show dependency treegraph
 
Reported: 2023-03-10 20:33 UTC by Justin L
Modified: 2023-10-05 06:42 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
CBC_AnchorPlacement.docx: The three frame should be in a straight line (20.92 KB, application/vnd.openxmlformats-officedocument.wordprocessingml.document)
2023-03-10 20:33 UTC, Justin L
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Justin L 2023-03-10 20:33:47 UTC
Created attachment 185903 [details]
CBC_AnchorPlacement.docx: The three frame should be in a straight line

The placement of the textboxes is not correct.

This is clearly seen in the coloured, third box which is horizontally out of line with the others. (The first two are properly aligned to the page, not the text). It should also be higher up - vertically aligned with the page as well.

The difference between them is that the first two are based on styles that define w:vAnchor="page" w:hAnchor="page", but the last one has no w:framePr definition at all.

This is all very interesting, because errata document indicates that:
The standard states that the default value of the hAnchor attribute is page.
->    Word uses a default value of text for the hAnchor attribute.

Well, that is exactly what we are doing, and yet... it should be page after all?

Steps to reproduce:
-open CBC_AnchorPlacement.docx

Notice the last textbox is far down and to the right. It should be directly under the second textbox.
Comment 1 Justin L 2023-03-10 20:37:16 UTC
Oh yes. I bibisected this. In 5.2 they are all lined up down and too the right. (They were ALL aligned to text.

That was partially fixed by 5.3 commit 9920a0bf9d783978cd6f7b97f7528d8aa2571143
Author: Justin Luth on Sat Jul 23 07:54:57 2016 +0300
    tdf#75573 - docx handle frame properties at styles

where now the style properties began to apply.

In the current case, there is no style or direct hAnchor/vAnchor property.
Comment 2 Commit Notification 2023-03-13 07:44:11 UTC
Justin Luth committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/1519ae101abf32187db983c8a08f7bf1899d5d22

tdf#154129 writerfilter framePr: check whole style inheritance: HAnchor

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 3 Justin L 2023-03-13 10:57:33 UTC
(In reply to Justin L from comment #1)
> In the current case, there is no style or direct hAnchor/vAnchor property.
I was wrong about having no style properties.
This style inherited from another style, and that parent style had the definitions. So with this comment 2 patch, my particular document is fixed. The next series of patches will apply the same concept to the other properties incrementally.
Comment 4 Commit Notification 2023-03-13 12:39:06 UTC
Justin Luth committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/b2d754c49b7351f7b2663bb249b4b2f663ef3786

tdf#154129 writerfilter framePr: address nit about nSafetyLimit

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 5 Commit Notification 2023-03-14 00:18:33 UTC
Justin Luth committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/c253fc3877fd91f4345feb60dacb6565f9a2509b

tdf#154129 writerfilter framePr: check whole style inheritance: VAnchor

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 6 Commit Notification 2023-03-14 11:18:39 UTC
Justin Luth committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/b1696d2a3e2015b60fc04a785e6a9f7925f4232e

tdf#154129 writerfilter framePr: check whole style inheritance: Y/YAlign

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 7 Commit Notification 2023-03-14 12:02:46 UTC
Justin Luth committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/630732bfd8ed531e9d412a36a083f33763def054

tdf#112287 tdf#154129 writerfilter framePr: fix vAnchor default

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 8 Commit Notification 2023-03-14 12:03:49 UTC
Justin Luth committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/1bc004f67feb51beb00113cedd5f98a1e6e2bcdd

tdf#154129 writerfilter framePr: check whole style inheritance: X/XAlign

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 9 Commit Notification 2023-03-14 17:10:34 UTC
Justin Luth committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/2571b39158c679a42a68bea5f219e29a42f4e6a6

tdf#154129 writerfilter framePr: check whole style inheritance: W/H

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 10 Commit Notification 2023-03-14 22:46:14 UTC
Justin Luth committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/6f1052da8d145b1176186024dc4745cbd561fe36

tdf#154129 writerfilter framePr: check whole style inheritance: hRule

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 11 Commit Notification 2023-03-15 01:52:36 UTC
Justin Luth committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/44837a12d12be3e525fa48b37c3dd2553cc97d94

tdf#154129 writerfilter framePr: check whole style inheritance: wrap

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 12 Commit Notification 2023-03-15 09:44:11 UTC
Justin Luth committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/2ab9a2e4166264be83300e7ed038be1b803a5ac8

tdf#154129 writerfilter framePr: check whole style inheritance: v/hSpace

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 13 Commit Notification 2023-03-15 09:44:13 UTC
Justin Luth committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/6eb483d3f27e3ee8c56d422fb96f83844370d325

tdf#154129 writerfilter framePr: remove last use of pParaStyle

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 14 Commit Notification 2023-03-15 09:45:16 UTC
Justin Luth committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/fb8522e457b098b5ade98a4a4babbc8704d3fad4

NFC tdf#154129 writerfilter framePr: deduplicate Hori/VertOrient

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 15 Commit Notification 2023-03-15 09:46:18 UTC
Justin Luth committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/1a12246fc1deaaf1e2c723c0c541de85cf88101e

NFC tdf#154129 writerfilter framePr: deduplicate w:w

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 16 Commit Notification 2023-03-15 09:47:21 UTC
Justin Luth committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/af8f05f859a1fb61d88dfe558d1bc7a8282c792a

tdf#154129 writerfilter framePr: deduplicate w:h

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 17 Commit Notification 2023-03-15 09:48:23 UTC
Justin Luth committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/f2a10d9e751bdbc4ba981b6ca9d0dc127439a3c2

tdf#154129 writerfilter framePr: nhRule obey comment instructions

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 18 Commit Notification 2023-03-15 09:49:26 UTC
Justin Luth committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/1188fa78d0e7b5fd8f4c7c207fd4ec9ced666c12

tdf#154129 writerfilter framePr: deduplicate w:x

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 19 Commit Notification 2023-03-15 09:49:28 UTC
Justin Luth committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/611288b64548762e0731ed6323e1653e4fca2317

tdf#154129 writerfilter framePr: deduplicate w:y

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 20 Commit Notification 2023-03-15 09:50:31 UTC
Justin Luth committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/070e62bad980cbe15dfbe9096a5e5d962a70f07c

tdf#154129 writerfilter framePr: deduplicate w:hAnchor

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 21 Commit Notification 2023-03-15 09:51:33 UTC
Justin Luth committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/2d331e6bfe8c9ca31f1a4e092dbcffb8919b8655

tdf#154129 writerfilter framePr: deduplicate w:vAnchor

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 22 Commit Notification 2023-03-15 12:38:09 UTC
Justin Luth committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/33ce22f080bbedfde78fdc907b0d4d5bd0f68f14

tdf#154129 writerfilter framePr: deduplicate w:wrap

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 23 Commit Notification 2023-03-15 12:39:11 UTC
Justin Luth committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/4237db7f43c08efbf166a2bfa8a0c99d1c5f04a4

NFC tdf#154129 writerfilter framePr: deduplicate lcl.. call

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 24 Commit Notification 2023-03-15 12:40:14 UTC
Justin Luth committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/a777dab7544bd11c26ae26c40cce49ab976dab2d

tdf#154129 tdf#73546 writerfilter framePr: fix/deduplicate w:v/hSpace

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 25 Commit Notification 2023-03-15 16:16:40 UTC
Justin Luth committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/d21ba804040bdb275234254fbbe742ce830420c2

tdf#154129 tdf#97128 writerfilter framePr: deduplicate PopFrameDirection

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 26 Commit Notification 2023-03-15 16:16:45 UTC
Justin Luth committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/b1194e42dde6e3749631a6510d9e7b969e5eae8e

tdf#154129 writerfilter framePr: deduplicate BackColorTransparency

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 27 Commit Notification 2023-03-15 16:17:47 UTC
Justin Luth committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/97b84d31a1db2ec690d180effad307f331d62fb9

tdf#154129 tdf#78590 writerfilter framePr: deduplicate grabbag

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 28 Justin L 2023-05-19 16:45:46 UTC
For backporting, these patches were consolidated into one for co23-05 -based off of LO 7.5. https://gerrit.libreoffice.org/c/core/+/151987
Comment 29 Commit Notification 2023-10-04 14:36:54 UTC
Justin Luth committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/4dd491bc50801d10bb2f1004fff6ebcdb5da9f59

tdf#157572 tdf#112287 tdf#154129 writerfilter framePr: fix vAnchor default

It will be available in 24.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 30 Commit Notification 2023-10-05 06:42:24 UTC
Justin Luth committed a patch related to this issue.
It has been pushed to "libreoffice-7-6":

https://git.libreoffice.org/core/commit/e86d30e8bbabeb5e4a5a74d3fe439218a35cce8d

tdf#157572 tdf#112287 tdf#154129 writerfilter framePr: fix vAnchor default

It will be available in 7.6.3.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.