Bug 154274 - [UI] Improve display format (fields) of Comments on Track(ed) Changes
Summary: [UI] Improve display format (fields) of Comments on Track(ed) Changes
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
Inherited From OOo
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:7.6.0
Keywords:
Depends on:
Blocks: Calc-Comments Calc-Track-Changes
  Show dependency treegraph
 
Reported: 2023-03-19 14:13 UTC by ady
Modified: 2023-09-05 11:17 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description ady 2023-03-19 14:13:13 UTC
Based on
https://bz.apache.org/ooo/show_bug.cgi?id=128557

...that was implemented for AOO 4.1.14.

Repro in LO as of 7.4.5.

If there is no info in Tools > Options > LibreOffice > User Data > "First/last name/initials", looks slightly worse than described in the original AOO ticket.
Comment 1 Xisco Faulí 2023-03-21 09:12:16 UTC
Moving to NEW
Comment 2 Xisco Faulí 2023-03-21 10:09:46 UTC
https://gerrit.libreoffice.org/c/core/+/149206
Comment 3 ady 2023-03-21 12:40:18 UTC
(In reply to ady from comment #0)
> If there is no info in Tools > Options > LibreOffice > User Data >
> "First/last name/initials", looks slightly worse than described in the
> original AOO ticket.

To be clear, the original issues are also present in Calc too as of LO 7.5.x.
Comment 4 Commit Notification 2023-03-22 07:27:16 UTC
Xisco Fauli committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/7131530929d3670b8c2db7dc0c1a86c822e05660

tdf#154274: show "Unknown Author" when no name is set

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 5 ady 2023-03-24 13:44:00 UTC
The original problem still persists. "Unknown Author" is shown now, but the original problem is _not_ solved.
Comment 6 ady 2023-04-04 22:53:57 UTC
Quoting (partially, with edition) from original report for AOO...

Notice that:
(1)
There is a colon at the end of the first line/part.
Keep in mind the French might require a leading space
(":" is hardcoded...) and that Writer doesn't display
the colon in a callout.

Could the content of the callout really be misunderstood
without the colon?


(2)
there is a superfluous space after "("
in the line describing the recorded change.
The Accept or Reject Changes dialog doesn't show it.
Expected result:
no colon (1) and no space (2).

[end quote]

Potential code points (based on the original bug report for AOO):
libreoffice-7.5.1.2/sc/source/ui/view/gridwin5.cxx

As of LO 7.5.1.2, line 132 " " and line 134 ":\n".

As I am not a developer, this might not be accurate or enough.