Bug 154379 - [VISIO] [Fileopen] Text is not readable by wrong Fill color due to issue with QuickStyleFillMatrix and TextBkgnd
Summary: [VISIO] [Fileopen] Text is not readable by wrong Fill color due to issue with...
Status: RESOLVED FIXED
Alias: None
Product: Document Liberation Project
Classification: Unclassified
Component: libvisio (show other bugs)
Version:
(earliest affected)
unspecified
Hardware: All All
: medium normal
Assignee: Bartosz
URL:
Whiteboard: inReleaseNotes:25.2
Keywords: filter:visio
Depends on:
Blocks: Visio
  Show dependency treegraph
 
Reported: 2023-03-25 12:31 UTC by Dennis Roczek
Modified: 2024-12-09 07:53 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments
anonymized example (134.69 KB, application/vnd.ms-visio.drawing.main+xml)
2023-03-25 12:32 UTC, Dennis Roczek
Details
printscreen from visio (103.59 KB, image/png)
2023-04-07 23:08 UTC, raal
Details
How it looks like in MS Visio (157.46 KB, image/png)
2024-09-22 10:32 UTC, Bartosz
Details
Sample file with different QuickStyleFillMatrix values (109.23 KB, application/vnd.ms-visio.drawing.main+xml)
2024-10-07 23:29 UTC, Bartosz
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Dennis Roczek 2023-03-25 12:31:59 UTC
Description:
The attached file is anonymized (unzip, modified, zipped). Many of the texts are not readable / visible as having the wrong color (?).

Steps to Reproduce:
open file and try to read it.

Actual Results:
not visible text

Expected Results:
visible text


Reproducible: Always


User Profile Reset: Yes

Additional Info:
Version: 7.5.1.2 (X86_64) / LibreOffice Community
Build ID: 50(Build:2)
CPU threads: 4; OS: Linux 5.19; UI render: default; VCL: gtk3
Locale: de-DE (de_DE.UTF-8); UI: de-DE
Ubuntu package version: 4:7.5.1~rc2-0ubuntu0.22.04.1~lo1
Calc: threaded
Comment 1 Dennis Roczek 2023-03-25 12:32:40 UTC
Created attachment 186205 [details]
anonymized example
Comment 2 Dennis Roczek 2023-03-26 13:55:47 UTC
I do have ~6 more files with the same problem. I can provide them privately or do have to anonymize them manually also.
Comment 3 raal 2023-04-07 23:08:38 UTC
Created attachment 186539 [details]
printscreen from visio
Comment 4 raal 2023-04-07 23:09:27 UTC
confirm with Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 250b820a24640a33d73a6e690e04e36be01cda28
CPU threads: 4; OS: Linux 5.19; UI render: default; VCL: gtk3
Locale: cs-CZ (cs_CZ.UTF-8); UI: en-US
Calc: threaded
Comment 5 Bartosz 2023-09-04 10:54:29 UTC
If you have access to Visio, please resave it as .VSD and check if the issue is reproducible with this format.
Comment 6 Bartosz 2024-09-22 10:32:08 UTC
Created attachment 196599 [details]
How it looks like in MS Visio
Comment 7 Bartosz 2024-10-07 23:29:10 UTC
Created attachment 196957 [details]
Sample file with different QuickStyleFillMatrix values
Comment 8 Bartosz 2024-10-08 19:11:16 UTC
To resolve this issues, I have created two Reviews:
https://gerrit.libreoffice.org/c/libvisio/+/174698/3
and
https://gerrit.libreoffice.org/c/libvisio/+/174712/1

After merging these changes, the images should be opened correctly.

You could build and install libvisio according to instruction:
https://wiki.documentfoundation.org/DLP/Libraries/libvisio

After that the images should open properly in LibreOffice, as LibreOffice is taking locally installed version of libvisio.
Comment 9 Bartosz 2024-10-08 19:12:01 UTC
Do you have some other Visio files, for verification?
Comment 10 Dennis Roczek 2024-10-08 22:09:22 UTC
(In reply to Bartosz from comment #9)
> Do you have some other Visio files, for verification?

I guess so. But on my other laptop. Already at Lux for the conference.
Comment 11 Bartosz 2024-10-12 06:59:48 UTC
(In reply to Dennis Roczek from comment #10)
> I guess so. But on my other laptop. Already at Lux for the conference.

Thanks Dennis. Can you verify if the issue was solve, by building latest version of libvisio?

The build instruction you can find here:
https://wiki.documentfoundation.org/DLP/Libraries/libvisio

After install libvisio, the Libreoffice should use the latest version of libvisio.
Comment 12 Xisco Faulí 2024-10-12 09:36:20 UTC
Hi Bartosz,
Thanks for fixing this issue.
Currently LibreOffice uses libvisio 0.1.7 from 2019. Should a new version be released now ?
Comment 13 Bartosz 2024-10-12 20:37:02 UTC
(In reply to Xisco Faulí from comment #12)
> Currently LibreOffice uses libvisio 0.1.7 from 2019. Should a new version be
> released now ?

Hi Xisco.
Yes, the new release would be extremally useful.

I would like to improve few things in libvisio (especially for older formats), and confirm that new improvements does't introduce regression (from Dennis Roczek).

Do you know how to perform a release?
Comment 14 Xisco Faulí 2024-10-15 12:28:54 UTC
(In reply to Bartosz from comment #13)
> (In reply to Xisco Faulí from comment #12)
> > Currently LibreOffice uses libvisio 0.1.7 from 2019. Should a new version be
> > released now ?
> 
> Hi Xisco.
> Yes, the new release would be extremally useful.
> 
> I would like to improve few things in libvisio (especially for older
> formats), and confirm that new improvements does't introduce regression
> (from Dennis Roczek).
> 
> Do you know how to perform a release?

no, I don't know but I can ask. Just let me know when you are done improving the library so I can create a new release.
Comment 15 Dennis Roczek 2024-10-16 09:06:41 UTC
(In reply to Bartosz from comment #11)
> (In reply to Dennis Roczek from comment #10)
> > I guess so. But on my other laptop. Already at Lux for the conference.
> 
> Thanks Dennis. Can you verify if the issue was solve, by building latest
> version of libvisio?
> 
> The build instruction you can find here:
> https://wiki.documentfoundation.org/DLP/Libraries/libvisio
> 
> After install libvisio, the Libreoffice should use the latest version of
> libvisio.

Yeah, I can verify, that this bug is fixed. :-)

I guess we do need a new libvisio release.
Comment 16 Dennis Roczek 2024-10-17 16:35:01 UTC
(In reply to Xisco Faulí from comment #14)
> (In reply to Bartosz from comment #13)
> > (In reply to Xisco Faulí from comment #12)
> > > Currently LibreOffice uses libvisio 0.1.7 from 2019. Should a new version be
> > > released now ?
> > 
> > Hi Xisco.
> > Yes, the new release would be extremally useful.
> > 
> > I would like to improve few things in libvisio (especially for older
> > formats), and confirm that new improvements does't introduce regression
> > (from Dennis Roczek).
> > 
> > Do you know how to perform a release?
> 
> no, I don't know but I can ask. Just let me know when you are done improving
> the library so I can create a new release.

Is this then now resolved fixed verified? Just curious.
Comment 17 Bartosz 2024-10-17 19:47:23 UTC
> Is this then now resolved fixed verified? Just curious.

I would say it is fixed in libvisio. Unfortunately it is not integrated into LibreOffice, as we need to make libvisio release.