Bug 154387 - Provide a possibility to change the strikethrough color
Summary: Provide a possibility to change the strikethrough color
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: LibreOffice (show other bugs)
Version:
(earliest affected)
Inherited From OOo
Hardware: All All
: medium enhancement
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: filter:odf, filter:rtf
Depends on:
Blocks: 53412 ODF-import
  Show dependency treegraph
 
Reported: 2023-03-25 14:29 UTC by Dennis Roczek
Modified: 2023-03-27 14:50 UTC (History)
7 users (show)

See Also:
Crash report or crash signature:


Attachments
Strike Through Color (9.20 KB, application/vnd.oasis.opendocument.text)
2023-03-25 15:32 UTC, Dennis Roczek
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Dennis Roczek 2023-03-25 14:29:09 UTC
Description:
There is no possibility to change the strike through color for characters. ODF, OOXML (and even RTF extension by Apple) has this in the specs.

Steps to Reproduce:
Try to change the color of the strike through color.

Actual Results:
no possibility

Expected Results:
A possibility to change it.


Reproducible: Always


User Profile Reset: Yes

Additional Info:
Version: 7.5.1.2 (X86_64) / LibreOffice Community
Build ID: 50(Build:2)
CPU threads: 4; OS: Linux 5.19; UI render: default; VCL: gtk3
Locale: de-DE (de_DE.UTF-8); UI: de-DE
Ubuntu package version: 4:7.5.1~rc2-0ubuntu0.22.04.1~lo1
Calc: threaded
Comment 1 Dennis Roczek 2023-03-25 15:32:15 UTC
Created attachment 186214 [details]
Strike Through Color

Manual modified file and added 
style:text-line-through-color="#D33115"

as described in
https://docs.oasis-open.org/office/OpenDocument/v1.3/os/part3-schema/OpenDocument-v1.3-os-part3-schema.html#__RefHeading__1420186_253892949
Comment 2 Dennis Roczek 2023-03-25 15:33:57 UTC
the strike through color / attribute is simply ignored.
Comment 3 V Stuart Foote 2023-03-25 16:22:57 UTC
Manipulating the strikeout/overline/underline is available across modules with the "Character..." dialog.

Handling of Underline and Overline both can be assigned a color
But Strikeout offers 'Automatic' only, and seems bound to font color. It would be useful/consistent to be able to assign a strikeout color different to the font color. 

So differences for SID_ATTR_CHAR_STRIKEOUT, compared to SID_ATTR_CHAR_UNDERLINE or SID_ATTR_CHAR_OVERLINE

Placement/weight of the strikeout and underline are taken from font metric [1]

But would have issues of improving the UI as in bug 153299

=-ref-=
[1] https://gerrit.libreoffice.org/c/core/+/140803
Comment 4 V Stuart Foote 2023-03-25 16:45:22 UTC
(In reply to Dennis Roczek from comment #2)
> the strike through color / attribute is simply ignored.

Confirmed. Edits to the 'dummy text' autotext with Overline, Underline and Strike through saved to Flat ODF. No entry for style:text-line-through-color is recorded.  And if the stanza is added to the style in the XML, on opening to Writer it ignores the value taking the fallback of the fo:color value.

While style:text-underline-color= and style:text-overline-color= receive HEX color values that are correctly parsed, and can changed via UI.
Comment 5 Heiko Tietze 2023-03-27 09:22:22 UTC
If ODF allows to define the strike-trough color we should provide an option to manipulate. The character dialog / font effects offers space for it. We should not put controls on prominent positions such as sidebar or main menu as this attribute is rather a niche option.
Comment 6 Regina Henschel 2023-03-27 13:27:23 UTC
(In reply to Heiko Tietze from comment #5)
> If ODF allows to define the strike-trough color we should provide an option
> to manipulate.

ODF has this as style:text-line-through-color
https://docs.oasis-open.org/office/OpenDocument/v1.3/os/part3-schema/OpenDocument-v1.3-os-part3-schema.html#property-style_text-line-through-color

But it is not implemented in LibreOffice, that is, if I add it in file markup the line will not be colored. So there is something more to do than adding a control for it. However, as it already exists in ODF we should implement it.