Bug 154401 - Assertion when undoing remove a comment of a cell [maShapesMap.find(xShape) == maShapesMap.end()", file=sc/source/ui/Accessibility/AccessibleDocument.cxx", line=1175]
Summary: Assertion when undoing remove a comment of a cell [maShapesMap.find(xShape) =...
Status: RESOLVED WORKSFORME
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
7.6.0.0 alpha0+
Hardware: x86-64 (AMD64) Linux (All)
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: haveBacktrace
Depends on:
Blocks: Crash-Assert
  Show dependency tree / graph
 
Reported: 2023-03-26 08:54 UTC by Julien Nabet
Modified: 2024-06-06 13:08 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:

Attachments
bt with debug symbols (9.57 KB, text/plain)
2023-03-26 08:54 UTC, Julien Nabet 		Details
bt with debug symbols (9.57 KB, text/plain)
2023-05-17 07:03 UTC, Julien Nabet 		Details
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Julien Nabet 2023-03-26 08:54:15 UTC 
Description:
On pc Debian x86-64 with master sources updated today + gtk3 rendering, I got an assertion when after having removed a comment in a cell, I undo the action.

Steps to Reproduce:
1. Launch Calc
2. Insert a comment in a cell
3. Delete the comment
4. Undo

Actual Results:
Assertion

Expected Results:
No assertion


Reproducible: Always


User Profile Reset: Yes

Additional Info:
Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 8361cef32d54d2dec32e22c35c6d77ca792ae90a
CPU threads: 12; OS: Linux 6.1; UI render: default; VCL: gtk3
Locale: fr-FR (fr_FR.UTF-8); UI: en-US
Calc: threaded
Comment 1 Julien Nabet 2023-03-26 08:54:27 UTC 
Created attachment 186229 [details]
bt with debug symbols
Comment 2 Julien Nabet 2023-03-26 08:57:00 UTC 
Michael: since it concerns accessibility, thought it might interest you.

I noticed that ScChildrenShapes::AddShape was called twice.
Once when deleting the note and once when undoing the delete.
Comment 3 Aron Budea 2023-03-26 21:02:12 UTC 
Confirmed using LO 7.6.0.0.alpha0+ (e78e3b2de19f8a2f9b5d6f256bd3b1c147fee780) / Ubuntu.
Comment 4 Julien Nabet 2023-04-01 10:22:38 UTC 
Just for the record, I gave a new try with master sources updated today (following https://cgit.freedesktop.org/libreoffice/core/commit/?id=f51b220b953ec71fb742f799fbe645a93cf3d944) but I still reproduce the assertion.
Comment 5 Julien Nabet 2023-05-17 07:03:22 UTC 
Created attachment 187345 [details]
bt with debug symbols

On pc Debian x86-64 with master sources updated today, I still reproduce this.

I also noticed this on console:
warn:vcl.schedule:7848:7848:vcl/source/app/scheduler.cxx:612: Stop the task before changing the priority, as it will just change after the task was scheduled with the old prio!
warn:vcl:7848:7848:vcl/unx/gtk3/a11y/atklistener.cxx:191: wrong index hint, falling back to updating full child list
warn:legacy.osl:7848:7848:sc/source/ui/Accessibility/AccessibleDocument.cxx:987: here is a selected shape which is not in the childlist
warn:legacy.osl:7848:7848:sc/source/ui/Accessibility/AccessibleDocument.cxx:987: here is a selected shape which is not in the childlist
warn:legacy.osl:7848:7848:sc/source/ui/Accessibility/AccessibleDocument.cxx:987: here is a selected shape which is not in the childlist
warn:legacy.osl:7848:7848:sfx2/source/control/shell.cxx:211: SfxShell::SetUndoManager: exchanging one non-NULL manager with another non-NULL manager? Suspicious!
warn:sfx.control:7848:7848:sfx2/source/control/dispatch.cxx:1211: Childwindow slot missing: 25917
warn:sfx.control:7848:7848:sfx2/source/control/dispatch.cxx:1211: Childwindow slot missing: 26189
warn:sfx.control:7848:7848:sfx2/source/control/dispatch.cxx:1211: Childwindow slot missing: 26190
warn:legacy.osl:7848:7848:sfx2/source/control/shell.cxx:211: SfxShell::SetUndoManager: exchanging one non-NULL manager with another non-NULL manager? Suspicious!
warn:legacy.osl:7848:7848:svx/source/svdraw/svdedxv.cxx:1621: Got UndoManager back in SdrEndTextEdit which is NOT the expected document UndoManager (!)
Comment 6 Julien Nabet 2024-06-06 13:08:47 UTC 
On pc Debian x86-64 with master sources updated today, I don't reproduce this anymore, let's put this one to WFM then.