Bug 154460 - Unclear sentence: "Change typewriter apostrophe, single quotation marks and correct double primes."
Summary: Unclear sentence: "Change typewriter apostrophe, single quotation marks and c...
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
3.5.0 release
Hardware: All All
: medium minor
Assignee: László Németh
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: Options-Dialog-Language
  Show dependency treegraph
 
Reported: 2023-03-29 21:19 UTC by Tuomas Hietala
Modified: 2024-07-05 14:18 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Tuomas Hietala 2023-03-29 21:19:58 UTC
Description:
The string "Change typewriter apostrophe, single quotation marks and correct double primes." occurs two times in LO. It's not correct English and the meaning is somewhat unclear.

"Change typewriter apostrophe" - change into what? I assume typographically correct apostrophe: https://en.wikipedia.org/wiki/Apostrophe#Typographic_form

"single quotation marks" - what are these being changed into?

"correct double primes"- I assume this means changing ASCII double quotation marks into double prime Unicode characters (U+2033).


Steps to Reproduce:
1. See https://translations.documentfoundation.org/translate/libo_ui-master/dictionariesendialog/en/?checksum=b58b6639d4a0d406
and
https://translations.documentfoundation.org/translate/libo_ui-master/dictionariespt_brdialog/en/?checksum=be0cc6427d743477


Actual Results:
The sentence is unclear.

Expected Results:
The sentence is correct English and explains better what the option actually does.


Reproducible: Always


User Profile Reset: No

Additional Info:
n/a
Comment 1 Stéphane Guillou (stragu) 2023-04-13 08:10:57 UTC
Code pointer: https://opengrok.libreoffice.org/xref/dictionaries/en/dialog/en_en_US.properties?r=ff606081

This is the tooltip when hovering over Tools > Options > Language settings > English Sentence Checking > Apostrophe.

I agree the wording is unclear, but can't really suggest a correction here as I'm having a hard time testing it: having it off or on does not seem to change the behaviour.

László, what do you think? Sentence hasn't been touched since your 2011 commit: 95445a70a29c6a1166a19f483566f2c9cfc7563b
Comment 2 László Németh 2024-06-18 12:29:42 UTC
@Tuomas, Stéphane: thanks for the bug report and feedback! It seems, the common English name is "straight" for the obsolete ASCII/typewriter apostrophe:

https://community.adobe.com/t5/indesign-discussions/using-typographer-s-quotes-and-straight-quotes-in-the-same-block-of-text/td-p/10269294

What about "Replace straight quotation marks with their typographic versions"?
Comment 3 Tuomas Hietala 2024-07-05 14:18:58 UTC
(In reply to László Németh from comment #2)
> @Tuomas, Stéphane: thanks for the bug report and feedback! It seems, the
> common English name is "straight" for the obsolete ASCII/typewriter
> apostrophe:
> 
> https://community.adobe.com/t5/indesign-discussions/using-typographer-s-
> quotes-and-straight-quotes-in-the-same-block-of-text/td-p/10269294
> 
> What about "Replace straight quotation marks with their typographic
> versions"?

That sounds good to me, if that's what this option actually does.

What about the double primes, though? Based on the current string it sounds like this option will also change e.g. 5" (five inches written with ASCII double quotation mark) into 5″ (five inches written with Unicode double prime symbol).

The code would need to understand/guess whether the user wanted to use the ASCII double quotation mark as a quotation mark or as a prime symbol. Could someone who understands the code take a look?