Bug 155039 - Color name is not displayed in palette widget
Summary: Color name is not displayed in palette widget
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
7.6.0.0 alpha0+
Hardware: All macOS (All)
: medium normal
Assignee: Heiko Tietze
URL:
Whiteboard: target:7.6.0
Keywords: bibisected, bisected, haveBacktrace, regression
Depends on:
Blocks:
 
Reported: 2023-04-27 08:07 UTC by Xisco Faulí
Modified: 2024-01-31 14:37 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments
screenshot-gen (51.83 KB, image/png)
2023-04-27 08:07 UTC, Xisco Faulí
Details
bt with debug symbols (19.79 KB, text/plain)
2023-04-27 09:10 UTC, Julien Nabet
Details
Calc Color Picker Popup Differences (47.08 KB, image/png)
2023-06-09 12:43 UTC, Carl Pearson
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Xisco Faulí 2023-04-27 08:07:07 UTC
Created attachment 186952 [details]
screenshot-gen

Steps to reproduce:
1. Open LibreOffice
2. Tools - Options - Application Color

-> Color name is not displayed. Compare attached screenshot with attachment 186951 [details] from bug 155038

Reproduced in

Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 52acefd6024ec79f8333ba40eef83816eda3046f
CPU threads: 8; OS: Linux 5.10; UI render: default; VCL: gtk3
Locale: es-ES (es_ES.UTF-8); UI: en-US
Calc: threaded
Comment 1 Xisco Faulí 2023-04-27 08:07:57 UTC
Regression introduced by:

author	Heiko Tietze <tietze.heiko@gmail.com>	2023-04-13 12:15:46 +0200
committer	Heiko Tietze <heiko.tietze@documentfoundation.org>	2023-04-14 11:39:06 +0200
commit 11bb9c14da13507adeeea8dce863fb4b96a92870 (patch)
tree 77731313a7a4630a807a55393d7132e9dda512c3
parent b9ad48f1939145105ee57470b5c9210bacc8ee45 (diff)
[API CHANGE] Related tdf#154080 - Allow customization of comment indicator color


Bisected with: bibisect-linux64-7.6

Adding Cc: to Heiko Tietze
Comment 2 Julien Nabet 2023-04-27 08:52:52 UTC
On pc Debian x86-64 with master sources updated today, I could reproduce this with gtk3 rendering only (everything is ok on kf5 and gen renderings)
I noticed these on console:
(soffice:6826): GLib-GObject-WARNING **: 10:50:18.517: invalid cast from 'GtkImage' to 'GtkLabel'

(soffice:6826): Gtk-CRITICAL **: 10:50:18.517: gtk_label_set_label: assertion 'GTK_IS_LABEL (label)' failed
Comment 3 Julien Nabet 2023-04-27 09:10:09 UTC
Created attachment 186956 [details]
bt with debug symbols

Here's a bt retrieved with export G_DEBUG=fatal-warnings
Comment 4 Heiko Tietze 2023-04-27 09:20:12 UTC
https://gerrit.libreoffice.org/c/core/+/151090

With gtk3/4 the color tab is disabled and I cannot access it. Was it like this before my patch?
Comment 5 Xisco Faulí 2023-04-27 09:21:47 UTC
(In reply to Heiko Tietze from comment #4)
> https://gerrit.libreoffice.org/c/core/+/151090
> 
> With gtk3/4 the color tab is disabled and I cannot access it. Was it like
> this before my patch?

bug 155038
Comment 6 Julien Nabet 2023-04-27 09:36:02 UTC
(In reply to Heiko Tietze from comment #4)
> https://gerrit.libreoffice.org/c/core/+/151090
> 
> With gtk3/4 the color tab is disabled and I cannot access it. Was it like
> this before my patch?

At least not on LO Debian package 7.4.5.1, color tab is enabled with gtk3.
For the rest, I confirm I don't reproduce the crash with your patch + export G_DEBUG=fatal-warnings
Comment 7 Commit Notification 2023-04-27 13:18:15 UTC
Heiko Tietze committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/ec90dae4993b90e0c3a797ac9b43a076527e1a7d

Resolves tdf#155039 - Color name not displayed with GTK3

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 8 BogdanB 2023-04-27 13:20:23 UTC
Verified.
Working well in
Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: ec90dae4993b90e0c3a797ac9b43a076527e1a7d
CPU threads: 16; OS: Linux 5.19; UI render: default; VCL: gtk3
Locale: ro-RO (ro_RO.UTF-8); UI: en-US
Calc: threaded
Comment 9 Carl Pearson 2023-06-09 12:43:51 UTC
Created attachment 187808 [details]
Calc Color Picker  Popup Differences
Comment 10 Carl Pearson 2023-06-09 12:45:24 UTC
This is the same behavior as 155039, but in a Calc sheet, not preferences.

In Calc v7.5.4.2, the background and text color pickers do not show the color name as a 'comments' style popup when hovering over tiles.

Previously (tested Win 10 x64 7.5.0.3, OSX x64 7.5.3.2) hovering over a color tile caused such the popup to appear.

While the attached screen shots are in different color modes (dark for OSX, light for Windows), it is unlikely that is the cause for the  name not to be appearing.

Behavior is the same for both background and text pickers.

The name does show up under the dropdown when hovering over either picker.
Comment 11 Heiko Tietze 2023-06-12 07:03:16 UTC
(In reply to Carl Pearson from comment #10)
> In Calc v7.5.4.2, the background and text color pickers do not show the
> color name as a 'comments' style popup when hovering over tiles.

The tooltip for the color name shows up for me in both Linux and Windows. While it is possible to change the timing for tooltips on the OS level it is unlikely that you have tweaked those details. Does it work on other controls such as the toolbar buttons (the left-most of the standard toolbar shows "New (Ctrl+N)")?
Comment 12 Carl Pearson 2023-06-12 13:29:43 UTC
(In reply to Heiko Tietze from comment #11)
> (In reply to Carl Pearson from comment #10)
> > In Calc v7.5.4.2, the background and text color pickers do not show the
> > color name as a 'comments' style popup when hovering over tiles.
> 
> The tooltip for the color name shows up for me in both Linux and Windows.
> While it is possible to change the timing for tooltips on the OS level it is
> unlikely that you have tweaked those details. Does it work on other controls
> such as the toolbar buttons (the left-most of the standard toolbar shows
> "New (Ctrl+N)")?

Yes, tooltips are showing up for menu choices (New, Bold, etc.), just not in the color pickers.

It seems to be OSX specific, on at least two versions (both Intel x64, one Catalina 10.15.7, one Monterrey 12.6.2).

Safe mode or completely removing and creating a fresh profile had no effect on the OSX machines; still no tooltips.

Tooltips not working in color pickers:
OSX Machine 1:
Version: 7.5.4.2 (X86_64) / LibreOffice Community
Build ID: 36ccfdc35048b057fd9854c757a8b67ec53977b6
CPU threads: 16; OS: Mac OS X 12.6.2; UI render: default; VCL: osx
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded

OSX Machine 2:
Version: 7.5.4.2 (X86_64) / LibreOffice Community
Build ID: 36ccfdc35048b057fd9854c757a8b67ec53977b6
CPU threads: 12; OS: Mac OS X 10.15.7; UI render: default; VCL: osx
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded

Tooltips working OK in color pickers:
OSX Machine 1:
Version: 7.5.3.2 (X86_64) / LibreOffice Community
Build ID: 9f56dff12ba03b9acd7730a5a481eea045e468f3
CPU threads: 16; OS: Mac OS X 12.6.2; UI render: default; VCL: osx
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded

OSX Machine 2:
Version: 7.5.3.2 (X86_64) / LibreOffice Community
Build ID: 9f56dff12ba03b9acd7730a5a481eea045e468f3
CPU threads: 12; OS: Mac OS X 10.15.7; UI render: default; VCL: osx
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded

Linux Machine:
Version: 7.5.4.2 (X86_64) / LibreOffice Community
Build ID: 36ccfdc35048b057fd9854c757a8b67ec53977b6
CPU threads: 20; OS: Linux 6.3; UI render: default; VCL: gtk3
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded

Windows Machine:
Version: 7.5.4.2 (X86_64) / LibreOffice Community
Build ID: 36ccfdc35048b057fd9854c757a8b67ec53977b6
CPU threads: 20; OS: Windows 10.0 Build 19044; UI render: Skia/Vulkan; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: threaded
Comment 13 Heiko Tietze 2023-06-12 13:55:20 UTC
Confirming with 

Version: 7.5.1.2 (X86_64) / LibreOffice Community
Build ID: fcbaee479e84c6cd81291587d2ee68cba099e129
CPU threads: 8; OS: Mac OS X 13.4; UI render: Skia/Raster; VCL: osx
Locale: de-DE (en_DE.UTF-8); UI: en-US
Calc: threaded
Comment 14 Heiko Tietze 2024-01-31 14:37:35 UTC
The tooltips are hidden on other controls as well, preferences > security: options ("Opens the security... on Linux). Obviously unrelated to the issue of missing strings in the application colors. Please file a new ticket.