Bug 155065 - Change label of .uno:InsertPageNumberField to "Page Number Field" (from "Page Number")
Summary: Change label of .uno:InsertPageNumberField to "Page Number Field" (from "Pag...
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
7.2.7.2 release
Hardware: All All
: medium normal
Assignee: sdc.blanco
URL:
Whiteboard: target:7.6.0
Keywords:
Depends on:
Blocks: UNO-Command-Label
  Show dependency treegraph
 
Reported: 2023-04-28 13:26 UTC by sdc.blanco
Modified: 2023-05-24 12:58 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description sdc.blanco 2023-04-28 13:26:32 UTC
There are two "Page Number" labels in the Customize dialog, corresponding to .uno:InsertPageNumberField and .uno:PageOffsetDialog.

Proposal for .uno:InsertPageNumberField

Label: Page Number Field
ContextLabel: Page Number  (so that Insert - Field menu appears correctly)
Tooltip Label: Insert Page Number  (because icon appears in toolbar)

Maybe .uno:PageOffsetDialog should not appear in the customize menu at all?

Since 7.6.0.0.alpha0+, there is a third "Page Number", but a request for a change is made in bug 86630 comment 39.
Comment 1 sdc.blanco 2023-05-03 06:46:34 UTC
(In reply to sdc.blanco from comment #0)
> Since 7.6.0.0.alpha0+, there is a third "Page Number", but a request for a
> change is made in bug 86630 comment 39.
Changed in commit b89f65a5138fe74b7858c2817fae4204b021c1f5.
Comment 2 Heiko Tietze 2023-05-03 14:03:10 UTC Comment hidden (no-value)
Comment 3 Heiko Tietze 2023-05-03 14:24:18 UTC Comment hidden (off-topic)
Comment 4 sdc.blanco 2023-05-03 14:39:31 UTC
(In reply to sdc.blanco from comment #0)
> Proposal for .uno:InsertPageNumberField
https://gerrit.libreoffice.org/c/core/+/151284

> Maybe .uno:PageOffsetDialog should not appear in the customize menu at all?
Any opinion?  With the preceding patch, there will no longer be any overlap with the (Page Number) command names in the Customize dialog, but I could not get this .uno to work (from a menu) and wonder if it is only intended to be part of a field dialog box, and therefore should not appear in the Customize dialog.
Comment 5 Justin L 2023-05-03 14:55:35 UTC
(In reply to Heiko Tietze from comment #3)
> Justin, sorry for the confusion. This proposal...

This bug report/proposal is for .uno:InsertPageNumberField. My work is all for .uno:PageNumberWizard
Comment 6 Justin L 2023-05-03 15:26:10 UTC
(In reply to sdc.blanco from comment #4)
> > Maybe .uno:PageOffsetDialog should not appear in the customize menu at all?
> Any opinion? 
Although I certainly am not at all an expert in UI, it looks to me like this is simply a function call, and that the "Dialog" part of the name is just ancient history. Already existed in initial import in 2000 in basically its current form AFAICS.

It (FN_CHANGE_PAGENUM) appears to do nothing if it isn't passed an SfxUInt16Item pItem. So that suggests there is no point in having it show up in menus/toolbars.
Comment 7 sdc.blanco 2023-05-04 08:00:02 UTC
(In reply to Justin L from comment #6)
> that suggests there is no point in having it show up in menus/toolbars.
Here is my best guess for how to hide .uno:PageOffsetDialog -- if that is the right thing to do.

https://gerrit.libreoffice.org/c/core/+/151285
Comment 8 Commit Notification 2023-05-22 20:53:23 UTC
Seth Chaiklin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/23a41c919602828acb88a477f3f073154d9388ec

tdf#155065  hide .uno:PageOffsetDialog from Customize dialog

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 9 Commit Notification 2023-05-22 20:55:25 UTC
Seth Chaiklin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/343fbe76d5122aed28c3ec6e72ff8629a4f95f1d

tdf#155065  change label for "Page Number" -> "Page Number Field"

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 10 sdc.blanco 2023-05-24 12:58:46 UTC
Label changed for .uno:InsertPageNumberField
.uno:PageOffsetDialog removed from Customize dialog
There are no longer any conflicts/overlaps in the label names for "Page Number" in the Customize dialog (which motivated the OP), so closing this ticket as FIXED.