Quoting Olivier: (In reply to Olivier Hallot from Bug 154188 comment #2) > I think this feature is not ready and should be hidden in "experimental > features" options under Advanced options page, or even enabled in the > "Expert Mode". > > IMHO, the graphic test dialog - as it is now - need much more work to meet > our HID standards. So far the dialog miss a Help/OK/Cancel button row, no > way I found to resize it, possibly misfit small screens. If user press a > skipped test button, a micro-window pops and I found no way to resize it > > I also doubt if end-users need to run these tests. In many business > environments, features like this usually attract the unskilled, click-a-thon > person, that will not understand the results, and possibly call the Help > desk for support to explain or fix a broken test. I agree with Olivier: - Not much value for general users, only really useful when troubleshooting for developers / QA - and therefore unnecessarily clutters the page - More confusion for users if they end up trying it; unclear wording (e.g. "quirky") - Unfinished UI People needing those tests will still find the feature after turning Experimental on.
(In reply to Stéphane Guillou (stragu) from comment #0) +1
Something to be discussed in ESC ?
CC Tomaz, I think he mentored the project.
Reminds me on bug 155070 about the skia.log. +1 to hide functions that are not focused on the user workflow. Either as experimental feature or put it somewhere far away from the user, eg. the About dialog.
4 of us approve this change, let's set to new.
In cui/source/options/optgdlg.cxx hide m_xRunGPTests (and associated label?) depending on officecfg::Office::Common::Misc::ExperimentalMode::get().
Yes, I agree with comment 4: - Hiding "Run Graphics Tests" button behind "Experimental" flag and with Olivier's assessment quoted in comment 0: - Normal users typically don't need to run these tests - Leave it for QA/devs. - It'll put an extra burden on Help users/answerers over "broken" tests. - - - For example, here was a recent user who got (confused) by this button: /r/LibreOffice: "How should I interpret the results of the Graphics Test" - https://www.reddit.com/r/libreoffice/comments/1asysla/how_should_i_interpret_the_results_of_the/kqwbyng/ and this is what they asked: > As I came across this function and tested it, it turns out that half of the tests are labelled as "Quirky" despite having a computer more than powerful enough to handle this software. > > What do these results mean, and is there a way to make sure more tests turn out as "Passed" ? So I linked to Tomaz's fantastic explanation in Bug 152587 comment 7 + the LO Wiki's GSoC 2021 posts about its addition: - https://bugs.documentfoundation.org/show_bug.cgi?id=152587#c7 - https://wiki.documentfoundation.org/Development/GSoC/Successfully_Implemented_Ideas#Tests_for_the_VCL_graphic_backends - https://theproglevblog.blogspot.com/2021/08/google-summer-of-code-2021-project.html
Kira Tubo committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/6d5de74fb33d0bdd0fa4f44bfc6bc2b02c37aa11 tdf#155069 Make "Run Graphics Test" button experimental It will be available in 25.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
All these tests are run at first run, which causes significant delay, and it is done after startup progress bar reaches 100%. I think it is reasonable to remove those tests if running the tests does not lead to a meaningful result.
Kira Tubo committed a patch related to this issue. It has been pushed to "libreoffice-24-8": https://git.libreoffice.org/core/commit/0bfbee2e99a6e2f7e1408a5fc12c86508cfc60c2 tdf#155069 Make "Run Graphics Test" button experimental It will be available in 24.8.0.2. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
(In reply to Hossein from comment #9) > All these tests are run at first run, which causes significant delay, and it > is done after startup progress bar reaches 100%. > > I think it is reasonable to remove those tests if running the tests does not > lead to a meaningful result. Are their results used for anything? I thought they were only used when clicking "Run Graphics Tests" was pressed. Maybe something for a new ticket? (In reply to Commit Notification from comment #8) > Kira Tubo committed a patch related to this issue. > It has been pushed to "master": Thanks Kira! Verified in: Version: 25.2.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: ba0e0093b0ed2816a18e54eef0a92220d7b04a4d CPU threads: 8; OS: Linux 6.5; UI render: default; VCL: gtk3