Bug 155193 - [LOCALHELP] Do not deliver Help files with indexer=exclude
Summary: [LOCALHELP] Do not deliver Help files with indexer=exclude
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Documentation (show other bugs)
Version:
(earliest affected)
7.6.0.0 alpha0+
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:24.2.0 target:25.8.0 target:25...
Keywords:
Depends on:
Blocks: Help
  Show dependency treegraph
 
Reported: 2023-05-08 16:14 UTC by Olivier Hallot
Modified: 2024-12-15 17:13 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Olivier Hallot 2023-05-08 16:14:24 UTC
From redmine task#3650

https://redmine.documentfoundation.org/issues/3650

------------8<------------
Some help pages are only used as a collection of embeddable snippets for other pages. They are tagged with indexer="exclude", like here: https://opengrok.libreoffice.org/xref/help/source/text/simpress/00/00000404.xhp?r=04549b13#21

However, they still show up in search results: https://help.libreoffice.org/7.5/en-US/search?P=insert+menu

They should not be included in search results as they drown the relevant pages, and are confusing to end users.
------------8<------------

The fix is in the delivery makefile in helpcontent2/.
Comment 1 Stéphane Guillou (stragu) 2023-05-09 09:08:01 UTC
Confirming as redmine OP.
Thanks Olivier.
Comment 2 Olivier Hallot 2023-06-01 13:51:11 UTC
Patch submitted, need advise:

https://gerrit.libreoffice.org/c/help/+/151897
Comment 3 Commit Notification 2023-08-05 09:43:21 UTC
Olivier Hallot committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/help/commit/1c3257e391a8fbbdcde2dc380d9a8227745894bc

tdf#155193 Fill indexer= when omitted in Help files
Comment 4 Commit Notification 2023-08-10 10:21:29 UTC
Olivier Hallot committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/help/commit/539abfa7c3bbc9f0b234402083c743890b965cf7

tdf#155193 Do not deliver Help files with indexer=exclude
Comment 5 Commit Notification 2023-08-14 08:19:12 UTC
Xisco Fauli committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/help/commit/ebdeebb9b004df574ec90ead903ffa9c9b1f3235

Revert "tdf#155193 Do not deliver Help files with indexer=exclude"
Comment 6 Commit Notification 2024-12-09 20:56:47 UTC
Olivier Hallot committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/help/commit/635f1dc3de1c1af8b6a99205d2237c0650084bea

tdf#155193 No indexing when indexer="excluded" in <topic>
Comment 7 Commit Notification 2024-12-09 21:22:52 UTC
Olivier Hallot committed a patch related to this issue.
It has been pushed to "libreoffice-25-2":

https://git.libreoffice.org/help/commit/fc7580e1f16fb1c9e51da105180db06156d0eb74

tdf#155193 No indexing when indexer="excluded" in <topic>