Bug 155214 - Rename “Modify” button to "Assign"
Summary: Rename “Modify” button to "Assign"
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: LibreOffice (show other bugs)
Version:
(earliest affected)
7.3.7.2 release
Hardware: All All
: medium normal
Assignee: Not Assigned
URL: https://ask.libreoffice.org/t/assigni...
Whiteboard: target:24.2.0 inReleaseNotes:24.2
Keywords: difficultyBeginner, easyHack, skillDesign, topicUI
Depends on:
Blocks: Customize-Dialog-Keyboard
  Show dependency treegraph
 
Reported: 2023-05-09 12:12 UTC by Gustav Wall
Modified: 2024-01-26 07:08 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Gustav Wall 2023-05-09 12:12:45 UTC
here https://documentation.libreoffice.org/assets/Uploads/Documentation/en/GS5.1/HTML/GS5114-CustomizingLibreOffice.html the corresponding section has the heading “Assigning shortcut keys”. I suggest that the button in the “Keyboard” tab for assignment be labeled “Assign” as well. IMHO, the current “Modify” label is ambiguous and misleading.

The label “Modify” and the tooltip for it correctly describe the menu. But I think that "Modify" is unnecessarily too unspecific here. I initially incorrectly assumed that “Modify” ONLY refers to the top section “Shortcut keys” in the menu and has nothing to do with the “Functions” section. More understandable and not less correct compared to the current “Modify” label would be simply "Assign" to indicate that a hotkey is linked to a function.

= Menu Tools - Customize - Keyboard =
Actual Results:
“Modify” label 

Expected Results:
“Assign” label

Version: 7.3.7.2 / LibreOffice Community
Build ID: 30(Build:2)
CPU threads: 2; OS: Linux 5.19; UI render: default; VCL: kf5 (cairo+xcb)
Locale: de-DE (de_DE.UTF-8); UI: de-DE
Ubuntu package version: 1:7.3.7-0ubuntu0.22.04.2
Calc: threaded
Comment 1 Heiko Tietze 2023-05-10 10:59:28 UTC
Kind of bikeshedding but in fact you can assign more than one shortcut to a command. So Assign is probably better suited than Modify.
Comment 2 Roman Kuznetsov 2023-05-11 19:06:03 UTC
(In reply to Heiko Tietze from comment #1)
> Kind of bikeshedding but in fact you can assign more than one shortcut to a
> command. So Assign is probably better suited than Modify.

And you always modify the shortcut for action even you have no shortcut for the action now =)

I wouldn't touch it, "modify" is correct label here
Comment 3 V Stuart Foote 2023-05-12 14:52:34 UTC
(In reply to Roman Kuznetsov from comment #2)
> (In reply to Heiko Tietze from comment #1)
> > Kind of bikeshedding but in fact you can assign more than one shortcut to a
> > command. So Assign is probably better suited than Modify.
> 
> And you always modify the shortcut for action even you have no shortcut for
> the action now =)
> 
> I wouldn't touch it, "modify" is correct label here

Hmm, but what is being "modified"?  The key 'Assignment'. And isn't 'Delete' also a modification?

The action is duplex -- 'Modify' if a command is already assigned to the shortcut, 'Assign' if no command is assigned. Both dependent on the pick made below in the UI. So in reality we are always making and assignment.

So what single label best guides the work flow of changing an assignment or of making a new assignment?  'Assignment' in technical English would be my choice--can't speak to other locales.
Comment 4 Heiko Tietze 2023-05-25 08:46:39 UTC
We discussed the topic in the design meeting and think Assign suits better here.

Code pointer:

cui/uiconfig/ui/accelconfigpage.ui
Comment 5 t.aswath 2023-09-14 05:07:58 UTC
let me do this as my first EasyHack
Comment 6 Commit Notification 2023-09-18 05:43:28 UTC
t-aswath committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/e425c837aec0b11f381ddb49fe651acf5509bd82

tdf#155214 - rename "Modify" button to "Assign"

It will be available in 24.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 7 Commit Notification 2023-09-19 06:33:36 UTC
Ilmari Lauhakangas committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/help/commit/49cc168cf18562283b308f039cc8fc37b8866fed

tdf#155214 Rename Modify to Assign in keyboard shortcut customisation