Bug 155374 - Icons needed for new Uno command PageNumberWizard
Summary: Icons needed for new Uno command PageNumberWizard
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
7.6.0.0 alpha1+
Hardware: All All
: medium normal
Assignee: Rizal Muttaqin
URL:
Whiteboard: target:7.6.0 target:24.2.0 target:7.6...
Keywords:
Depends on:
Blocks: Icon-Request 156098
  Show dependency treegraph
 
Reported: 2023-05-17 17:53 UTC by Justin L
Modified: 2023-09-29 16:09 UTC (History)
6 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Justin L 2023-05-17 17:53:18 UTC
Insert -> Page number was changed from .uno:InsertPageNumberField to the new .uno:PageNumberWizard command with bug 86630's https://gerrit.libreoffice.org/c/core/+/144683

I considered adding it to the notebookbar, but didn't because there was no icon for it. https://gerrit.libreoffice.org/c/core/+/151398
Comment 1 Rizal Muttaqin 2023-05-25 10:39:35 UTC
How about using existing InsertPageNumberField icons? I don't think the dialog is a wizard in a real sense.
Comment 2 Justin L 2023-05-25 11:30:16 UTC
I'm sure that using the existing icon would be fine. It just needs to be wired up.
Comment 3 Commit Notification 2023-05-30 21:23:42 UTC
Rizal Muttaqin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/b2da36a0837c3d2614917f2382c19c070c5750ed

tdf#155374 Icons for PageNumberWizard

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 4 BogdanB 2023-05-31 14:27:26 UTC Comment hidden (obsolete)
Comment 5 Justin L 2023-06-09 14:11:43 UTC
I tested with 7.7, but I'm not seeing an image associated with it in customize toolbar or when I patch it into the notebookbar. When adding it to the toolbar I  get the name, no picture.

I thought I needed to add
        <prop oor:name="Properties" oor:type="xs:int">
          <value>1</value>
        </prop>
to officecfg/registry/data/org/openoffice/Office/UI/WriterCommands.xcu but that didn't help.
Comment 6 Stéphane Guillou (stragu) 2023-06-29 17:20:09 UTC Comment hidden (obsolete)
Comment 7 Rizal Muttaqin 2023-07-20 11:05:37 UTC
(In reply to Justin L from comment #5)
> I tested with 7.7, but I'm not seeing an image associated with it in
> customize toolbar or when I patch it into the notebookbar. When adding it to
> the toolbar I  get the name, no picture.
> 
> I thought I needed to add
>         <prop oor:name="Properties" oor:type="xs:int">
>           <value>1</value>
>         </prop>
> to officecfg/registry/data/org/openoffice/Office/UI/WriterCommands.xcu but
> that didn't help.

This is the one I used to add. But somehow the uno:insertpagenumberwizard is not defined in officecfg/registry/data/org/openoffice/Office/UI/WriterCommands.xcu. Has someone has an insight?

https://opengrok.libreoffice.org/search?project=core&full=insertpagenumberwizard&defs=&refs=&path=&hist=&type=&xrd=&nn=1
Comment 8 Rizal Muttaqin 2023-07-20 11:07:29 UTC
(In reply to Rizal Muttaqin from comment #7)

> This is the one I used to add. But somehow the uno:insertpagenumberwizard is
> not defined in
> officecfg/registry/data/org/openoffice/Office/UI/WriterCommands.xcu. Has
> someone has an insight?
> 

Maxim or Mike Kaganski, do you guys have a clue?
Comment 9 Justin L 2023-07-20 11:11:03 UTC
(In reply to Rizal Muttaqin from comment #7)
> But somehow the uno:insertpagenumberwizard is not defined...
It is, but it is called uno:PageNumberWizard
Comment 10 Commit Notification 2023-07-21 06:15:44 UTC
Rizal Muttaqin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/a5ea9d89e623ffae905393dacbd73683a07d5d76

tdf#155374 Icons for PageNumberWizard

It will be available in 24.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 11 Commit Notification 2023-07-26 15:33:58 UTC
Rizal Muttaqin committed a patch related to this issue.
It has been pushed to "libreoffice-7-6":

https://git.libreoffice.org/core/commit/22c6baefaa8d6866cfd584e2cafd60bf45b4103a

tdf#155374 Icons for PageNumberWizard

It will be available in 7.6.0.2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 12 Stéphane Guillou (stragu) 2023-09-29 16:09:31 UTC
Verified for all icon sets in:

Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: e9a0c97de95688b2f86bbb4dd8c823af5442401c
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

Much appreciated Rizal! :)