Bug 155434 - Several Calc menu commands are available in Read-Only mode
Summary: Several Calc menu commands are available in Read-Only mode
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
7.6.0.0 alpha1+
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: difficultyMedium, easyHack, skillCpp, topicUI
Depends on:
Blocks: Read-Only
  Show dependency treegraph
 
Reported: 2023-05-22 09:33 UTC by Gabor Kelemen (allotropia)
Modified: 2023-06-22 09:02 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Gabor Kelemen (allotropia) 2023-05-22 09:33:12 UTC
In Calc when a file is opened in Read-Only mode, several commands are available even if they do nothing, or show an information dialog saying "Document opened in read-only mode."

My collection of such items, so far:
• Edit: 
∘ Track Changes - Record, Manage, Protect is available in RO doc , should not be
∘ Cell Edit Mode 
• View: 
• Insert: 
∘ Named range or expression
• Format:
∘ Text - Wrap text
∘ Format - Number Format - <all items>
∘ Merge Cells - <both items>
• Styles
∘ All items
• Sheet
∘ Cycle Cell Reference Types
∘ Named Ranges and Expressions - Insert / Create / Labels 
• Data
∘ Define Range
∘ XML Source
∘ Form
∘ Consolidate
• Tools
∘ Goal Seek
∘ Solver
∘ Forms - Control Wizards / Open in Design Mode / Automatic Control Focus

It would be more user friendly to have these greyed out from RO documents menus.

Version: 7.6.0.0.alpha1+ (X86_64) / LibreOffice Community
Build ID: b3c88dc039d447322b8c8c564ab6e2f0ce9c5b90
CPU threads: 14; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win
Locale: en-US (hu_HU); UI: en-US
Calc: threaded
Comment 1 Heiko Tietze 2023-06-08 07:28:52 UTC
(In reply to Gabor Kelemen (allotropia) from comment #0)
> It would be more user friendly to have these greyed out from RO documents
> menus.
IMO not in general. You can maybe edit a copy of the document - and a completely changing UI is awkward then. Disabled is a good state for temporarily unavailable commands.
Comment 2 Eyal Rozenberg 2023-06-14 22:54:32 UTC
Heiko, IIANM, Gabor did not suggest removing these items and menus, but rather "graying them out" - since not everything that should be grayed out, is; especially menus and submenus.

I also think more graying-out is in order.
Comment 3 Heiko Tietze 2023-06-22 09:02:50 UTC
We discussed the topic in the design meeting. And of course those commands need to be _disabled_ when not available.

Commands have a state method where the check against read-only should be added. Easyhack, although medium difficult since adding the exact code pointer is 99% of the solution.