Description: In debug LibreOffice: Go to Tools - Options - Application Color - and from Automatic choose: Dark and Apply. This warning is listed several times: warn:legacy.osl:349899:349899:svtools/source/config/extcolorcfg.cxx:353: Color config entry has NIL as color value set! Should not! Steps to Reproduce: See description Actual Results: Warnings Expected Results: No warnings Reproducible: Always User Profile Reset: Yes Additional Info: Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 2e57755f72907e4bb604a8ba32edbd6c253ee57c CPU threads: 4; OS: Linux 6.2; UI render: default; VCL: gtk3 Locale: ro-RO (ro_RO.UTF-8); UI: en-US Calc: threaded
On pc Debian x86-64 with master sources updated today, I could reproduce this. The colors correspond to the 11 present in ./officecfg/registry/data/org/openoffice/Office/ExtendedColorScheme.xcu for reportbuilder. Just wonder if we should include these in: - cui/source/options/optcolor.cxx - svtools/source/config/colorcfg.cxx ... with #ifdef ENABLE_REPORTBUILDER/#endif blocks. Remark: it's not specific to Dark, it's just when you change theme. For example, if I clean the LO profile, LO uses by default "Light". If I change it to "System Theme", I also got these console logs. Also, idem if I put back "Light".
BTW, I don't understand what means "Automatic:" here. If it just corresponds to the scheme value, it's a bit weird. I would have put "Option". Scheme "Automatic" with Option "Light", "Dark" or "System Theme". Even "Automatic" value for scheme is not clear for me, moreover since I got only 1 value for "Scheme", it doesn't help.
The whole ExtendedColorScheme.xcu is weird. Do we need it at all? (In reply to Julien Nabet from comment #2) > BTW, I don't understand what means "Automatic:" here. We have hard-coded default values for Light and Dark. "Automatic" means we take those and not the user-defined. But you are right, there is plenty of room for improvements.
(In reply to Heiko Tietze from comment #3) > The whole ExtendedColorScheme.xcu is weird. Do we need it at all? No idea > > (In reply to Julien Nabet from comment #2) > > BTW, I don't understand what means "Automatic:" here. > > We have hard-coded default values for Light and Dark. "Automatic" means we > take those and not the user-defined. But you are right, there is plenty of > room for improvements. Ok so would rather be something like "By default"
Exchanging "Automatic" into "Default" is not much of an improvement and not solving Bogdan's finding anyway. Adding a compiler switch solves the issue in most but not all cases, adding the extended colors to the list would be okay as well as dropping it completely.
Retested with Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 0e17d8ddccdee7d4f46b256153853e1cab87c99e CPU threads: 16; OS: Linux 5.19; UI render: default; VCL: gtk3 Locale: ro-RO (ro_RO.UTF-8); UI: en-US Calc: threaded warn:legacy.osl:1071126:1071126:svtools/source/config/extcolorcfg.cxx:353: Color config entry has NIL as color value set! warn:legacy.osl:1071126:1071126:svtools/source/config/extcolorcfg.cxx:353: Color config entry has NIL as color value set! warn:legacy.osl:1071126:1071126:svtools/source/config/extcolorcfg.cxx:353: Color config entry has NIL as color value set! warn:legacy.osl:1071126:1071126:svtools/source/config/extcolorcfg.cxx:353: Color config entry has NIL as color value set! warn:legacy.osl:1071126:1071126:svtools/source/config/extcolorcfg.cxx:353: Color config entry has NIL as color value set! warn:legacy.osl:1071126:1071126:svtools/source/config/extcolorcfg.cxx:353: Color config entry has NIL as color value set! warn:legacy.osl:1071126:1071126:svtools/source/config/extcolorcfg.cxx:353: Color config entry has NIL as color value set! warn:legacy.osl:1071126:1071126:svtools/source/config/extcolorcfg.cxx:353: Color config entry has NIL as color value set! warn:legacy.osl:1071126:1071126:svtools/source/config/extcolorcfg.cxx:353: Color config entry has NIL as color value set! warn:legacy.osl:1071126:1071126:svtools/source/config/extcolorcfg.cxx:353: Color config entry has NIL as color value set! warn:legacy.osl:1071126:1071126:svtools/source/config/extcolorcfg.cxx:353: Color config entry has NIL as color value set!
Retested. warn:legacy.osl:170144:170144:svtools/source/config/extcolorcfg.cxx:353: Color config entry has NIL as color value set! warn:legacy.osl:170144:170144:svtools/source/config/extcolorcfg.cxx:353: Color config entry has NIL as color value set! warn:legacy.osl:170144:170144:svtools/source/config/extcolorcfg.cxx:353: Color config entry has NIL as color value set! warn:legacy.osl:170144:170144:svtools/source/config/extcolorcfg.cxx:353: Color config entry has NIL as color value set! warn:legacy.osl:170144:170144:svtools/source/config/extcolorcfg.cxx:353: Color config entry has NIL as color value set! warn:legacy.osl:170144:170144:svtools/source/config/extcolorcfg.cxx:353: Color config entry has NIL as color value set! warn:legacy.osl:170144:170144:svtools/source/config/extcolorcfg.cxx:353: Color config entry has NIL as color value set! warn:legacy.osl:170144:170144:svtools/source/config/extcolorcfg.cxx:353: Color config entry has NIL as color value set! warn:legacy.osl:170144:170144:svtools/source/config/extcolorcfg.cxx:353: Color config entry has NIL as color value set! warn:legacy.osl:170144:170144:svtools/source/config/extcolorcfg.cxx:353: Color config entry has NIL as color value set! warn:legacy.osl:170144:170144:svtools/source/config/extcolorcfg.cxx:353: Color config entry has NIL as color value set! Version: 24.8.0.0.alpha1+ (X86_64) / LibreOffice Community Build ID: 6d39b1a6068bbbd5ca4947f668f989dbfb73342d CPU threads: 16; OS: Linux 6.5; UI render: default; VCL: gtk3 Locale: ro-RO (ro_RO.UTF-8); UI: en-US Calc: threaded