Created attachment 187637 [details] Gap in the underline with mixed LTR/RTL text and a tab Description: After the fixes for the problems with bad underlines in justified text, I tried to test it with different test cases. 99d22fd79c5532fd6c1b167996e1c27216b92469 tdf#155557: Fix drawing mixed direction underlined text 43a5400063b17ed4ba4cbb38bdf5da4a991f60e2 tdf#152048: Fix underline width for Kashida-justified text Now, I see a gap when adding a 'tab' character to the text. This happens not only in justified text, but also with left, right and center justification of the text. Steps to Reproduce: 1. Open the attachment 2. Test different justification of the text (left, right, center, justified) Actual Results: Visible gap in the text underline Expected Results: All the text should be underlined, without any gap Reproducible: Always User Profile Reset: No Additional Info: Reproducible with: Version: 7.6.0.0.alpha1+ (X86_64) / LibreOffice Community Build ID: f15a6e1b1b186bf42e1ade05630d17841add2c46 CPU threads: 12; OS: Linux 5.19; UI render: default; VCL: gtk3 Locale: en-US (en_US.UTF-8); UI: en-US Calc: threaded Not reproducible with LO 7.5 (it has its own problems) Version: 7.5.1.2 (X86_64) / LibreOffice Community Build ID: fcbaee479e84c6cd81291587d2ee68cba099e129 CPU threads: 12; OS: Linux 5.19; UI render: default; VCL: gtk3 Locale: en-US (en_US.UTF-8); UI: en-US Calc: CL threaded
This is the same as 35907. *** This bug has been marked as a duplicate of bug 35907 ***
OK, so this is a regression of tdf#155557. So I probably opened the file in 7.5 and didn’t see the issue. May be that is what the code I removed was for 🤣
Khaled Hosny committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/ef30d351da288b3513cfd30cb82bff7e0827fcb3 tdf#155623: Revert "tdf#155557: Fix drawing mixed direction underlined text" It will be available in 7.6.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.