Bug 155649 - EDITING Writer Heading (aka Chapter) Numbering Position Parameters Cannot Go Beyond 17 mm
Summary: EDITING Writer Heading (aka Chapter) Numbering Position Parameters Cannot Go ...
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
7.5.3.2 release
Hardware: All All
: medium normal
Assignee: Julien Nabet
URL:
Whiteboard: target:24.8.0 target:24.2.0.2 target:...
Keywords:
Depends on:
Blocks: Heading-Numbering-Dialog
  Show dependency treegraph
 
Reported: 2023-06-02 13:09 UTC by bugzilla
Modified: 2024-02-26 19:27 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description bugzilla 2023-06-02 13:09:17 UTC
ISSUE SUMMARY:
While editing an 'old' document, I've discovered that I can no longer modify the Chapter Numbering Position parameters - alignment, tab stop or indent - beyond 17 mm.  Yet previous set Positions are correctly being displayed at 25, 30, 40 mm etc..

I'm experiencing this issue on these recent LO revisions: 
Mint 21   7.3.7.2
Win 10    7.4.6.2
Mint 21   7.5.3.2


TO OBSERVE:
 - Start a new Writer document with default A4 portrait page style via 
    Format > Page style > Page tab > Format

 - Set the unit of measure (UM) to 'mm' via
    Tools > LO Writer > General > Measurement unit > millimetre.

 - From Tools > Chapter Numbering attempt to change alignment, tab stop or indent parameters.

 - Observe they can't be increased beyond 17 mm.


ROOT CAUSE?
While checking this issue on another PC, I realised if the Writer UM is set to 'cm', positioning works correctly up to 17 cm. (Note 17 cm is the usable A4 page width between the default (margins which makes sense). The problem seems to be with Positioning 'validation' which limits values to 17 units even with UM= mm, whereas it should scale to 170.

If you alter the page margins then the Position 'maximum' values track the usable page width (as expected).


TEMP WORKAROUND:
Always use UM= cm when editing or first creating Chapter Numbering Positions. Once established, the document positions continue to function OK after changing UM back to 'mm' (mm is the 'norm' in Europe).
Comment 1 Julien Nabet 2023-06-03 07:13:46 UTC
On pc Debian x86-64 with master sources updated today, I could reproduce this.

Precision: it's "Heading Numbering" not "Chapter Numbering".

(then you must go to Position tab)
Comment 2 bugzilla 2023-09-18 13:51:28 UTC
Bug still present on v7.6.1.2
Comment 3 ajlittoz 2024-01-01 19:38:07 UTC
Still present in 7.6.4.2

Reported by a user under 7.6.4.1 in https://ask.libreoffice.org/t/heading-numbering-limitations-on-tab-stop-and-indent/100074

I checked the various possible units. The bug is not present if measurement unit is cm or inches. Note however that 17" (for A4 paper size with default 12cm margins = 17cm usable width) is far larger than common paper width thus the bug may also affect inches.

Apparently, the overflow test computes the available width in cm and blindly uses this number for capping user input WITHOUT converting to user-preferred measurement unit.
Comment 4 Julien Nabet 2024-01-01 21:41:27 UTC
Taking a new look here, it makes me think about tdf#126485.
In this last one, limits for the 3 attributes ("Alignment at", "Tab stop at", "Indent at") had been removed.
I suppose the same should be done here.

=> https://gerrit.libreoffice.org/c/core/+/161528
Comment 5 ajlittoz 2024-01-02 07:37:44 UTC
Perhaps bug 126485 and this one use erroneously some cm unit during their computations instead of the "internal" unit (something like 1/100 or 1/1000 mm, I don't remember) while the parameters are stored in "internal" unit.

This is the a consistency issue.
Comment 6 Commit Notification 2024-01-04 13:39:01 UTC
Julien Nabet committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/109e5e54a159b07314429dc004256c6ae2e799b1

tdf#155649: EDITING Writer some position parameters cannot go beyond 17 mm

It will be available in 24.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 7 Julien Nabet 2024-01-04 13:39:57 UTC
Patch for 24.2 waiting for review here:
https://gerrit.libreoffice.org/c/core/+/161630

Not sure it worths it for 7.6 branch but if someone wants to cherry-pick it, no pb.
Comment 8 Commit Notification 2024-01-08 08:48:44 UTC
Julien Nabet committed a patch related to this issue.
It has been pushed to "libreoffice-24-2":

https://git.libreoffice.org/core/commit/b7e68d467f99c7db357685adad13f738799009be

tdf#155649: EDITING Writer some position parameters cannot go beyond 17 mm

It will be available in 24.2.0.2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 9 Commit Notification 2024-01-10 10:11:35 UTC
Julien Nabet committed a patch related to this issue.
It has been pushed to "libreoffice-7-6":

https://git.libreoffice.org/core/commit/f6e5f36f1070735a975dc527226b78e5ff81bf77

tdf#155649: EDITING Writer some position parameters cannot go beyond 17 mm

It will be available in 7.6.5.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 10 bugzilla 2024-02-26 19:27:18 UTC
I can confirm this bug has been squashed from 7.6.5 on.

Thanks.