Bug 155729 - Set paragraph style drop down is able to create new styles, which is unconventional (and not fitting the label)
Summary: Set paragraph style drop down is able to create new styles, which is unconven...
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
7.6.0.0 alpha1+
Hardware: All All
: medium enhancement
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: difficultyMedium, easyHack, skillCpp, topicDesign
Depends on:
Blocks: Styles-Management
  Show dependency treegraph
 
Reported: 2023-06-08 09:47 UTC by Telesto
Modified: 2023-06-22 09:34 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Telesto 2023-06-08 09:47:17 UTC
Description:
Set paragraph style drop down is able to create new styles, which is unconventional (and not fitting the label)

Steps to Reproduce:
1. Open Writer
2. Type ABC 
3. Select ABC
3. Enable sidebar -> Paragraph Styles (for visuals what's happening)
4. Toolbar -> Paragraph Style Drop down
5. Pick Heading 2
6. Next type 'footnote' into the Paragraph Style drop down (and hit Enter)

Actual Results:
A new style created 'footnote' being child of 'Heading 2'

Expected Results:
I assumed it would filter styles.. In this case I expect nothing to happen


Reproducible: Always


User Profile Reset: No

Additional Info:
Version: 7.6.0.0.alpha1+ (X86_64) / LibreOffice Community
Build ID: 389a8d52d9961f89c0b2847b30ee1ca59a8fdc80
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: nl-NL (nl_NL); UI: en-US
Calc: CL threaded
Comment 1 Heiko Tietze 2023-06-09 08:02:59 UTC
If you write "Footnote" with correct capitalization it works as expected. Do you think we should drop the feature to create a style by just typing the new name in the dropdown (keeping the ability to search for a style, maybe case-insensitive)?
Comment 2 Eyal Rozenberg 2023-06-09 09:45:17 UTC
(In reply to Telesto from comment #0)
If you got prompted when this happens, "Create a new style named 'footnote'? Y/N" - would that be better in your view? I think I would be fine with that.

(In reply to Heiko Tietze from comment #1)
> Do
> you think we should drop the feature to create a style by just typing the
> new name in the dropdown (keeping the ability to search for a style, maybe
> case-insensitive)?

I would say  "no". But - if I were shown evidence that people _mistakenly_ do that a lot, then maybe I might change my mind.
Comment 3 Telesto 2023-06-09 10:28:40 UTC
(In reply to Eyal Rozenberg from comment #2)
> (In reply to Telesto from comment #0)
> If you got prompted when this happens, "Create a new style named 'footnote'?
> Y/N" - would that be better in your view? I think I would be fine with that.

It's an improvement.. I have no strong opinion. 

I'm more or less questioning the design, because it surprised me. Are you supposed to 'manage' styles with the toolbar, or only 'set' - read apply - a style, as the label suggests.

A) If I create a style - under in this case - heading 2 I expect it to be different from heading 2. The edit style dialog should probably open?

B) Why should the new style be a child of heading 2? Only because heading 2 was applied prior to this? You can't even tell this being the case, without the style sidebar open (or the edit style dialog)
Comment 4 Eyal Rozenberg 2023-06-09 10:51:33 UTC
(In reply to Telesto from comment #3)
> B) Why should the new style be a child of heading 2? Only because heading 2
> was applied prior to this?

Yes. You had Heading 2, you made some changes, you create a new style - that style is modified-Heading-2. Makes sense to me.

> You can't even tell this being the case, without
> the style sidebar open (or the edit style dialog)

Well, that's because the toolbar is a compact interface. It's a way to do something while accepting the defaults when the full interface is not in view.
Comment 5 Mike Kaganski 2023-06-12 08:45:28 UTC
(In reply to Eyal Rozenberg from comment #4)
> (In reply to Telesto from comment #3)
> > B) Why should the new style be a child of heading 2? Only because heading 2
> > was applied prior to this?
> 
> Yes. You had Heading 2, you made some changes, you create a new style - that
> style is modified-Heading-2. Makes sense to me.

Agree.

Generally, I have no strong feelings about this feature - completely in the realm of UX, can exist or be dropped (with inevitable https://xkcd.com/1172).
Comment 6 Heiko Tietze 2023-06-22 09:34:51 UTC
We discussed the topic in the design meeting.

Using the combobox to create a new style from selection is a handy function if the sidebar is closed and should remain available. It is also possible to change the font name to something not available on the system (Helvetica, Roboto...), which is the only way to design a document for another workstation.

The decision was to show a confirmation box "Do you want to create a new style from the current selection? [Yes/No]", ideally with a checkbox "[ ] Don't ask again" taking into consideration whether yes or no is pressed.

Easyhackable, but no code pointer at hand.