Bug 155735 - SVG: add support for feColorMatrix
Summary: SVG: add support for feColorMatrix
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: filters and storage (show other bugs)
Version:
(earliest affected)
7.6.0.0 alpha0+
Hardware: All All
: medium normal
Assignee: Xisco Faulí
URL:
Whiteboard: target:24.2.0 target:7.6.0.0.beta2 in...
Keywords:
Depends on:
Blocks: SVG-Import SVG-filters
  Show dependency treegraph
 
Reported: 2023-06-08 12:24 UTC by Xisco Faulí
Modified: 2023-07-07 15:51 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments
sample file (2.05 KB, image/svg+xml)
2023-06-08 12:24 UTC, Xisco Faulí
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Xisco Faulí 2023-06-08 12:24:35 UTC
Created attachment 187785 [details]
sample file

Steps to reproduce:
1. Open attached document and compare it with firefox/chrome

-> feColorMatrix is not supported

More info: https://developer.mozilla.org/en-US/docs/Web/SVG/Element/feColorMatrix

Reproduced in

Version: 7.6.0.0.alpha1+ (X86_64) / LibreOffice Community
Build ID: 244f9cf66bc36f229ccb5712bc8d80166b92266d
CPU threads: 8; OS: Linux 5.10; UI render: default; VCL: gtk3
Locale: es-ES (es_ES.UTF-8); UI: en-US
Calc: threaded
Comment 1 Commit Notification 2023-06-08 14:53:43 UTC
Xisco Fauli committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/b1d1a424a4d291873101f5d2348e5bd9cb9091a4

tdf#155735: Add basic support for feColorMatrix

It will be available in 24.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 2 Commit Notification 2023-06-08 20:55:31 UTC
Xisco Fauli committed a patch related to this issue.
It has been pushed to "libreoffice-7-6":

https://git.libreoffice.org/core/commit/a0ce0d4418ad92dd0e3a70cf698c549b544d6084

tdf#155735: Add basic support for feColorMatrix

It will be available in 7.6.0.0.beta2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 3 Stéphane Guillou (stragu) 2023-06-14 13:16:37 UTC
Confirmed with:

Version: 7.6.0.0.beta1 (X86_64) / LibreOffice Community
Build ID: be55b15d98c5f059483845a183fcb5ea8023d27c
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

With b1d1a424a4d291873101f5d2348e5bd9cb9091a4, only the bottom luminanceToAlpha differs from others, but still doesn't match the rendering in Firefox 114.0 or Chromium 114.0.5735.106
Comment 4 Commit Notification 2023-06-14 19:08:44 UTC
Xisco Fauli committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/41bf4139cab36984cff514bfdd6b1b13576746a3

tdf#155735: Add support for saturate type

It will be available in 24.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 5 Commit Notification 2023-06-15 06:53:49 UTC
Xisco Fauli committed a patch related to this issue.
It has been pushed to "libreoffice-7-6":

https://git.libreoffice.org/core/commit/593a428b901dd1473b850e56d1e3d898ca229d00

tdf#155735: Add support for saturate type

It will be available in 7.6.0.0.beta2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 6 Commit Notification 2023-06-16 19:10:25 UTC
Xisco Fauli committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/7d231453fcc75c2c621522098fe1d42b14be546b

tdf#155735: unify unittest

It will be available in 24.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 7 Commit Notification 2023-06-20 21:13:31 UTC
Xisco Fauli committed a patch related to this issue.
It has been pushed to "libreoffice-7-6":

https://git.libreoffice.org/core/commit/f2f4bf495aba09d53edf7028f79db46bf7c6f2dc

tdf#155735: unify unittest

It will be available in 7.6.0.0.beta2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 8 Xisco Faulí 2023-06-20 21:16:09 UTC
(In reply to Stéphane Guillou (stragu) from comment #3)
> Confirmed with:
> 
> Version: 7.6.0.0.beta1 (X86_64) / LibreOffice Community
> Build ID: be55b15d98c5f059483845a183fcb5ea8023d27c
> CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
> Locale: en-AU (en_AU.UTF-8); UI: en-US
> Calc: threaded
> 
> With b1d1a424a4d291873101f5d2348e5bd9cb9091a4, only the bottom
> luminanceToAlpha differs from others, but still doesn't match the rendering
> in Firefox 114.0 or Chromium 114.0.5735.106

it looks much better after b0c2e580a1c5b055295d303ebb9c9e905ab4890c "tdf#155814: only check parent style when it has a local css style" which fixes a preexisting issue
Comment 9 Commit Notification 2023-06-21 20:04:01 UTC
Xisco Fauli committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/2ff1d94ba28b6c3c7e7d1599c5de0333426d5e2c

tdf#155735: use B3DHomMatrix in BColorModifier_saturate

It will be available in 24.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 10 Commit Notification 2023-06-21 20:04:03 UTC
Xisco Fauli committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/f3db857905437d4ce3b41fd75bd591e2f7801c5f

tdf#155735: Add tests in basegfx

It will be available in 24.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 11 Commit Notification 2023-06-21 22:33:16 UTC
Xisco Fauli committed a patch related to this issue.
It has been pushed to "libreoffice-7-6":

https://git.libreoffice.org/core/commit/df2da6be2aa336a6f93fa2c41503559678a2fedf

tdf#155735: Add tests in basegfx

It will be available in 7.6.0.0.beta2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 12 Commit Notification 2023-06-21 22:33:19 UTC
Xisco Fauli committed a patch related to this issue.
It has been pushed to "libreoffice-7-6":

https://git.libreoffice.org/core/commit/6b20c4bfbc713fe6164549f5642cff3d2b277654

tdf#155735: use B3DHomMatrix in BColorModifier_saturate

It will be available in 7.6.0.0.beta2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 13 Commit Notification 2023-06-22 06:24:54 UTC
Xisco Fauli committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/a62513e1e80e39f9928e9e1815a84761403a4f2b

tdf#155735: Add support for hueRotate type

It will be available in 24.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 14 Commit Notification 2023-06-22 07:48:02 UTC
Xisco Fauli committed a patch related to this issue.
It has been pushed to "libreoffice-7-6":

https://git.libreoffice.org/core/commit/cd3c376da36acf76327290b83eac8563f3bf562e

tdf#155735: Add support for hueRotate type

It will be available in 7.6.0.0.beta2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 15 Commit Notification 2023-06-22 15:19:47 UTC
Xisco Fauli committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/e121f7b37c48b6d843dfdd1d774d2a40567c46c7

tdf#155735: Add support for matrix type

It will be available in 24.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 16 Xisco Faulí 2023-06-22 15:20:01 UTC
We can called this issue fixed!
Comment 17 Commit Notification 2023-06-22 18:58:19 UTC
Xisco Fauli committed a patch related to this issue.
It has been pushed to "libreoffice-7-6":

https://git.libreoffice.org/core/commit/8395acfec900ea23d25632909eb22e02763bbe37

tdf#155735: Add support for matrix type

It will be available in 7.6.0.0.beta2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 18 Stéphane Guillou (stragu) 2023-06-23 10:06:09 UTC
Verified the fix, sample file looks great in:

Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: bbf6fa94a92abc1085addaba20519ee0166bae5e
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

Thank you for this work Xisco!
Comment 20 Xisco Faulí 2023-06-23 13:57:14 UTC
(In reply to Stéphane Guillou (stragu) from comment #19)
> In release notes:
> https://wiki.documentfoundation.org/index.php?title=ReleaseNotes%2F7.
> 6&type=revision&diff=675150&oldid=675131

Nicee. Thanks a lot.
Would you mind also adding tdf#132246 (feGaussianBlur) ? Otherwise, I can also do it
Comment 21 Commit Notification 2023-06-24 10:34:03 UTC
Xisco Fauli committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/75399b8aad6c0f0998b9d0a6eddb2e29f8bc114c

tdf#132246, tdf#155735: Add support for SourceAlpha

It will be available in 24.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 22 Commit Notification 2023-06-24 12:38:25 UTC
Xisco Fauli committed a patch related to this issue.
It has been pushed to "libreoffice-7-6":

https://git.libreoffice.org/core/commit/31a66dab1e7d39e2d2062442f41090c583466cc1

tdf#132246, tdf#155735: Add support for SourceAlpha

It will be available in 7.6.0.0.beta2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 23 Commit Notification 2023-06-25 17:51:34 UTC
Xisco Fauli committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/a013911b8661daff2cdd58f0bf233ee7116f3029

tdf#155735: cid#1532475 Out-of-bounds access

It will be available in 24.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 24 Commit Notification 2023-06-25 21:05:49 UTC
Xisco Fauli committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/99b1459dbbe5faa47b5fc9b4ed767932d46a02cb

tdf#155735: use 4x4 matrices in tests

It will be available in 24.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 25 Commit Notification 2023-06-26 07:52:59 UTC
Xisco Fauli committed a patch related to this issue.
It has been pushed to "libreoffice-7-6":

https://git.libreoffice.org/core/commit/cba8d49b78567edf98f2ce81999d19a3130026b9

tdf#155735: cid#1532475 Out-of-bounds access

It will be available in 7.6.0.0.beta2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 26 Commit Notification 2023-06-26 21:15:21 UTC
Xisco Fauli committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/9951ffedd6941234447b9655fbc49ed6ca4cc64c

Revert "tdf#132246, tdf#155735: Add support for SourceAlpha"

It will be available in 24.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 27 Commit Notification 2023-06-27 11:39:58 UTC
Xisco Fauli committed a patch related to this issue.
It has been pushed to "libreoffice-7-6":

https://git.libreoffice.org/core/commit/5e713ba80fcc7a4157cb7a7e7c3c3476c91f59d4

Revert "tdf#132246, tdf#155735: Add support for SourceAlpha"

It will be available in 7.6.0.0.beta2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 28 Commit Notification 2023-07-07 15:36:02 UTC
Xisco Fauli committed a patch related to this issue.
It has been pushed to "libreoffice-7-6":

https://git.libreoffice.org/core/commit/9111a6154e40f5c9a7d5d5470f76597b1cbaa8ec

related: tdf#155735: clamp RGB values

It will be available in 7.6.0.0.beta2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 29 Commit Notification 2023-07-07 15:51:06 UTC
Xisco Fauli committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/22e46544eebe027654bb4ecfc42e8d8ebb41ec48

related: tdf#155735: clamp RGB values

It will be available in 24.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.