Fileopen DOCX:Page numbers are missing on the footer for a particualr file. Steps to Reproduce: 1.Please open attached "Page_Numbers_Issue_Lo.docx"in Lo 2.Observe that the page numbers are missing at the bottom. Expected Result: Page numbers should be visible Page 1 of 2 Page 2 of 2 Actual Results: Page numbers are missing only text is visible as "Page of " Reproducible : Not happens with every file. Additional Info: The problem can be reproducible with latest(7.6.0.0 alpha1+master) and previous builds also.
Created attachment 187786 [details] Sample file which can be used to duplicate the issue.
MS office is displaying the page numbers properly for the attached file.
Created attachment 187787 [details] Missing_Page_Numbers
This is a field inside of a content control (regular SDT with a blockSDT) Nothing was seen in the footer in OOo 3.3. It was working in 4.0, and broke in 4.2.6. Using bibisect-43max, I hit a short range of 5 commits that had to be skipped. Almost certainly due to this commit, since it was backported to 4.2.6: commit 9679e9c23216decb5f9f25f85b04cb3f25211111 Author: Vinaya Mandke on Mon Dec 30 16:22:30 2013 +0530 tdf#69649 Fix for pre-rendered Table Of Contents
The range of commit was https://cgit.freedesktop.org/libreoffice/core/log/?qt=range&q=c619f8747bcf04454645774729ccf5d91fac55f1..92518d513fe021be58a0bbeb04fd9306eb23ebda The other bug reports that reference the bad commit might be helpful as well. https://bugs.documentfoundation.org/buglist.cgi?list_id=1610858&longdesc=9679e9c23216decb5f9f25f85b04cb3f25211111&longdesc_type=allwordssubstr&query_format=advanced&resolution=---&resolution=FIXED&resolution=INVALID&resolution=WONTFIX&resolution=DUPLICATE&resolution=WORKSFORME&resolution=MOVED&resolution=NOTABUG&resolution=NOTOURBUG&resolution=INSUFFICIENTDATA
This also seems to do with the footer placement: If I copy the paragraph from the footer and insert it in the document body in Word, then it works in Writer, the initial values are visible and adding a page break increases the second number (of pages).
Justin, It looks like the commit you pointed out is the culprit. Page numbers are displaying as expected if I comment this line m_bStartTOC = true; in DomainMapper_Impl::handleToc method. I still need to track down how this member m_bStartTOC is causing this issue when set to true. Please let me know, if you have a direct answer or guess.
(In reply to SATYA SRINIVAS K from comment #7) > Please let me know, if you have a direct answer or guess. IIUC, this is a lot of hacky stuff, so it all could be dreadfully wrong. I believe there was a lot of code changes/research into this area recently, and some of it dealt with exceptions. So, it will take a fair amount of work to try and wrap your mind around what the code is doing here. I suggest adding SAL_WARN statements when TOC starts and stops, when Push/PopPageHeaderFooter, at Push/PopSdt, and when CloseSectionGroup so that you get a feel for the flow of the code. In general, we have a LOT of problems in writerfilter because we don't have a stack. For example, you may be working in a paragraph, and then begin a content control (which also has its own paragraph) which contains a shape (which also has its own paragraph). So now, which of the writerfilter properties can you believe? You can't trust the "this is the first paragraph in the section" or pretty much any other property. Likely the same thing is true for m_bStartTOC. I tried to create stack properties once, but failed because RTF format doesn't track closely enough with DOCX (and they both share the same code). But in this case you can probably say "since I am in a footer, I can ignore any TOC flags because obviously I am not building a TOC right now". You will find lots of IsInHeaderFooter() examples similar to this in writerfilter.
(In reply to Justin L from comment #8) > IIUC, this is a lot of hacky stuff, so it all could be dreadfully wrong. I > believe there was a lot of code changes/research into this area recently See bug 154478 which replaces a similar fix made for bug 154481.
Satya committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/d7dd39e124f8a1fa199dd8322b642e8be04ed360 tdf#155736 Modified IsInTOC() to handle IsInHeaderFooter() case. It will be available in 24.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Satya committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/4da11a5d39ccd9f59e326011d4de7ffee8a71d10 tdf#155736 replaced m_bStartTOC condition with a method IsInTOC() It will be available in 24.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Satya - next time you are done submitting patches and the bug is resolved, please mark as resolved/fixed.
Satya committed a patch related to this issue. It has been pushed to "libreoffice-7-6": https://git.libreoffice.org/core/commit/d3cf473ceb2a0711ca723ed680034b9251dccbbd tdf#155736 Modified IsInTOC() to handle IsInHeaderFooter() case. It will be available in 7.6.1. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.