Bug 155810 - Justified Arabic text has gaps between characters in presentation mode
Summary: Justified Arabic text has gaps between characters in presentation mode
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Impress (show other bugs)
Version:
(earliest affected)
7.5.3.2 release
Hardware: All All
: medium normal
Assignee: ⁨خالد حسني⁩
URL:
Whiteboard: target:24.2.0 target:7.6.0.0.beta2
Keywords:
Depends on:
Blocks: Slide-Show Kashida-Justification, Tatweel
  Show dependency treegraph
 
Reported: 2023-06-13 05:15 UTC by Fahad Al-Saidi
Modified: 2023-06-19 18:46 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments
test file (33.06 KB, application/vnd.oasis.opendocument.presentation)
2023-06-13 05:16 UTC, Fahad Al-Saidi
Details
the error (26.27 KB, image/png)
2023-06-13 05:19 UTC, Fahad Al-Saidi
Details
used font that has the problem (95.14 KB, application/zip)
2023-06-13 05:26 UTC, Fahad Al-Saidi
Details
Screenshot showing no gaps (35.78 KB, image/png)
2023-06-13 07:47 UTC, ⁨خالد حسني⁩
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Fahad Al-Saidi 2023-06-13 05:15:05 UTC
Description:
it is supposed to be fixed in #106653 , so I don't know if it is a regression. not happened with all font though.




Actual Results:
gaps between characters in text justified

Expected Results:
no gaps between characters in text justified


Reproducible: Always


User Profile Reset: No

Additional Info:
Version: 7.5.3.2 (X86_64) / LibreOffice Community
Build ID: 50(Build:2)
CPU threads: 4; OS: Linux 5.19; UI render: default; VCL: gtk3
Locale: en-US (en_US.UTF-8); UI: en-US
Ubuntu package version: 4:7.5.3~rc2-0ubuntu0.22.04.1~lo1
Calc: threaded
Comment 1 Fahad Al-Saidi 2023-06-13 05:16:43 UTC
Created attachment 187878 [details]
test file

test file with impress text justified
Comment 2 Fahad Al-Saidi 2023-06-13 05:19:19 UTC
Created attachment 187879 [details]
the error
Comment 3 Fahad Al-Saidi 2023-06-13 05:26:44 UTC
Created attachment 187880 [details]
used font that has the problem
Comment 4 ⁨خالد حسني⁩ 2023-06-13 07:47:54 UTC
Created attachment 187881 [details]
Screenshot showing no gaps

I can not reproduce this, neither with:
Version: 7.5.4.2 (X86_64) / LibreOffice Community
Build ID: 36ccfdc35048b057fd9854c757a8b67ec53977b6
CPU threads: 6; OS: Mac OS X 13.4; UI render: default; VCL: osx
Locale: en-EG (en_EG.UTF-8); UI: en-US
Calc: threaded

nor with:
Version: 7.5.3.2 (X86_64) / LibreOffice Community
Build ID: 50(Build:2)
CPU threads: 6; OS: Linux 6.3; UI render: default; VCL: gtk3
Locale: en-US (en_US.UTF-8); UI: en-US
7.5.3-2
Calc: threaded
Comment 5 Fahad Al-Saidi 2023-06-13 07:53:19 UTC
sorry I should mention that the problem shows only in presentation mode (slide show F5) only
Comment 6 ⁨خالد حسني⁩ 2023-06-13 07:59:36 UTC
Thanks, I can confirm this.
Comment 7 Hossein 2023-06-13 11:42:37 UTC
(In reply to ⁨خالد حسني⁩ from comment #6)
> Thanks, I can confirm this.
Isn't this a duplicate of tdf#151748? I see the same pattern of gaps and bad horizontal lines. One may expect slightly different rendering in edit and presentation mode, but anyway I see the same sort of problem in both cases with a different font from what is used in the sample document.
Comment 8 ⁨خالد حسني⁩ 2023-06-13 12:54:25 UTC
(In reply to Hossein from comment #7)
> (In reply to ⁨خالد حسني⁩ from comment #6)
> > Thanks, I can confirm this.
> Isn't this a duplicate of tdf#151748? I see the same pattern of gaps and bad
> horizontal lines. One may expect slightly different rendering in edit and
> presentation mode, but anyway I see the same sort of problem in both cases
> with a different font from what is used in the sample document.

Looks different, here no Kashidas are inserted at all but space is reserved for them, also based on discussion on IRC slide show seems to have its unique code path that is not exercised elsewhere.
Comment 9 Commit Notification 2023-06-18 20:02:37 UTC
Khaled Hosny committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/68a4f005bc3e74d847e82dddf3237137cf3a1648

tdf#155810: Pass Kashida insertion positions through canvas

It will be available in 24.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 10 Commit Notification 2023-06-19 05:37:22 UTC
Khaled Hosny committed a patch related to this issue.
It has been pushed to "libreoffice-7-6":

https://git.libreoffice.org/core/commit/a20093c2b7f4ad0822a34507980f5be9d47b812c

tdf#155810: Pass Kashida insertion positions through canvas

It will be available in 7.6.0.0.beta2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 11 Commit Notification 2023-06-19 18:46:48 UTC
Khaled Hosny committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/5dfaecfd87df45953f6d4a85704aab9eb99b0d0e

tdf#155810: Add test

It will be available in 24.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.