Bug 155926 - Rename line styles like "Long dot", "Double dash" and "Line Style 9"
Summary: Rename line styles like "Long dot", "Double dash" and "Line Style 9"
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
unspecified
Hardware: All All
: medium minor
Assignee: Heiko Tietze
URL:
Whiteboard: target:24.2.0
Keywords:
Depends on:
Blocks: Shapes-Line
  Show dependency treegraph
 
Reported: 2023-06-19 12:46 UTC by Tuomas Hietala
Modified: 2023-08-25 09:13 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments
Comparison MSO vs LibO (38.00 KB, image/png)
2023-07-14 10:22 UTC, Heiko Tietze
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Tuomas Hietala 2023-06-19 12:46:59 UTC
Description:
Some of the line styles in LO have somewhat confusing names.

"Long dot" does not actually mean that the dots are long. Instead, there's more space between the dots.
Suggestion: "Sparse dots"

"Double dash" does not actually mean that the dashes appear in pairs. They're just longer.
Suggestion: "Double-length dashes" or "Extra long dashes"

"Line Style 9" needs a better name, if it needs to exist at all. (Seems like another dashed line.)

There's also no consistency with regard to singular and plural in the style names. I suggest using plurals consistently (i.e. dashes and dots instead of dash and dot).


Steps to Reproduce:
1. e.g. Draw a line in Draw, change the line style.

 

Actual Results:
The names are confusing and inconsistent.

Expected Results:
The names are well thought-out and consistent.


Reproducible: Always


User Profile Reset: No

Additional Info:
Weblate: https://translations.documentfoundation.org/languages/en/libo_ui-master/search/?offset=1&q=RID_SVXSTR_DASH&sort_by=-priority%2Cposition&checksum=
Comment 1 Heiko Tietze 2023-06-20 09:00:40 UTC
(In reply to Tuomas Hietala from comment #0)
> Suggestion: "Sparse dots"
> Suggestion: "Double-length dashes"
Sounds good to me.

> "Line Style 9" needs a better name, if it needs to exist at all. (Seems like
> another dashed line.)
It was added for bug 127499 to show some name when loading MSO documents, I guess. Either renaming to something weird like "Small dashes" or, as suggested on the other ticket, no additional inbuilt lines styles but some reasonable name on loading ("User-define 1..n"). Which would require coding work.

Opinions, objections, obstacles?
Comment 2 Regina Henschel 2023-06-20 11:32:11 UTC
In my opinion:
(A) The number of dash styles in the standard.sod palette should be restricted to those styles which correspond to the dash styles used in MS Office, each in addition in a "round" variant.
(B) The list in the Line dialog should show all additional dash styles, which are contained in the current active document, maybe which are contained in current open documents. The displayed names could be prefixed to mark those.
(C) The name of a dash style in standard.sod should clearly state its structure.
(D) The purpose of the "sys" dash styles had been to map them directly to styles available in rendering engines, which results in faster rendering. In case that is still true, those styles should be marked. 

The dialog still allows to edit and create dash styles and to save and load palettes. So a default palette with a lower number of styles is no principle restriction.
Listing the styles of the document allows to edit older existing documents using those styles usual at the time of creating the document. It would also help editing documents produced by foreign applications.
The preview of the style in the list item is too small to allow a good distinction. Therefore a structure-describing name helps. Of cause for the dash styles coming from the document, the name has to be used by which it is defined in the document.

So for me it is not a simple "rename style" but there is some coding needed.
Comment 3 Heiko Tietze 2023-06-21 12:39:46 UTC
(In reply to Regina Henschel from comment #2)
> restricted to ... correspond ... styles used in MS Office
I dislike those statements.

> So for me it is not a simple "rename style" but there is some coding needed.
Reasonable idea but renaming is quick and cheap. If we do this first the question remains what to do with LS9.
Comment 4 Heiko Tietze 2023-07-14 10:22:57 UTC
Created attachment 188371 [details]
Comparison MSO vs LibO

Microsoft 365 MSO (Version 2306 Build 16.0.16529.20100) has 8 inbuilt line styles of which we recognize aka label only two. If there was some effort to align the design it is doomed to fail. On the other hand we offer many styles and looking at the first four none is listed as a default in MSO, of course. 

My take: get rid of LS9 (and ideally also some more). And if necessary rename. However, "Long Dash" is used by MSO so probably familiar to users. And I also see not much benefit in renaming the other options. What do you think, Tuomas?
Comment 5 Heiko Tietze 2023-08-25 07:48:00 UTC
Looking into the code it seems we cannot get easily rid of line styles, see https://gerrit.libreoffice.org/c/core/+/78372/.

So the best option is to rename. Since Long Dot and Double Dash are common on MSO, only "Line Style 9" remains. I'm going to use the proposed "Sparse Dash" here.

Side note: We have 30 hard-coded dash variants (plus the option to customize individually). That's totally wrong IMO. We don't need to (more or less properly) name every attribute read from alien formats and should focus on an easy to use application with meaningful defaults.
Comment 6 Commit Notification 2023-08-25 09:13:03 UTC
Heiko Tietze committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/df982f67ced630fc417540941392459dee8ab7eb

Resolves tdf#155926 - Rename "Line Style 9"

It will be available in 24.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.