Bug 155955 - Very small Calc window size after deleting the configuration file (GTK3)
Summary: Very small Calc window size after deleting the configuration file (GTK3)
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
6.3.0.4 release
Hardware: All Linux (All)
: medium minor
Assignee: Amin Irgaliev
URL:
Whiteboard: target:24.2.0
Keywords: bibisected, bisected, regression
Depends on:
Blocks: GTK3
  Show dependency treegraph
 
Reported: 2023-06-21 08:13 UTC by Amin Irgaliev
Modified: 2024-02-01 14:38 UTC (History)
7 users (show)

See Also:
Crash report or crash signature:


Attachments
Reproducing a bug with gtk3 (1.03 MB, video/mp4)
2023-06-21 10:16 UTC, Vladislav Tarakanov
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Amin Irgaliev 2023-06-21 08:13:17 UTC
Description:
If you delete the configuration file, then open the Libreoffice, then close and reopen, turn it on in windowed mode, then the window will be practically invisible

Steps to Reproduce:
1. Delete "registrymodifications.xcu" file in home/.config/libreoffice/4/user/
2. Open libreoffice with vcl plugin gtk3 (tested on calc)
3. Close libreoffice
4. Open libreoffice and change to windowed mode

Actual Results:
Window size is a few pixels
In file "registrymodifications.xcu" value of "ooSetupFactoryWindowAttributes" is "0,0,2,2;,,,;"

Expected Results:
Window size is a normal


Reproducible: Always


User Profile Reset: No

Additional Info:
Comment 1 Roman Kuznetsov 2023-06-21 09:07:52 UTC
Amin, do you see the same behavior if start LibreOffice with

SAL_USE_VCLPLUGIN=gen soffice ?
Comment 2 Amin Irgaliev 2023-06-21 09:21:34 UTC
(In reply to Roman Kuznetsov from comment #1)
> Amin, do you see the same behavior if start LibreOffice with
> 
> SAL_USE_VCLPLUGIN=gen soffice ?

No, this behavior is not observed in gen or kf5
Comment 3 Vladislav Tarakanov 2023-06-21 10:16:33 UTC
Created attachment 188036 [details]
Reproducing a bug with gtk3

For clarification, add a video with the reproduction of this bug

Version: 7.0.4.2
Build ID: 00(Build:2)
CPU threads: 12; OS: Linux 5.10; UI render: default; VCL: gtk3
Locale: ru-RU (ru_RU.UTF-8); ИП: ru-RU
Debian package version: 1:7.0.4-4+deb11u7
Calc: threaded
Comment 4 Stéphane Guillou (stragu) 2023-06-21 11:36:47 UTC
Tested with Writer, Calc, Draw and Impress in:

Version: 7.5.4.2 (X86_64) / LibreOffice Community
Build ID: 36ccfdc35048b057fd9854c757a8b67ec53977b6
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: fr-FR (en_AU.UTF-8); UI: en-US
Calc: threaded

Only Calc would restore to a very small size following your steps. It happens already at step 2 for me. I can only see some of the menu of the window.

I'd call this a duplicate of bug 125543, with different steps.

*** This bug has been marked as a duplicate of bug 125543 ***
Comment 5 Stéphane Guillou (stragu) 2023-06-21 14:14:42 UTC
Hm I had another look and I think we can keep this Calc- and GTK-specific issue separate.

Behaviour started in 6.3. Bibisected with linux-64-6.3 repo to first bad commit 4c980dd7aa18f318d8670ed8dde181aec3b54b62 which points to core commit:

commit 78a1fd8e1d48f9cbc71b35b1c27379c6152667cc
author	Serge Krot <Serge.Krot@cib.de>	Tue May 07 10:10:33 2019 +0200
committer	Thorsten Behrens <Thorsten.Behrens@CIB.de>	Tue May 07 11:45:15 2019 +0200
tdf#124829 sc: fix crash during progress update
Call reschedule() during update of the cells height is not
thread safe.
Reviewed-on: https://gerrit.libreoffice.org/71892

My steps are: remove user profile directory; start soffice. After the commit, Calc window starts tiny.
No repro with other components; no repro with kf5, qt5 or gen VCLs.

Serge is not active anymore. Maybe Noel has an idea?

Amin, you assigned yourself, do you mean you are planning to submit a patch for this issue?
Comment 6 Vladislav Tarakanov 2023-06-21 14:30:17 UTC
(In reply to Stéphane Guillou (stragu) from comment #5)
> 
> Amin, you assigned yourself, do you mean you are planning to submit a patch
> for this issue?

Yes, we plan to fix this bug ourselves. Now tested with setting the window size with the function gtk_window_set_default_size() when initializing the window in the gtk3 module. Previously, we simply waited for confirmation from other project members before submitting a patch.
Comment 7 Amin Irgaliev 2023-06-22 11:35:31 UTC
(In reply to Stéphane Guillou (stragu) from comment #4)
>
> I'd call this a duplicate of bug 125543, with different steps.

Our bug fix (155955) accidentally fixes the bug described in comment 35 of this report in a local test. Perhaps in bug 125543 the configuration file is not loaded after importing the csv file. After fixing bug 155955, we will check this idea, it may be possible to fix bug 125543.
Comment 8 Commit Notification 2023-06-22 16:36:03 UTC
Vladislav Tarakanov committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/be53ee28d7435809e71e7e6b2ce929c87f07ba33

tdf#155955 - small Calc window size after deleting the configuration file

It will be available in 24.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 9 Stéphane Guillou (stragu) 2023-06-23 10:13:12 UTC
I verify the fix in:

Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: bbf6fa94a92abc1085addaba20519ee0166bae5e
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

Thank you Vladislav!
You can mark this one as "resolved - fixed", unless you've got follow-up commits?